[iframe] Suppress the `resize` events when saving/restoring [chromium/src : main]

0 views
Skip to first unread message

Koji Ishii (Gerrit)

unread,
4:45β€―AMΒ (9 hours ago)Β 4:45β€―AM
to Ian Kilpatrick, Chromium LUCI CQ, David Bokan, chromium...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org
Attention needed from Ian Kilpatrick

Koji Ishii voted and added 1 comment

Votes added by Koji Ishii

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Koji Ishii . resolved

PTAL. While this needs more thoughts, not sending the `resize` events is fine, right?

Open in Gerrit

Related details

Attention is currently required from:
  • Ian Kilpatrick
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id23a4118056c367304b29d395be747d4a72de13c
Gerrit-Change-Number: 7554051
Gerrit-PatchSet: 3
Gerrit-Owner: Koji Ishii <ko...@chromium.org>
Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
Gerrit-Reviewer: Koji Ishii <ko...@chromium.org>
Gerrit-CC: David Bokan <bo...@chromium.org>
Gerrit-Attention: Ian Kilpatrick <ikilp...@chromium.org>
Gerrit-Comment-Date: Sun, 08 Feb 2026 09:45:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

AI Code Reviewer (Gerrit)

unread,
4:47β€―AMΒ (9 hours ago)Β 4:47β€―AM
to Koji Ishii, Ian Kilpatrick, Chromium LUCI CQ, David Bokan, chromium...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org
Attention needed from Ian Kilpatrick

AI Code Reviewer added 1 comment

File third_party/blink/renderer/core/dom/document_resize_options.h
Line 14, Patchset 3 (Latest): bool suppress_events = false;
AI Code Reviewer . unresolved

nit: Blink Style Guide: Precede boolean values with words like β€œis” and β€œdid”. Consider naming this 'should_suppress_events'.

To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
**Done** | **OK But Won't Fix**: reason | **Later**: b/<bug_id> | **Invalid:** reason


_This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent)._
_AI reviews can sometimes be inaccurate; We appreciate your πŸ™ feedback πŸ™ to help us improve._
_[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_

Open in Gerrit

Related details

Attention is currently required from:
  • Ian Kilpatrick
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Id23a4118056c367304b29d395be747d4a72de13c
    Gerrit-Change-Number: 7554051
    Gerrit-PatchSet: 3
    Gerrit-Owner: Koji Ishii <ko...@chromium.org>
    Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
    Gerrit-Reviewer: Koji Ishii <ko...@chromium.org>
    Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
    Gerrit-CC: David Bokan <bo...@chromium.org>
    Gerrit-Attention: Ian Kilpatrick <ikilp...@chromium.org>
    Gerrit-Comment-Date: Sun, 08 Feb 2026 09:47:34 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Koji Ishii (Gerrit)

    unread,
    6:53β€―AMΒ (7 hours ago)Β 6:53β€―AM
    to AI Code Reviewer, Ian Kilpatrick, Chromium LUCI CQ, David Bokan, chromium...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org
    Attention needed from Ian Kilpatrick

    Koji Ishii added 1 comment

    File third_party/blink/renderer/core/dom/document_resize_options.h
    Line 14, Patchset 3: bool suppress_events = false;
    AI Code Reviewer . resolved

    nit: Blink Style Guide: Precede boolean values with words like β€œis” and β€œdid”. Consider naming this 'should_suppress_events'.

    To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
    **Done** | **OK But Won't Fix**: reason | **Later**: b/<bug_id> | **Invalid:** reason


    _This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent)._
    _AI reviews can sometimes be inaccurate; We appreciate your πŸ™ feedback πŸ™ to help us improve._
    _[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_

    Koji Ishii

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Ian Kilpatrick
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Id23a4118056c367304b29d395be747d4a72de13c
      Gerrit-Change-Number: 7554051
      Gerrit-PatchSet: 4
      Gerrit-Owner: Koji Ishii <ko...@chromium.org>
      Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
      Gerrit-Reviewer: Koji Ishii <ko...@chromium.org>
      Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
      Gerrit-CC: David Bokan <bo...@chromium.org>
      Gerrit-Attention: Ian Kilpatrick <ikilp...@chromium.org>
      Gerrit-Comment-Date: Sun, 08 Feb 2026 11:52:30 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages