[Grid] Oilpanify GridLayoutTree and GridLayoutSubtree [chromium/src : main]
0 views
Skip to first unread message
chromeperf@appspot.gserviceaccount.com (Gerrit)
Nov 14, 2025, 12:01:51 PM11/14/25
to Kurt Catti-Schmidt, Chromium LUCI CQ, chromium...@chromium.org, Javier Fernandez, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Attention needed from Kurt Catti-Schmidt
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job mac-m1_mini_2020-perf/blink_perf.layout complete.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/14255544310000
Related details
Attention is currently required from:
- Kurt Catti-Schmidt
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
Nov 17, 2025, 3:55:45 PM11/17/25
to Kurt Catti-Schmidt, Chromium LUCI CQ, chromium...@chromium.org, Javier Fernandez, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Attention needed from Kurt Catti-Schmidt
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job mac-m1_mini_2020-perf/blink_perf.layout complete.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/16aa2ebfd10000
Related details
Attention is currently required from:
- Kurt Catti-Schmidt
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
Nov 18, 2025, 3:47:10 AM11/18/25
to Kurt Catti-Schmidt, Chromium LUCI CQ, chromium...@chromium.org, Javier Fernandez, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Attention needed from Kurt Catti-Schmidt
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job mac-m1_mini_2020-perf/blink_perf.layout complete.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/1299b59fd10000
Related details
Attention is currently required from:
- Kurt Catti-Schmidt
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
Dec 11, 2025, 2:38:27 PM12/11/25
to Kurt Catti-Schmidt, Chromium LUCI CQ, chromium...@chromium.org, Javier Fernandez, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Attention needed from Kurt Catti-Schmidt
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job mac-m1_mini_2020-perf/blink_perf.layout complete.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/1355c8bf310000
Related details
Attention is currently required from:
- Kurt Catti-Schmidt
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
Dec 11, 2025, 8:35:53 PM12/11/25
to Kurt Catti-Schmidt, Chromium LUCI CQ, chromium...@chromium.org, Javier Fernandez, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Attention needed from Kurt Catti-Schmidt
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job mac-m1_mini_2020-perf/blink_perf.layout complete.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/1199da6b310000
Related details
Attention is currently required from:
- Kurt Catti-Schmidt
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
Dec 14, 2025, 9:18:57 PM12/14/25
to Kurt Catti-Schmidt, Chromium LUCI CQ, chromium...@chromium.org, Javier Fernandez, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Attention needed from Kurt Catti-Schmidt
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job mac-m1_mini_2020-perf/blink_perf.layout complete.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/12b7ce27310000
Related details
Attention is currently required from:
- Kurt Catti-Schmidt
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
Dec 16, 2025, 2:11:36 PM12/16/25
to Kurt Catti-Schmidt, Chromium LUCI CQ, chromium...@chromium.org, Javier Fernandez, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Attention needed from Kurt Catti-Schmidt
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job mac-m1_mini_2020-perf/blink_perf.layout complete.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/17d744ecb10000
Related details
Attention is currently required from:
- Kurt Catti-Schmidt
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
Mar 6, 2026, 10:36:53 PMMar 6
to Kurt Catti-Schmidt, Chromium LUCI CQ, chromium...@chromium.org, Javier Fernandez, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Attention needed from Kurt Catti-Schmidt
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job mac-m1_mini_2020-perf/blink_perf.layout complete.
- ArabicLineLayout: base median = 642.8453388405031 -> patched median = 645.445740265872
- SimpleTextPathLineLayout: base median = 2792.732402791028 -> patched median = 2799.983450944206
- abspos: base median = 153.2199999988079 -> patched median = 153.50000000149012
- anchor-scope: base median = 16.669999999925494 -> patched median = 16.67000000029802
- chapter-reflow: base median = 518.1856302940587 -> patched median = 519.4945396862469
- chapter-reflow-thrice: base median = 101.17655390282403 -> patched median = 101.31821108401869
- chapter-reflow-twice: base median = 112.54652358708127 -> patched median = 112.58807598618077
- css-contain-change-text: base median = 45.78000000007451 -> patched median = 45.96000000014901
- css-contain-change-text-different-subtree-root: base median = 45.440000000596044 -> patched median = 45.58000000119209
- culled-inline-bounding-rects: base median = 14.659999999869616 -> patched median = 14.739999999850989
- editing_append: base median = 609.5554024477921 -> patched median = 611.0310648809187
- editing_append_single_line: base median = 3725.4571186041485 -> patched median = 3732.801090702848
- editing_delete: base median = 600.1663176125141 -> patched median = 601.2932222868855
- editing_insert: base median = 597.2532421694448 -> patched median = 598.1611675294317
- editing_prepend: base median = 599.2672147623748 -> patched median = 600.5122178329881
- fit-content-change-available-size-blocks: base median = 48275.27230908138 -> patched median = 48501.09999560727
- flexbox-deeply-nested-with-ortho-flow: base median = 7628.737074906481 -> patched median = 7643.724314348987
- flexbox-hittest: base median = 500210.2044180548 -> patched median = 503753.03361581924
- floats_10_1000: base median = 61.05999999977648 -> patched median = 61.24000000059605
- gap-decorations-multicol-lots-of-columns: base median = 298.0609089402808 -> patched median = 302.1963748870136
- hittest-nested-inline-blocks-listbased: base median = 167265.7720871299 -> patched median = 168119.04740191804
- large-grid: base median = 11.224942359828857 -> patched median = 11.28626482934051
- layer-overhead: base median = 51323.91524203124 -> patched median = 51512.187624715065
- line-layout: base median = 788.192855557972 -> patched median = 789.4756624640276
- long-line-nowrap: base median = 157.85999999977648 -> patched median = 157.93999999985098
- multicol_balance-list-items-with-tall-marker: base median = 343.55245750321484 -> patched median = 345.2979453395792
- multicol_lots-of-small-nested-unbreakable-blocks-autofill: base median = 678.3731359479367 -> patched median = 682.3073675070277
- multicol_lots-of-small-unbreakable-blocks-autofill: base median = 580.996194534352 -> patched median = 582.9054144323867
- multicol_tall-content-short-columns: base median = 88.00904026262585 -> patched median = 89.0248096827513
- multicol_tall-content-short-columns-realistic: base median = 387.04943833360795 -> patched median = 389.8609281390876
- nested-percent-height-tables: base median = 3407.7933133359747 -> patched median = 3432.7910256504065
- subtree-detaching: base median = 52.62000000327826 -> patched median = 53.21999999973923
- text-wrap-balance: base median = 438.5639270788065 -> patched median = 440.89606411008606
- vertical-japanese-kokoro-insert: base median = 104.95999999940395 -> patched median = 105.47999999821187
- word-break-break-word: base median = 12.600000000093132 -> patched median = 12.639999999850989
- word-wrap-break-word: base median = 12.619999999180436 -> patched median = 12.620000001788139
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/15e45698090000
Related details
Attention is currently required from:
- Kurt Catti-Schmidt
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
Mar 7, 2026, 1:38:40 PMMar 7
to Kurt Catti-Schmidt, Chromium LUCI CQ, chromium...@chromium.org, Javier Fernandez, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Attention needed from Kurt Catti-Schmidt
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job mac-m1_mini_2020-perf/blink_perf.layout complete.
- ArabicLineLayout: base median = 642.2298053927881 -> patched median = 646.2195053989636
- SimpleTextPathLineLayout: base median = 2795.165797266962 -> patched median = 2801.989992290431
- add-remove-inline-floats: base median = 206.04907879022878 -> patched median = 208.64639371981383
- animate-abspos-deep: base median = 30.919999999552964 -> patched median = 30.96000000052154
- attach-inlines: base median = 383.0114507026041 -> patched median = 387.46239609410407
- attach-inlines-2: base median = 20343.309348873252 -> patched median = 20400.606061775296
- auto-grid-lots-of-data: base median = 724.3006624757049 -> patched median = 724.7223355651554
- chapter-reflow: base median = 517.8470402165988 -> patched median = 520.3500572419445
- chapter-reflow-once: base median = 126.77691973280437 -> patched median = 126.91925908320454
- chapter-reflow-thrice: base median = 101.18955473752845 -> patched median = 101.35854773179915
- chapter-reflow-twice: base median = 112.45560293986378 -> patched median = 112.70125972987285
- css-contain-change-text: base median = 44.55 -> patched median = 44.69999999925494
- css-contain-change-text-without-subtree-root: base median = 45.83999999985099 -> patched median = 46.65999999996275
- flexbox-column-nowrap: base median = 8316.370410246469 -> patched median = 8390.488749306904
- flexbox-column-wrap: base median = 8245.102308188398 -> patched median = 8314.945379301624
- flexbox-hittest: base median = 498216.76109469356 -> patched median = 500565.29209956183
- flexbox-row-nowrap: base median = 2890.661182065828 -> patched median = 2916.326909264001
- flexbox-row-stretch-height-indefinite: base median = 4490.21457759694 -> patched median = 4556.283718399798
- flexbox-row-wrap: base median = 2880.660493496982 -> patched median = 2903.8924615571896
- gap-decorations-multicol-lots-of-columns: base median = 298.76498278215763 -> patched median = 301.14477988067017
- hindi-line-layout: base median = 1769.631493622217 -> patched median = 1780.548049101704
- hittest-nested-inline-blocks-listbased: base median = 167839.27476876916 -> patched median = 168053.53741160582
- large-grid: base median = 11.195460208054822 -> patched median = 11.342627041432806
- line-layout: base median = 788.6396233596738 -> patched median = 791.2202795656099
- line-layout-repeat-append-select: base median = 166.91295524125405 -> patched median = 167.25670721461267
- many-block-children-fixed-inline-size: base median = 2711.794402807117 -> patched median = 2732.133454250357
- many-block-children-rebuild-box-tree: base median = 668.4331629426563 -> patched median = 674.1343469258014
- multicol_balance-forced-breaks: base median = 967.4542344963039 -> patched median = 970.1708729533159
- multicol_balance-list-items-with-tall-marker: base median = 344.3758035077682 -> patched median = 345.73245305568844
- multicol_balance-tables-with-break-inside-avoidance: base median = 484.99105033276186 -> patched median = 486.70851504534295
- multicol_deeply-nested-tables-2: base median = 4218.874549035452 -> patched median = 4226.097587899876
- multicol_lots-of-small-nested-unbreakable-blocks-autofill: base median = 673.4446861460029 -> patched median = 680.477211591664
- multicol_lots-of-small-unbreakable-blocks-autofill: base median = 574.8629875191143 -> patched median = 580.8046612720925
- multicol_lots-of-small-unbreakable-blocks-balanced: base median = 170.629908632592 -> patched median = 171.00089847331782
- multicol_lots-of-text-autofill: base median = 138.69109636118534 -> patched median = 139.01183049862422
- multicol_lots-of-text-balanced: base median = 130.43088242407174 -> patched median = 130.71561984767783
- multicol_lots-of-text-balanced-orphans-widows: base median = 115.83642309390515 -> patched median = 116.13672176608092
- multicol_nested-forced-breaks: base median = 3955.595768183769 -> patched median = 3962.1114094309432
- nested-blocks-with-percent-height-and-max-height: base median = 16619.82763876579 -> patched median = 16728.35494137174
- nested-grid: base median = 3218.99344574479 -> patched median = 3226.134971446979
- nested-tables-with-overflow-auto: base median = 2323.13427501857 -> patched median = 2330.0793644332266
- text-wrap-balance: base median = 440.3144318273652 -> patched median = 443.5346731268256
- word-break-break-word: base median = 12.619999998807907 -> patched median = 12.620000000298024
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/14755214090000
Related details
Attention is currently required from:
- Kurt Catti-Schmidt
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ian Kilpatrick (Gerrit)
Mar 9, 2026, 11:59:37 AMMar 9
to Kurt Catti-Schmidt, chrom...@appspot.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Javier Fernandez, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Attention needed from Kurt Catti-Schmidt
Ian Kilpatrick voted and added 6 comments![]( "Open in Gerrit")
Votes added by Ian Kilpatrick
| Code-Review | +1 |
6 comments
File third_party/blink/renderer/core/layout/constraint_space.h
Line 1551, Patchset 25 (Latest):
Member<const SubgridData> subgrid_data_;Ian Kilpatrick . unresolved
```suggestion
Member<const GridLayoutSubtree> grid_layout_subtree_;
```
Line 1550, Patchset 25 (Latest):
};Ian Kilpatrick . unresolved
we could arguably remove this struct now, and just have:
File third_party/blink/renderer/core/layout/constraint_space_builder.h
Line 613, Patchset 21:
void SetGridLayoutSubtree(GridLayoutSubtree* grid_layout_subtree) {Ian Kilpatrick . unresolved
Can this be const ?
File third_party/blink/renderer/core/layout/grid/grid_layout_algorithm.cc
Line 1810, Patchset 21:
GridLayoutSubtree* opt_layout_subtree,Ian Kilpatrick . unresolved
can this be const?
Line 1860, Patchset 21:
GridLayoutSubtree* opt_layout_subtree,Ian Kilpatrick . unresolved
Can this be const ?
File third_party/blink/renderer/core/layout/grid/grid_sizing_tree.h
Line 114, Patchset 21:
GridLayoutTree* FinalizeTree() const;Ian Kilpatrick . unresolved
Can this return a const ?
Related details
Attention is currently required from:
- Kurt Catti-Schmidt
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
Mar 9, 2026, 3:07:42 PMMar 9
to Kurt Catti-Schmidt, Ian Kilpatrick, Chromium LUCI CQ, chromium...@chromium.org, Javier Fernandez, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Attention needed from Kurt Catti-Schmidt
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job mac-m1_mini_2020-perf/blink_perf.layout complete.
- SimpleTextPathLineLayout: base median = 2797.204592859721 -> patched median = 2804.044495134726
- add-remove-inline-floats: base median = 206.9029428875745 -> patched median = 207.19843121029254
- animate-abspos-deep: base median = 30.63999999994412 -> patched median = 30.79999999997672
- attach-inlines: base median = 383.48661494258727 -> patched median = 385.4663331739433
- auto-grid-lots-of-data: base median = 722.4968972943198 -> patched median = 724.6191339847928
- auto-grid-lots-of-spanning-data: base median = 675.869574980087 -> patched median = 677.8163825500174
- chapter-reflow: base median = 517.1221723583908 -> patched median = 518.548126946471
- chapter-reflow-once-random: base median = 124.35804236421667 -> patched median = 124.45251987529757
- css-contain-change-text: base median = 44.62999999999302 -> patched median = 44.759999999962744
- css-contain-change-text-without-subtree-root: base median = 46.000000000023284 -> patched median = 46.67999999991152
- fit-content-change-available-size-text: base median = 146.55637460389966 -> patched median = 146.73172004523892
- flexbox-row-stretch-height-indefinite: base median = 4454.345297415564 -> patched median = 4486.209248469881
- flexbox-with-stretch-layout: base median = 67.1075760502453 -> patched median = 67.44529429490495
- flexbox_with_list_item: base median = 1274.6986367958052 -> patched median = 1285.7311385072633
- floats_10_1000: base median = 60.76000000000931 -> patched median = 60.85999999999767
- floats_2_100: base median = 53.009999999962744 -> patched median = 53.140000000083816
- large-grid: base median = 11.201369058582252 -> patched median = 11.342549818726443
- layers_overlap_2d: base median = 23.939999999897555 -> patched median = 23.979999999841674
- line-layout: base median = 786.2135274743607 -> patched median = 789.074291946756
- many-block-children-fixed-inline-size: base median = 2701.8607213109162 -> patched median = 2722.3463513973643
- multicol_balance-forced-breaks: base median = 966.8727223338049 -> patched median = 970.0317208876052
- multicol_balance-list-items-with-tall-marker: base median = 342.6425799538732 -> patched median = 344.0795383729306
- multicol_balance-tables-with-break-inside-avoidance: base median = 481.08807607645076 -> patched median = 481.9300494005802
- multicol_deeply-nested-tables: base median = 28592.942037393434 -> patched median = 28766.4406210919
- multicol_large-inline-formatting-context: base median = 6.674825273032878 -> patched median = 6.680953561280932
- multicol_lots-of-small-nested-unbreakable-blocks-autofill: base median = 671.453257124394 -> patched median = 678.6831465528128
- multicol_lots-of-small-unbreakable-blocks-autofill: base median = 572.828574601868 -> patched median = 580.4674547318264
- multicol_lots-of-small-unbreakable-blocks-balanced: base median = 167.3211397589198 -> patched median = 168.69330763293007
- multicol_lots-of-text-balanced: base median = 130.28992387792448 -> patched median = 130.3458474831698
- multicol_tall-content-short-columns-realistic: base median = 385.72811120338554 -> patched median = 386.14041295027187
- subtree-layout-scrollable-area: base median = 23.980000000074504 -> patched median = 24.199999999953434
- text-wrap-balance: base median = 438.83847490349194 -> patched median = 440.25147602857874
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/12d25772090000
Related details
Attention is currently required from:
- Kurt Catti-Schmidt
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kurt Catti-Schmidt (Gerrit)
Mar 9, 2026, 4:10:04 PMMar 9
to Ian Kilpatrick, chrom...@appspot.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Javier Fernandez, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Attention needed from Ian Kilpatrick
Kurt Catti-Schmidt voted and added 6 comments![]( "Open in Gerrit")
Votes added by Kurt Catti-Schmidt
| Commit-Queue | +2 |
6 comments
File third_party/blink/renderer/core/layout/constraint_space.h
```suggestion
Member<const GridLayoutSubtree> grid_layout_subtree_;
```
Kurt Catti-Schmidt
Done
we could arguably remove this struct now, and just have:
Kurt Catti-Schmidt
You're right, this was just a wrapper and wasn't adding anything.
File third_party/blink/renderer/core/layout/constraint_space_builder.h
Line 613, Patchset 21:
void SetGridLayoutSubtree(GridLayoutSubtree* grid_layout_subtree) {Ian Kilpatrick . resolved
Can this be const ?
Kurt Catti-Schmidt
Done
File third_party/blink/renderer/core/layout/grid/grid_layout_algorithm.cc
Line 1810, Patchset 21:
GridLayoutSubtree* opt_layout_subtree,Ian Kilpatrick . unresolved
can this be const?
Kurt Catti-Schmidt
The diff for this comment isn't working for me - it is highlighting something already const:
`const GridLayoutSubtree* layout_subtree = nullptr;`
Can you paste the suggestion in this comment? If it's anything I missed I can do it in a follow up.
Line 1860, Patchset 21:
GridLayoutSubtree* opt_layout_subtree,Ian Kilpatrick . resolved
Can this be const ?
Kurt Catti-Schmidt
Yeah, and also const'd `CreateConstraintSpace`
File third_party/blink/renderer/core/layout/grid/grid_sizing_tree.h
Line 114, Patchset 21:
GridLayoutTree* FinalizeTree() const;Ian Kilpatrick . resolved
Can this return a const ?
Attention is currently required from:
- Ian Kilpatrick
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kurt Catti-Schmidt (Gerrit)
Mar 9, 2026, 4:12:06 PMMar 9
to Ian Kilpatrick, chrom...@appspot.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Javier Fernandez, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Attention needed from Ian Kilpatrick
Kurt Catti-Schmidt added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/core/layout/grid/grid_layout_algorithm.cc
Line 1810, Patchset 21:
GridLayoutSubtree* opt_layout_subtree,Ian Kilpatrick . resolved
Kurt Catti-Schmidtcan this be const?
The diff for this comment isn't working for me - it is highlighting something already const:
`const GridLayoutSubtree* layout_subtree = nullptr;`
Can you paste the suggestion in this comment? If it's anything I missed I can do it in a follow up.
Kurt Catti-Schmidt
Resolving this to handle the "No Unresolved Comments" check.
Related details
Attention is currently required from:
- Ian Kilpatrick
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kurt Catti-Schmidt (Gerrit)
Mar 9, 2026, 4:13:18 PMMar 9
to Ian Kilpatrick, chrom...@appspot.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Javier Fernandez, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Attention needed from Ian Kilpatrick
Kurt Catti-Schmidt voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Chromium LUCI CQ (Gerrit)
Mar 9, 2026, 4:29:40 PMMar 9
to Kurt Catti-Schmidt, Ian Kilpatrick, chrom...@appspot.gserviceaccount.com, chromium...@chromium.org, Javier Fernandez, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
25 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: third_party/blink/renderer/core/layout/grid/grid_sizing_tree.h
Insertions: 1, Deletions: 1.
@@ -111,7 +111,7 @@
// Creates a copy of the current grid geometry for the entire tree in a new
// `GridLayoutTree` instance, which doesn't hold the grid items.
- GridLayoutTree* FinalizeTree() const;
+ const GridLayoutTree* FinalizeTree() const;
SubgriddedItemData LookupSubgriddedItemData(
const GridItemData& grid_item) const;
```
```
The name of the file: third_party/blink/renderer/core/layout/constraint_space_builder.h
Insertions: 1, Deletions: 1.
@@ -609,7 +609,7 @@
EnsureRareData()->SetTargetStretchBlockSizes(target_stretch_block_sizes);
}
- void SetGridLayoutSubtree(GridLayoutSubtree* grid_layout_subtree) {
+ void SetGridLayoutSubtree(const GridLayoutSubtree* grid_layout_subtree) {
#if DCHECK_IS_ON()
DCHECK(!is_grid_layout_subtree_set_);
is_grid_layout_subtree_set_ = true;
```
```
The name of the file: third_party/blink/renderer/core/layout/grid/grid_layout_algorithm.h
Insertions: 2, Deletions: 2.
@@ -65,7 +65,7 @@
ConstraintSpace CreateConstraintSpaceForLayout(
const GridItemData& grid_item,
const GridLayoutData& layout_data,
- GridLayoutSubtree* opt_layout_subtree = nullptr,
+ const GridLayoutSubtree* opt_layout_subtree = nullptr,
LogicalRect* containing_grid_area = nullptr,
LayoutUnit unavailable_block_size = LayoutUnit(),
bool min_block_size_should_encompass_intrinsic_size = false,
@@ -162,7 +162,7 @@
const GridItemData& grid_item,
const LogicalSize& containing_grid_area_size,
const LogicalSize& fixed_available_size,
- GridLayoutSubtree* opt_layout_subtree = nullptr,
+ const GridLayoutSubtree* opt_layout_subtree = nullptr,
bool min_block_size_should_encompass_intrinsic_size = false,
std::optional<LayoutUnit> opt_child_block_offset = std::nullopt) const;
```
```
The name of the file: third_party/blink/renderer/core/layout/grid/grid_layout_algorithm.cc
Insertions: 2, Deletions: 2.
@@ -1507,7 +1507,7 @@
const GridItemData& grid_item,
const LogicalSize& containing_grid_area_size,
const LogicalSize& fixed_available_size,
- GridLayoutSubtree* opt_layout_subtree,
+ const GridLayoutSubtree* opt_layout_subtree,
bool min_block_size_should_encompass_intrinsic_size,
std::optional<LayoutUnit> opt_child_block_offset) const {
const auto& container_constraint_space = GetConstraintSpace();
@@ -1557,7 +1557,7 @@
ConstraintSpace GridLayoutAlgorithm::CreateConstraintSpaceForLayout(
const GridItemData& grid_item,
const GridLayoutData& layout_data,
- GridLayoutSubtree* opt_layout_subtree,
+ const GridLayoutSubtree* opt_layout_subtree,
LogicalRect* containing_grid_area,
LayoutUnit unavailable_block_size,
bool min_block_size_should_encompass_intrinsic_size,
```
```
The name of the file: third_party/blink/renderer/core/layout/grid/grid_sizing_tree.cc
Insertions: 1, Deletions: 1.
@@ -64,7 +64,7 @@
tree_node.writing_mode = grid_node.Style().GetWritingMode();
}
-GridLayoutTree* GridSizingTree::FinalizeTree() const {
+const GridLayoutTree* GridSizingTree::FinalizeTree() const {
const auto tree_size = tree_data_.size();
HeapVector<Member<GridLayoutTree::GridTreeNode>, 16> layout_tree_data;
```
```
The name of the file: third_party/blink/renderer/core/layout/constraint_space.h
Insertions: 7, Deletions: 19.
@@ -935,7 +935,7 @@
is_adjacent_to_paper_edge_block_end(
other.is_adjacent_to_paper_edge_block_end),
line_clamp_ancestor_chain_(other.line_clamp_ancestor_chain_),
- subgrid_data_(other.subgrid_data_) {
+ grid_layout_subtree_(other.grid_layout_subtree_) {
switch (GetDataUnionType()) {
case DataUnionType::kNone:
break;
@@ -991,7 +991,7 @@
void Trace(Visitor* visitor) const {
visitor->Trace(line_clamp_ancestor_chain_);
- visitor->Trace(subgrid_data_);
+ visitor->Trace(grid_layout_subtree_);
}
bool MaySkipLayout(const RareData& other) const {
@@ -1045,7 +1045,7 @@
ignore_margins_for_stretch != other.ignore_margins_for_stretch ||
!base::ValuesEquivalent(line_clamp_ancestor_chain_,
other.line_clamp_ancestor_chain_) ||
- !base::ValuesEquivalent(subgrid_data_, other.subgrid_data_)) {
+ !base::ValuesEquivalent(grid_layout_subtree_, other.grid_layout_subtree_)) {
return false;
}
@@ -1094,7 +1094,7 @@
is_adjacent_to_paper_edge_block_start ||
is_adjacent_to_paper_edge_block_end ||
!ignore_margins_for_stretch.IsEmpty() || line_clamp_ancestor_chain_ ||
- subgrid_data_) {
+ grid_layout_subtree_) {
return false;
}
@@ -1307,11 +1307,11 @@
}
const GridLayoutSubtree* GetGridLayoutSubtree() const {
- return subgrid_data_ ? subgrid_data_->layout_subtree.Get() : nullptr;
+ return grid_layout_subtree_ ? grid_layout_subtree_.Get() : nullptr;
}
void SetGridLayoutSubtree(const GridLayoutSubtree* grid_layout_subtree) {
- subgrid_data_ = MakeGarbageCollected<SubgridData>(grid_layout_subtree);
+ grid_layout_subtree_ = grid_layout_subtree;
}
DataUnionType GetDataUnionType() const {
@@ -1536,19 +1536,7 @@
};
Member<const LineClampAncestorChain> line_clamp_ancestor_chain_;
-
- struct SubgridData : public GarbageCollected<SubgridData> {
- explicit SubgridData(const GridLayoutSubtree* layout_subtree)
- : layout_subtree(layout_subtree) {}
-
- void Trace(Visitor* visitor) const { visitor->Trace(layout_subtree); }
-
- bool operator==(const SubgridData& other) const {
- return *layout_subtree == *other.layout_subtree;
- }
- Member<const GridLayoutSubtree> layout_subtree;
- };
- Member<const SubgridData> subgrid_data_;
+ Member<const GridLayoutSubtree> grid_layout_subtree_;
};
// This struct simply allows us easily copy, compare, and initialize all the
```
Change information
Commit message:
[Grid] Oilpanify GridLayoutTree and GridLayoutSubtree
Moving these from the stack to the heap causes 12-14% performance
regressions in nested grid performance tests. These regressions will be
more than made up for in subsequent change that this change enables,
which move GridTrackCollection and GridLayoutData to Oilpan.
No behavioral changes are expected.
Bug: 460491953
Change-Id: I47cd1693fbc7c430c98d09674201927cc499dc45
Reviewed-by: Ian Kilpatrick <ikilp...@chromium.org>
Commit-Queue: Kurt Catti-Schmidt <ksc...@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1596555}
Files:
- M third_party/blink/renderer/core/layout/constraint_space.h
- M third_party/blink/renderer/core/layout/constraint_space_builder.h
- M third_party/blink/renderer/core/layout/grid/grid_break_token_data.h
- M third_party/blink/renderer/core/layout/grid/grid_data.h
- M third_party/blink/renderer/core/layout/grid/grid_layout_algorithm.cc
- M third_party/blink/renderer/core/layout/grid/grid_layout_algorithm.h
- M third_party/blink/renderer/core/layout/grid/grid_sizing_tree.cc
- M third_party/blink/renderer/core/layout/grid/grid_sizing_tree.h
Change size: M
Delta: 8 files changed, 90 insertions(+), 100 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Ian Kilpatrick
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages