Implement NavigationPrecommitController.addHandler [chromium/src : main]

0 views
Skip to first unread message

Nate Chapin (Gerrit)

unread,
Dec 5, 2025, 6:45:24 PM (2 days ago) Dec 5
to Noam Rosenthal, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, android-web...@chromium.org, ashleynewson+w...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Noam Rosenthal

Nate Chapin voted and added 1 comment

Votes added by Nate Chapin

Code-Review+1

1 comment

File third_party/blink/web_tests/external/wpt/navigation-api/precommit-handler/precommitHandler-addHandler.html
Line 18, Patchset 3 (Latest): }, 100)
Nate Chapin . unresolved

Does this 100ms delay actually run? If so, can we avoid that or at least shorten it?

Open in Gerrit

Related details

Attention is currently required from:
  • Noam Rosenthal
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I1740cbe73d126d114d935463ff10c5e29b531947
Gerrit-Change-Number: 7222931
Gerrit-PatchSet: 3
Gerrit-Owner: Noam Rosenthal <nrose...@google.com>
Gerrit-Reviewer: Nate Chapin <jap...@chromium.org>
Gerrit-Reviewer: Noam Rosenthal <nrose...@google.com>
Gerrit-Attention: Noam Rosenthal <nrose...@google.com>
Gerrit-Comment-Date: Fri, 05 Dec 2025 23:45:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Noam Rosenthal (Gerrit)

unread,
Dec 6, 2025, 6:34:10 AM (yesterday) Dec 6
to Nate Chapin, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, android-web...@chromium.org, ashleynewson+w...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org

Noam Rosenthal added 1 comment

File third_party/blink/web_tests/external/wpt/navigation-api/precommit-handler/precommitHandler-addHandler.html
Line 18, Patchset 3: }, 100)
Nate Chapin . resolved

Does this 100ms delay actually run? If so, can we avoid that or at least shorten it?

Noam Rosenthal
```suggestion
                    }, 20)
```
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I1740cbe73d126d114d935463ff10c5e29b531947
    Gerrit-Change-Number: 7222931
    Gerrit-PatchSet: 4
    Gerrit-Owner: Noam Rosenthal <nrose...@google.com>
    Gerrit-Reviewer: Nate Chapin <jap...@chromium.org>
    Gerrit-Reviewer: Noam Rosenthal <nrose...@google.com>
    Gerrit-Comment-Date: Sat, 06 Dec 2025 11:33:45 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Nate Chapin <jap...@chromium.org>
    satisfied_requirement
    open
    diffy

    Noam Rosenthal (Gerrit)

    unread,
    Dec 6, 2025, 6:34:11 AM (yesterday) Dec 6
    to Nate Chapin, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, android-web...@chromium.org, ashleynewson+w...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org

    Noam Rosenthal voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I1740cbe73d126d114d935463ff10c5e29b531947
    Gerrit-Change-Number: 7222931
    Gerrit-PatchSet: 4
    Gerrit-Owner: Noam Rosenthal <nrose...@google.com>
    Gerrit-Reviewer: Nate Chapin <jap...@chromium.org>
    Gerrit-Reviewer: Noam Rosenthal <nrose...@google.com>
    Gerrit-Comment-Date: Sat, 06 Dec 2025 11:33:50 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Dec 6, 2025, 7:27:18 AM (yesterday) Dec 6
    to Noam Rosenthal, Nate Chapin, AyeAye, chromium...@chromium.org, android-web...@chromium.org, ashleynewson+w...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org

    Chromium LUCI CQ submitted the change with unreviewed changes

    Unreviewed changes

    3 is the latest approved patch-set.
    The change was submitted with unreviewed changes in the following files:

    ```
    The name of the file: third_party/blink/web_tests/external/wpt/navigation-api/precommit-handler/precommitHandler-addHandler.html
    Insertions: 1, Deletions: 1.

    @@ -15,7 +15,7 @@
                         t.step_timeout(() => {
                           did_delay = true;
                           resolve();
    -                    }, 100)
    +                    }, 1)
                       )
                   )
                 ),
    ```

    Change information

    Commit message:
    Implement NavigationPrecommitController.addHandler

    This allows registering a post-commit navigation handler during the
    pre-commit phase, to allow a multi-step navigation process.
    Bug: 465487215
    Change-Id: I1740cbe73d126d114d935463ff10c5e29b531947
    Reviewed-by: Nate Chapin <jap...@chromium.org>
    Commit-Queue: Noam Rosenthal <nrose...@google.com>
    Cr-Commit-Position: refs/heads/main@{#1555106}
    Files:
    • M android_webview/test/data/web_tests/webexposed/global-interface-listing-expected.txt
    • M third_party/blink/renderer/core/navigation_api/navigate_event.cc
    • M third_party/blink/renderer/core/navigation_api/navigate_event.h
    • M third_party/blink/renderer/core/navigation_api/navigation_precommit_controller.h
    • M third_party/blink/renderer/core/navigation_api/navigation_precommit_controller.idl
    • M third_party/blink/renderer/platform/runtime_enabled_features.json5
    • A third_party/blink/web_tests/external/wpt/navigation-api/precommit-handler/precommitHandler-addHandler-throws.html
    • A third_party/blink/web_tests/external/wpt/navigation-api/precommit-handler/precommitHandler-addHandler.html
    • M third_party/blink/web_tests/webexposed/global-interface-listing-expected.txt
    Change size: M
    Delta: 9 files changed, 129 insertions(+), 0 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Nate Chapin
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I1740cbe73d126d114d935463ff10c5e29b531947
    Gerrit-Change-Number: 7222931
    Gerrit-PatchSet: 5
    Gerrit-Owner: Noam Rosenthal <nrose...@google.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Nate Chapin <jap...@chromium.org>
    Gerrit-Reviewer: Noam Rosenthal <nrose...@google.com>
    open
    diffy
    satisfied_requirement

    Blink W3C Test Autoroller (Gerrit)

    unread,
    Dec 6, 2025, 8:06:28 AM (yesterday) Dec 6
    to Chromium LUCI CQ, Noam Rosenthal, Nate Chapin, AyeAye, chromium...@chromium.org, android-web...@chromium.org, ashleynewson+w...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org

    Message from Blink W3C Test Autoroller

    The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/56549

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I1740cbe73d126d114d935463ff10c5e29b531947
    Gerrit-Change-Number: 7222931
    Gerrit-PatchSet: 5
    Gerrit-Owner: Noam Rosenthal <nrose...@google.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Nate Chapin <jap...@chromium.org>
    Gerrit-Reviewer: Noam Rosenthal <nrose...@google.com>
    Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
    Gerrit-Comment-Date: Sat, 06 Dec 2025 13:06:22 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: No
    satisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages