overscroll: fix backdrop scroll chaining [chromium/src : main]

1 view

Skip to first unread message

Robert Flack (Gerrit)

unread,

May 25, 2026, 5:28:54 PM (9 hours ago) May 25

to Vladimir Levin, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org, zol...@webkit.org

Attention needed from Vladimir Levin

Robert Flack added 2 comments

Commit Message

Line 11, Patchset 1 (Latest):- renames scorll_translation_for_fixed to

Robert Flack . unresolved

typo

File third_party/blink/renderer/core/paint/paint_property_tree_builder.cc

Line 809, Patchset 1 (Latest): overscroll_area_parent->GetLayoutObject()) {

Robert Flack . unresolved

Is there any reason to expect that the rest of the element would have fragments if the area parent did not have a layout object? The area parent pseudo is the layout parent of the element and the backdrop. Same for the rest of these conditions.

What happens when these conditions aren't true? I guess we chain scroll past the area parent?

Have you considered adding something like scroll_translation to ContainingBlockContext such that scroll_translation can track the translation for the current scroll node, then we could use that instead of looking up arbitrary nodes here?

Open in Gerrit

Related details

Attention is currently required from:

Vladimir Levin

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages