Make WPT Drag and Drop image/ tests use actions API [chromium/src : main]

0 views
Skip to first unread message

Gaston Rodriguez (Gerrit)

unread,
Jun 12, 2025, 5:24:29 PMJun 12
to Olga Gerchikov, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Olga Gerchikov

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Olga Gerchikov
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I52a2c8eeedf8b2df108409bae443efc8a5daffd7
Gerrit-Change-Number: 6637644
Gerrit-PatchSet: 6
Gerrit-Owner: Gaston Rodriguez <gas...@microsoft.com>
Gerrit-Reviewer: Gaston Rodriguez <gas...@microsoft.com>
Gerrit-Reviewer: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-Attention: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-Comment-Date: Thu, 12 Jun 2025 21:24:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Olga Gerchikov (Gerrit)

unread,
Jun 17, 2025, 6:51:20 PMJun 17
to Gaston Rodriguez, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Gaston Rodriguez

Olga Gerchikov added 1 comment

File third_party/blink/web_tests/external/wpt/html/editing/dnd/images/022.xhtml
Line 40, Patchset 7 (Latest): dropImage(event);
assert_equals('PASS', document.querySelector('p + p').firstChild.nodeValue);
Olga Gerchikov . unresolved

I am confused about the purpose of this verification. Can it fail if the test reaches this point? Same comment for other tests that have this pattern.

Open in Gerrit

Related details

Attention is currently required from:
  • Gaston Rodriguez
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I52a2c8eeedf8b2df108409bae443efc8a5daffd7
    Gerrit-Change-Number: 6637644
    Gerrit-PatchSet: 7
    Gerrit-Owner: Gaston Rodriguez <gas...@microsoft.com>
    Gerrit-Reviewer: Gaston Rodriguez <gas...@microsoft.com>
    Gerrit-Reviewer: Olga Gerchikov <gerc...@microsoft.com>
    Gerrit-Attention: Gaston Rodriguez <gas...@microsoft.com>
    Gerrit-Comment-Date: Tue, 17 Jun 2025 22:51:11 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages