[rust png] Remove GN-level Blink => libpng dependencies. [chromium/src : main]
0 views
Skip to first unread message
Łukasz Anforowicz (Gerrit)
Sep 22, 2025, 1:14:16 PM (2 days ago) Sep 22
to Chris Blume, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, cblume+im...@chromium.org, kinuko...@chromium.org, mbarowsky+watc...@chromium.org
Attention needed from Chris Blume
Łukasz Anforowicz voted and added 1 comment![]( "Open in Gerrit")
Votes added by Łukasz Anforowicz
| Auto-Submit | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Łukasz Anforowicz . resolved
@cblume, can you PTAL as one of `//third_party/libpng/OWNERS`?
Related details
Attention is currently required from:
- Chris Blume
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Łukasz Anforowicz (Gerrit)
Sep 23, 2025, 6:01:35 PM (7 hours ago) Sep 23
to Daniel Cheng, Chris Blume, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, cblume+im...@chromium.org, kinuko...@chromium.org, mbarowsky+watc...@chromium.org
Attention needed from Chris Blume and Daniel Cheng
Łukasz Anforowicz voted and added 1 comment![]( "Open in Gerrit")
Votes added by Łukasz Anforowicz
| Auto-Submit | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 3 (Latest):
Łukasz Anforowicz . resolved
@dcheng, I wonder if you could PTAL (as one of `third_party/blink/renderer/OWNERS` + as a member of Chrome Security team)?
I wonder if using your Owners-Override powers on this CL would be reasonable. This CL is quite mechanical - if the changes pass `gn gen`, `gn check`, and build fine, then restricted dependencies and restricted visibility are surely desirable.
In theory, I could temporarily become an owner of `//third_party/libpng` during its removal (AFAIK @cblume doesn't works on Chrome since 2021, although they usually have been quite responsive and helpful with CLs and bugs). But we just need to land around 4-5 CLs to tighten visibility there, and using Owners-Override or asking //third_party/OWNERS for a review seem like an enticing path of least resistance.
Related details
Attention is currently required from:
- Chris Blume
- Daniel Cheng
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel Cheng (Gerrit)
Sep 23, 2025, 8:08:17 PM (5 hours ago) Sep 23
to Łukasz Anforowicz, Daniel Cheng, Chris Blume, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, cblume+im...@chromium.org, kinuko...@chromium.org, mbarowsky+watc...@chromium.org
Attention needed from Chris Blume and Łukasz Anforowicz
Daniel Cheng voted and added 1 comment![]( "Open in Gerrit")
Votes added by Daniel Cheng
| Code-Review | +1 |
| Commit-Queue | +2 |
| Owners-Override | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Chris Blume
- Łukasz Anforowicz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Sep 23, 2025, 9:13:15 PM (4 hours ago) Sep 23
to Łukasz Anforowicz, Daniel Cheng, Chris Blume, chromium...@chromium.org, blink-...@chromium.org, cblume+im...@chromium.org, kinuko...@chromium.org, mbarowsky+watc...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[rust png] Remove GN-level Blink => libpng dependencies.
Code-level `libpng` dependencies under `third_party/blink` are already
gone at this point (thanks to CLs like https://crrev.com/c/6907475
and/or https://crrev.com/c/6931691). Therefore this CL removes
remaining, obsolete GN-level dependency edges + tightens `visibility`.
Bug: 443128323
Change-Id: I9200cdfb1abd6e79e00655ed7c97352c709a16f1
Auto-Submit: Łukasz Anforowicz <luk...@chromium.org>
Owners-Override: Daniel Cheng <dch...@chromium.org>
Commit-Queue: Daniel Cheng <dch...@chromium.org>
Reviewed-by: Daniel Cheng <dch...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1519716}
Files:
- M third_party/blink/renderer/core/BUILD.gn
- M third_party/blink/renderer/platform/BUILD.gn
- M third_party/blink/renderer/platform/image-decoders/BUILD.gn
- M third_party/libpng/visibility.gni
Change size: XS
Delta: 4 files changed, 0 insertions(+), 7 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Daniel Cheng
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages