Refactor PrefetchContainer::MakeResourceRequest() [chromium/src : main]

0 views

Skip to first unread message

Hiroki Nakagawa (Gerrit)

unread,

Dec 22, 2025, 9:33:42 PM (10 hours ago) Dec 22

to Hiroshige Hayashizaki, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, prerendering-reviews, blink-...@chromium.org, devtools...@chromium.org, devtools-re...@chromium.org, gavin...@chromium.org, tburkar...@chromium.org

Attention needed from Hiroshige Hayashizaki

Hiroki Nakagawa voted and added 2 comments

Votes added by Hiroki Nakagawa

Code-Review

2 comments

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Hiroki Nakagawa . resolved

LGTM, thanks!

File third_party/blink/web_tests/virtual/enable-prefetch-devtools-ua-override/http/tests/inspector-protocol/prefetch/prefetch-ua-override-expected.txt

Line 6, Patchset 4 (Latest):

Upgrade-Insecure-Requests: 1
Sec-Purpose: prefetch

Hiroki Nakagawa . resolved

Reviewer note (no action required): These lines are swapped compared to the original expectation:
https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/web_tests/http/tests/inspector-protocol/prefetch/prefetch-ua-override-expected.txt;l=6-7;drc=c6b307814bfebcdb21fe36202574cf2401f29228

Open in Gerrit

Related details

Attention is currently required from:

Hiroshige Hayashizaki

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages