preloading: Cancel prerendering if window.close is called [chromium/src : main]

[Huanpo Lin (Gerrit)]

Attention needed from Andrey Kosyakov and Rakina Zata Amni

Huanpo Lin added 3 comments

Commit Message

Line 7, Patchset 3:preloading: Cancel prerendering if window.closed is called

Domenic Denicola . resolved

closed -> close

Huanpo Lin

Done

Line 17, Patchset 3:Bug: 348232620

Domenic Denicola . resolved

It might be good to have a separate bug for this feature in particular, just so we can more accurately and publicly track all the different workstreams blocking this meta bug.

Huanpo Lin

Just created another issue 350870118.

File content/browser/renderer_host/render_frame_host_impl.cc

Line 6234, Patchset 3: // For prerendered pages, if window.close is called, it should be cancelled.

Rakina Zata Amni . unresolved

From `ClosePageSource`, it looks like this function can also be called because the browser/tab is shutting down. Do you want to differentiate or exclude those cases maybe?

Huanpo Lin

Thanks for pointing it out. I've just checked the logic from other callers, and it seems to be called by navigation throttle or other scenario from browser process. I move the logic to exclude browser initiated cases. PTAL.

Open in Gerrit

Related details

Attention is currently required from:

• Andrey Kosyakov
• Rakina Zata Amni

Submit Requirements:

• Code-Coverage
• Code-Review
• No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I9fb6ca8fd096588ebabd270e81790a51a96da6eb

Gerrit-Change-Number: 5671776

Gerrit-PatchSet: 7

Gerrit-Owner: Huanpo Lin <robe...@chromium.org>

Gerrit-Reviewer: Andrey Kosyakov <ca...@chromium.org>

Gerrit-Reviewer: Hiroki Nakagawa <nhi...@chromium.org>

Gerrit-Reviewer: Huanpo Lin <robe...@chromium.org>

Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: Domenic Denicola <dom...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: devtools...@chromium.org

Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>

Gerrit-Attention: Rakina Zata Amni <rak...@chromium.org>

Gerrit-Attention: Andrey Kosyakov <ca...@chromium.org>

Gerrit-Comment-Date: Wed, 03 Jul 2024 07:33:59 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Rakina Zata Amni <rak...@chromium.org>

Comment-In-Reply-To: Domenic Denicola <dom...@chromium.org>