[M151] Add network::cors::IsCorsSafelistedResponseHeaderName [chromium/src : refs/branch-heads/7922]
0 views
Skip to first unread message
Maksim Sisov (Gerrit)
Jul 16, 2026, 9:06:30 AM (11 days ago) Jul 16
to chrome-che...@chops-service-accounts.iam.gserviceaccount.com, Chromium LUCI CQ, Nate Chapin, android-bu...@system.gserviceaccount.com, network-ser...@chromium.org, loading...@chromium.org, kinuko...@chromium.org, gavinp...@chromium.org, blink-...@chromium.org
New activity on the change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kenichi Ishibashi (Gerrit)
Jul 16, 2026, 7:22:55 PM (10 days ago) Jul 16
to chrome-che...@chops-service-accounts.iam.gserviceaccount.com, Maksim Sisov, Daniel Cheng, Chromium LUCI CQ, Nate Chapin, android-bu...@system.gserviceaccount.com, network-ser...@chromium.org, loading...@chromium.org, kinuko...@chromium.org, gavinp...@chromium.org, blink-...@chromium.org
Attention needed from Daniel Cheng and Maksim Sisov
Kenichi Ishibashi voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Daniel Cheng
- Maksim Sisov
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
rubber-stamper@appspot.gserviceaccount.com (Gerrit)
Jul 17, 2026, 2:53:21 PM (10 days ago) Jul 17
to chrome-che...@chops-service-accounts.iam.gserviceaccount.com, Maksim Sisov, Kenichi Ishibashi, Daniel Cheng, Chromium LUCI CQ, Nate Chapin, android-bu...@system.gserviceaccount.com, network-ser...@chromium.org, loading...@chromium.org, kinuko...@chromium.org, gavinp...@chromium.org, blink-...@chromium.org
Attention needed from Maksim Sisov
Message from rubber-...@appspot.gserviceaccount.com![]( "Open in Gerrit")
The current revision changed the following files compared with the initial revision: third_party/blink/common/service_worker/service_worker_loader_helpers.cc, third_party/blink/renderer/platform/loader/cors/cors.cc, third_party/blink/tools/blinkpy/presubmit/audit_non_blink_usage.py. Learn more: go/rubber-stamper-user-guide.
Related details
Attention is currently required from:
- Maksim Sisov
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel Cheng (Gerrit)
Jul 17, 2026, 2:58:35 PM (10 days ago) Jul 17
to chrome-che...@chops-service-accounts.iam.gserviceaccount.com, Maksim Sisov, Daniel Cheng, Kenichi Ishibashi, Chromium LUCI CQ, Nate Chapin, android-bu...@system.gserviceaccount.com, network-ser...@chromium.org, loading...@chromium.org, kinuko...@chromium.org, gavinp...@chromium.org, blink-...@chromium.org
Attention needed from Maksim Sisov
Daniel Cheng voted and added 1 comment![]( "Open in Gerrit")
Votes added by Daniel Cheng
| Code-Review | +1 |
Related details
Attention is currently required from:
- Maksim Sisov
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Maksim Sisov (Gerrit)
Jul 17, 2026, 4:14:38 PM (10 days ago) Jul 17
to chrome-che...@chops-service-accounts.iam.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Daniel Cheng, Kenichi Ishibashi, Nate Chapin, android-bu...@system.gserviceaccount.com, chromium-a...@chromium.org, extension...@chromium.org, network-ser...@chromium.org, loading...@chromium.org, kinuko...@chromium.org, gavinp...@chromium.org, blink-...@chromium.org
Maksim Sisov voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Maksim Sisov (Gerrit)
1:45 AM (3 hours ago) 1:45 AM
to chrome-che...@chops-service-accounts.iam.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Daniel Cheng, Kenichi Ishibashi, Nate Chapin, android-bu...@system.gserviceaccount.com, chromium-a...@chromium.org, extension...@chromium.org, network-ser...@chromium.org, loading...@chromium.org, kinuko...@chromium.org, gavinp...@chromium.org, blink-...@chromium.org
Maksim Sisov (Gerrit)
3:04 AM (1 hour ago) 3:04 AM
to chrome-che...@chops-service-accounts.iam.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Daniel Cheng, Kenichi Ishibashi, Nate Chapin, android-bu...@system.gserviceaccount.com, chromium-a...@chromium.org, extension...@chromium.org, network-ser...@chromium.org, loading...@chromium.org, kinuko...@chromium.org, gavinp...@chromium.org, blink-...@chromium.org
Maksim Sisov voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
3:32 AM (1 hour ago) 3:32 AM
to chrome-che...@chops-service-accounts.iam.gserviceaccount.com, Maksim Sisov, chromium...@chromium.org, Daniel Cheng, Kenichi Ishibashi, Nate Chapin, android-bu...@system.gserviceaccount.com, chromium-a...@chromium.org, extension...@chromium.org, network-ser...@chromium.org, loading...@chromium.org, kinuko...@chromium.org, gavinp...@chromium.org, blink-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
4 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
[M151] Add network::cors::IsCorsSafelistedResponseHeaderName
Original change's description:
> Add network::cors::IsCorsSafelistedResponseHeaderName
>
> The CORS-safelisted response-header-name list is duplicated in two Blink
> copies: the renderer WTF predicate IsCorsSafelistedResponseHeader() and
> the blink-common IsCorsExposedResponseHeader() helper. There is no
> browser-process-callable primitive for it, which a later change needs.
>
> Add IsCorsSafelistedResponseHeaderName() next to the request-side
> safelist predicates in network::cors and fold both Blink copies onto it.
> The blink-common copy keeps its content-range media carve-out as an
> explicit branch. No behavior change: the renderer set was matched
> case-insensitively before and the new predicate lowercases the input.
>
> Bug: 533917984
> Change-Id: I41ba7c40c3a4474c21e98bd8be998f538e4f3513
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8084477
> Reviewed-by: Kenichi Ishibashi <ba...@chromium.org>
> Commit-Queue: Maksim Sisov <msi...@igalia.com>
> Reviewed-by: Daniel Cheng <dch...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1662521}
(cherry picked from commit 77d1561238e8a4d00c5c1068a6daf76dbca12a6f)
Bug: 535159737,533917984
Change-Id: I41ba7c40c3a4474c21e98bd8be998f538e4f3513
Reviewed-by: Kenichi Ishibashi <ba...@chromium.org>
Reviewed-by: Daniel Cheng <dch...@chromium.org>
Reviewed-by: Maksim Sisov <msi...@igalia.com>
Commit-Queue: Maksim Sisov <msi...@igalia.com>
Cr-Commit-Position: refs/branch-heads/7922@{#2054}
Cr-Branched-From: 059c884787b1bc15faa5afe5250f7d3a7e0ef64a-refs/heads/main@{#1654411}
Files:
- M services/network/public/cpp/cors/cors.cc
- M services/network/public/cpp/cors/cors.h
- M services/network/public/cpp/cors/cors_unittest.cc
- M third_party/blink/renderer/platform/loader/cors/cors.cc
Change size: M
Delta: 4 files changed, 49 insertions(+), 14 deletions(-)
Branch: refs/branch-heads/7922
Submit Requirements:
Code-Review: +1 by Kenichi Ishibashi, +1 by Maksim Sisov, +1 by Daniel Cheng
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages