geolocation: Remove unused geolocation mock [chromium/src : main]

0 views
Skip to first unread message

Alvin Ji (Gerrit)

unread,
Feb 6, 2026, 7:33:04 PM (2 days ago) Feb 6
to Matt Reynolds, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org
Attention needed from Matt Reynolds

Alvin Ji added 1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Alvin Ji . resolved

Hi Matt,
PTAL and thanks!
Alvin

Open in Gerrit

Related details

Attention is currently required from:
  • Matt Reynolds
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I3f177ca541238d278ddb68efbf8610d8e34cb719
Gerrit-Change-Number: 7552914
Gerrit-PatchSet: 2
Gerrit-Owner: Alvin Ji <alv...@chromium.org>
Gerrit-Reviewer: Alvin Ji <alv...@chromium.org>
Gerrit-Reviewer: Matt Reynolds <mattre...@chromium.org>
Gerrit-Attention: Matt Reynolds <mattre...@chromium.org>
Gerrit-Comment-Date: Sat, 07 Feb 2026 00:32:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Matt Reynolds (Gerrit)

unread,
Feb 6, 2026, 8:32:48 PM (2 days ago) Feb 6
to Alvin Ji, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org
Attention needed from Alvin Ji

Matt Reynolds voted and added 1 comment

Votes added by Matt Reynolds

Code-Review+1

1 comment

Patchset-level comments
Matt Reynolds . resolved

lgtm

Open in Gerrit

Related details

Attention is currently required from:
  • Alvin Ji
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I3f177ca541238d278ddb68efbf8610d8e34cb719
    Gerrit-Change-Number: 7552914
    Gerrit-PatchSet: 2
    Gerrit-Owner: Alvin Ji <alv...@chromium.org>
    Gerrit-Reviewer: Alvin Ji <alv...@chromium.org>
    Gerrit-Reviewer: Matt Reynolds <mattre...@chromium.org>
    Gerrit-Attention: Alvin Ji <alv...@chromium.org>
    Gerrit-Comment-Date: Sat, 07 Feb 2026 01:32:34 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Alvin Ji (Gerrit)

    unread,
    Feb 6, 2026, 11:43:01 PM (2 days ago) Feb 6
    to Matt Reynolds, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org

    Alvin Ji voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I3f177ca541238d278ddb68efbf8610d8e34cb719
    Gerrit-Change-Number: 7552914
    Gerrit-PatchSet: 2
    Gerrit-Owner: Alvin Ji <alv...@chromium.org>
    Gerrit-Reviewer: Alvin Ji <alv...@chromium.org>
    Gerrit-Reviewer: Matt Reynolds <mattre...@chromium.org>
    Gerrit-Comment-Date: Sat, 07 Feb 2026 04:42:50 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Feb 6, 2026, 11:46:49 PM (2 days ago) Feb 6
    to Alvin Ji, Matt Reynolds, chromium...@chromium.org, blink-...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    geolocation: Remove unused geolocation mock
    Change-Id: I3f177ca541238d278ddb68efbf8610d8e34cb719
    Reviewed-by: Matt Reynolds <mattre...@chromium.org>
    Commit-Queue: Alvin Ji <alv...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1581281}
    Files:
    • D third_party/blink/web_tests/http/tests/resources/geolocation-mock.js
    Change size: M
    Delta: 1 file changed, 0 insertions(+), 225 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Matt Reynolds
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I3f177ca541238d278ddb68efbf8610d8e34cb719
    Gerrit-Change-Number: 7552914
    Gerrit-PatchSet: 3
    Gerrit-Owner: Alvin Ji <alv...@chromium.org>
    Gerrit-Reviewer: Alvin Ji <alv...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Matt Reynolds <mattre...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages