Rename ViewTransitionSubframeRootEffect. [chromium/src : main]

0 views
Skip to first unread message

Steve Kobes (Gerrit)

unread,
10:15 AM (11 hours ago) 10:15 AM
to Philip Rogers, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org
Attention needed from Philip Rogers

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Philip Rogers
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I16b7796691538cebdea8d802801c96eb4e7c4003
Gerrit-Change-Number: 7032980
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Kobes <sko...@chromium.org>
Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
Gerrit-Reviewer: Steve Kobes <sko...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-Attention: Philip Rogers <p...@chromium.org>
Gerrit-Comment-Date: Wed, 15 Oct 2025 14:15:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Philip Rogers (Gerrit)

unread,
10:59 AM (10 hours ago) 10:59 AM
to Steve Kobes, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org
Attention needed from Steve Kobes

Philip Rogers voted and added 2 comments

Votes added by Philip Rogers

Code-Review+1

2 comments

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Philip Rogers . resolved

LGTM

File third_party/blink/renderer/core/paint/object_paint_properties.h
Line 282, Patchset 1 (Latest): // | Provides the root stacking context for a local subframe with an
Philip Rogers . unresolved

nit: can you update this too?

Open in Gerrit

Related details

Attention is currently required from:
  • Steve Kobes
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I16b7796691538cebdea8d802801c96eb4e7c4003
    Gerrit-Change-Number: 7032980
    Gerrit-PatchSet: 1
    Gerrit-Owner: Steve Kobes <sko...@chromium.org>
    Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
    Gerrit-Reviewer: Steve Kobes <sko...@chromium.org>
    Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
    Gerrit-CC: Stephen Chenney <sche...@chromium.org>
    Gerrit-Attention: Steve Kobes <sko...@chromium.org>
    Gerrit-Comment-Date: Wed, 15 Oct 2025 14:59:19 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Steve Kobes (Gerrit)

    unread,
    11:11 AM (10 hours ago) 11:11 AM
    to Philip Rogers, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org

    Steve Kobes voted and added 1 comment

    Votes added by Steve Kobes

    Commit-Queue+2

    1 comment

    File third_party/blink/renderer/core/paint/object_paint_properties.h
    Line 282, Patchset 1: // | Provides the root stacking context for a local subframe with an
    Philip Rogers . resolved

    nit: can you update this too?

    Steve Kobes

    Done

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I16b7796691538cebdea8d802801c96eb4e7c4003
      Gerrit-Change-Number: 7032980
      Gerrit-PatchSet: 2
      Gerrit-Owner: Steve Kobes <sko...@chromium.org>
      Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
      Gerrit-Reviewer: Steve Kobes <sko...@chromium.org>
      Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
      Gerrit-CC: Stephen Chenney <sche...@chromium.org>
      Gerrit-Comment-Date: Wed, 15 Oct 2025 15:11:33 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      Comment-In-Reply-To: Philip Rogers <p...@chromium.org>
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      12:39 PM (8 hours ago) 12:39 PM
      to Steve Kobes, Philip Rogers, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org

      Chromium LUCI CQ submitted the change with unreviewed changes

      Unreviewed changes

      1 is the latest approved patch-set.
      The change was submitted with unreviewed changes in the following files:

      ```
      The name of the file: third_party/blink/renderer/core/paint/object_paint_properties.h
      Insertions: 3, Deletions: 3.

      The diff is too large to show. Please review the diff.
      ```

      Change information

      Commit message:
      Rename ViewTransitionSubframeRootEffect.

      This effect now handles other scopes besides subframes.
      Bug: 405117383
      Change-Id: I16b7796691538cebdea8d802801c96eb4e7c4003
      Commit-Queue: Steve Kobes <sko...@chromium.org>
      Reviewed-by: Philip Rogers <p...@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#1530274}
      Files:
      • M third_party/blink/renderer/core/paint/object_paint_properties.h
      • M third_party/blink/renderer/core/paint/paint_property_tree_builder.cc
      • M third_party/blink/renderer/core/paint/paint_property_tree_printer.cc
      • M third_party/blink/renderer/platform/graphics/compositor_element_id.h
      Change size: S
      Delta: 4 files changed, 15 insertions(+), 17 deletions(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Philip Rogers
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I16b7796691538cebdea8d802801c96eb4e7c4003
      Gerrit-Change-Number: 7032980
      Gerrit-PatchSet: 3
      Gerrit-Owner: Steve Kobes <sko...@chromium.org>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
      Gerrit-Reviewer: Steve Kobes <sko...@chromium.org>
      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages