Take text-emphasis heights into account for ruby annotation placement [chromium/src : main]

0 views
Skip to first unread message

Kent Tamura (Gerrit)

unread,
Jul 2, 2026, 9:51:53 PM (4 days ago) Jul 2
to Kent Tamura, Chromium LUCI CQ, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, zol...@webkit.org, blink-revi...@chromium.org, blink-...@chromium.org

Kent Tamura voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic8f51b7dbc11a57340826d3e38f377d0a454e6cf
Gerrit-Change-Number: 8029622
Gerrit-PatchSet: 5
Gerrit-Owner: Kent Tamura <tk...@chromium.org>
Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
Gerrit-Comment-Date: Fri, 03 Jul 2026 01:51:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Kent Tamura (Gerrit)

unread,
Jul 3, 2026, 1:30:09 AM (4 days ago) Jul 3
to Kent Tamura, Koji Ishii, Chromium LUCI CQ, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, zol...@webkit.org, blink-revi...@chromium.org, blink-...@chromium.org
Attention needed from Koji Ishii

Kent Tamura added 1 comment

Patchset-level comments
File-level comment, Patchset 6 (Latest):
Kent Tamura . resolved

kojii@, would you review this please?

Open in Gerrit

Related details

Attention is currently required from:
  • Koji Ishii
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic8f51b7dbc11a57340826d3e38f377d0a454e6cf
Gerrit-Change-Number: 8029622
Gerrit-PatchSet: 6
Gerrit-Owner: Kent Tamura <tk...@chromium.org>
Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
Gerrit-Reviewer: Koji Ishii <ko...@chromium.org>
Gerrit-Attention: Koji Ishii <ko...@chromium.org>
Gerrit-Comment-Date: Fri, 03 Jul 2026 05:29:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Koji Ishii (Gerrit)

unread,
9:43 AM (6 hours ago) 9:43 AM
to Kent Tamura, Chromium LUCI CQ, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, zol...@webkit.org, blink-revi...@chromium.org, blink-...@chromium.org
Attention needed from Kent Tamura

Koji Ishii voted and added 1 comment

Votes added by Koji Ishii

Code-Review+1

1 comment

Patchset-level comments
Open in Gerrit

Related details

Attention is currently required from:
  • Kent Tamura
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic8f51b7dbc11a57340826d3e38f377d0a454e6cf
    Gerrit-Change-Number: 8029622
    Gerrit-PatchSet: 7
    Gerrit-Owner: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Koji Ishii <ko...@chromium.org>
    Gerrit-Attention: Kent Tamura <tk...@chromium.org>
    Gerrit-Comment-Date: Mon, 06 Jul 2026 13:43:20 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages