Ignore the ARIA attribute if equivalent HTML attribute is present [chromium/src : main]

Hunseop Jeong (Gerrit)

unread,

Jun 8, 2023, 8:50:46 PM6/8/23

to David Tseng, Aaron Leventhal, abigailbk...@google.com, aleventhal...@chromium.org, blink-...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, hirokisa...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, sarakat...@chromium.org, yuzo+...@chromium.org

Attention is currently required from: Aaron Leventhal, David Tseng.

Hunseop Jeong would like David Tseng and Aaron Leventhal to review this change.

View Change

Ignore the ARIA attribute if equivalent HTML attribute is present

Modify to prioritize the HTML attribute when both `readonly` and
`aria-readonly` attributes are present.

Bug: 1296104
Change-Id: I9a6093b7b98dc866c5a519cdb6fecce57a999337
---
M third_party/blink/renderer/modules/accessibility/ax_node_object.cc
M third_party/blink/web_tests/accessibility/readonly-expected.txt
M third_party/blink/web_tests/accessibility/readonly.html
3 files changed, 20 insertions(+), 13 deletions(-)

To view, visit change 4600773. To unsubscribe, or for help writing mail filters, visit settings.

Hunseop Jeong (Gerrit)

unread,

Jun 8, 2023, 8:50:49 PM6/8/23

to abigailbk...@google.com, aleventhal...@chromium.org, blink-...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, hirokisa...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, sarakat...@chromium.org, yuzo+...@chromium.org, David Tseng, Aaron Leventhal, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, Nektarios Paisios

Attention is currently required from: Aaron Leventhal, David Tseng.

View Change

To view, visit change 4600773. To unsubscribe, or for help writing mail filters, visit settings.

Aaron Leventhal (Gerrit)

unread,

Jun 9, 2023, 9:37:05 AM6/9/23

to Hunseop Jeong, abigailbk...@google.com, aleventhal...@chromium.org, blink-...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, hirokisa...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, sarakat...@chromium.org, yuzo+...@chromium.org, David Tseng, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, Nektarios Paisios

Attention is currently required from: David Tseng, Hunseop Jeong.

Patch set 1:Code-Review +1Commit-Queue +2

View Change

1 comment:

Patchset:
- Patch Set #1:
  Yep, this is correct! Thank you for fixing!

To view, visit change 4600773. To unsubscribe, or for help writing mail filters, visit settings.

Chromium LUCI CQ (Gerrit)

unread,

Jun 9, 2023, 10:24:14 AM6/9/23

to Hunseop Jeong, abigailbk...@google.com, aleventhal...@chromium.org, blink-...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, hirokisa...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, sarakat...@chromium.org, yuzo+...@chromium.org, Aaron Leventhal, David Tseng, Akihiro Ota, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, Nektarios Paisios

Chromium LUCI CQ submitted this change.

View Change

Approvals:
  Aaron Leventhal: Looks good to me; Commit

Ignore the ARIA attribute if equivalent HTML attribute is present

Modify to prioritize the HTML attribute when both `readonly` and
`aria-readonly` attributes are present.

Bug: 1296104
Change-Id: I9a6093b7b98dc866c5a519cdb6fecce57a999337

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4600773
Reviewed-by: Aaron Leventhal <aleve...@chromium.org>
Commit-Queue: Aaron Leventhal <aleve...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1155507}


---
M third_party/blink/renderer/modules/accessibility/ax_node_object.cc
M third_party/blink/web_tests/accessibility/readonly-expected.txt
M third_party/blink/web_tests/accessibility/readonly.html
3 files changed, 20 insertions(+), 13 deletions(-)

To view, visit change 4600773. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward