[Windows] Fix word navigation skipping punctuation before newline [chromium/src : main]

[Emre TEKE (Gerrit)]

Emre TEKE added 1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Emre TEKE . resolved

Hello,

This is my first patch for Blink.
I am open to your guidance.

Unfortunately, the engineers I tried from the owners file do not appear to be active, so I could not add them.
Who can look into this? Could you add someone else if you know someone?

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I3706e1cddd364c0e6ee2449065920e2cc5dc6bdf

Gerrit-Change-Number: 7544912

Gerrit-PatchSet: 1

Gerrit-Owner: Emre TEKE <emrete...@gmail.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Comment-Date: Fri, 06 Feb 2026 03:14:37 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Jacques Newman (Gerrit)]

Attention needed from Emre TEKE

Jacques Newman added 6 comments

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Emre TEKE . resolved

Hello,

This is my first patch for Blink.
I am open to your guidance.

Unfortunately, the engineers I tried from the owners file do not appear to be active, so I could not add them.
Who can look into this? Could you add someone else if you know someone?

Jacques Newman

Asking around to get the right folks looking at this.

File-level comment, Patchset 1 (Latest):

Jacques Newman . resolved

Thanks again for taking the time to identify and address issues!

File third_party/blink/renderer/core/editing/visible_units_word_test.cc

Line 877, Patchset 1 (Latest): // covers the fix for the reported issue.

Jacques Newman . unresolved

nit: link the bug directly.

```suggestion
  // covers the fix for crbug.com/481087619.
```

File third_party/blink/web_tests/editing/selection/move-by-word-win-punctuation-newline.html

Line 31, Patchset 1 (Latest): " {\n",

Jacques Newman . unresolved

nit: trailing space after comma.
```suggestion
    "    {\n",
```

Line 32, Patchset 1 (Latest): 0,

Jacques Newman . unresolved

nit: trailing space after comma.
```suggestion
    0,
```

Line 42, Patchset 1 (Latest):
</script>

Jacques Newman . unresolved

nit: trailing space
```suggestion

</script>
```

Open in Gerrit

Related details

Attention is currently required from:

• Emre TEKE

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I3706e1cddd364c0e6ee2449065920e2cc5dc6bdf

Gerrit-Change-Number: 7544912

Gerrit-PatchSet: 1

Gerrit-Owner: Emre TEKE <emrete...@gmail.com>

Gerrit-CC: Jacques Newman <jane...@microsoft.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Emre TEKE <emrete...@gmail.com>

Gerrit-Comment-Date: Fri, 06 Feb 2026 22:46:59 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Emre TEKE <emrete...@gmail.com>

[Emre TEKE (Gerrit)]

Attention needed from Dan Clark and Jacques Newman

Emre TEKE added 3 comments

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Emre TEKE . resolved

Thank you for your time.

I had experienced issues with clang format on my machine and did the formatting work manually because of it. The issue is resolved and everything looks better now.

File third_party/blink/web_tests/editing/selection/move-by-word-win-punctuation-newline.html

Line 32, Patchset 1: 0,

Jacques Newman . unresolved

nit: trailing space after comma.
```suggestion
    0,
```

Emre TEKE

Thank you for your review

Line 42, Patchset 1:
</script>

Jacques Newman . unresolved

nit: trailing space
```suggestion

</script>
```

Emre TEKE

ok, i applied `git cl format`. sory for that.

Open in Gerrit

Related details

Attention is currently required from:

• Dan Clark
• Jacques Newman

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I3706e1cddd364c0e6ee2449065920e2cc5dc6bdf

Gerrit-Change-Number: 7544912

Gerrit-PatchSet: 2

Gerrit-Owner: Emre TEKE <emrete...@gmail.com>

Gerrit-Reviewer: Dan Clark <dan...@microsoft.com>

Gerrit-Reviewer: Jacques Newman <jane...@microsoft.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Dan Clark <dan...@microsoft.com>

Gerrit-Attention: Jacques Newman <jane...@microsoft.com>

Gerrit-Comment-Date: Sat, 07 Feb 2026 03:31:23 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Jacques Newman <jane...@microsoft.com>