Migrate t/b/{public,renderer}/platform/media to blink ns [3/6] [chromium/src : main]

0 views
Skip to first unread message

Henrique Ferreiro (Gerrit)

unread,
Jul 6, 2021, 6:44:08 PM7/6/21
to Will Cassella, blink-re...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, erickun...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, mfoltz...@chromium.org, poscia...@chromium.org

Attention is currently required from: Will Cassella.

Henrique Ferreiro would like Will Cassella to review this change.

View Change

Migrate t/b/{public,renderer}/platform/media to blink ns [3/6]

This CL is a follow-up to https://crrev.com/c/2847359 and
https://crrev.com/c/2925475.

The code moved from media/blink/ to Blink should use the blink
namespace. This CL just adds needed media:: prefixes to code in
third_party/blink/public/platform/media/.

Bug: 1198341
Change-Id: Idddc236e2ce754a8bf3a1b6b5ceeefda7d2bfb37
---
M third_party/blink/public/platform/media/buffered_data_source_host_impl.h
M third_party/blink/public/platform/media/key_system_config_selector.h
M third_party/blink/public/platform/media/learning_experiment_helper.h
M third_party/blink/public/platform/media/multi_buffer_data_source.h
M third_party/blink/public/platform/media/smoothness_helper.h
M third_party/blink/public/platform/media/video_frame_compositor.h
M third_party/blink/public/platform/media/web_encrypted_media_client_impl.h
M third_party/blink/public/platform/media/web_media_player_impl.h
M third_party/blink/public/platform/media/web_media_player_params.h
9 files changed, 138 insertions(+), 129 deletions(-)


To view, visit change 2972696. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Idddc236e2ce754a8bf3a1b6b5ceeefda7d2bfb37
Gerrit-Change-Number: 2972696
Gerrit-PatchSet: 7
Gerrit-Owner: Henrique Ferreiro <hfer...@igalia.com>
Gerrit-Reviewer: Henrique Ferreiro <hfer...@igalia.com>
Gerrit-Reviewer: Will Cassella <cas...@google.com>
Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
Gerrit-Attention: Will Cassella <cas...@google.com>
Gerrit-MessageType: newchange

Henrique Ferreiro (Gerrit)

unread,
Jul 6, 2021, 6:44:18 PM7/6/21
to blink-re...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, erickun...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, mfoltz...@chromium.org, poscia...@chromium.org, Will Cassella, Chromium LUCI CQ, chromium...@chromium.org, srirama chandra sekhar

Attention is currently required from: Will Cassella.

Patch set 6:Commit-Queue +1

View Change

1 comment:

To view, visit change 2972696. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Idddc236e2ce754a8bf3a1b6b5ceeefda7d2bfb37
Gerrit-Change-Number: 2972696
Gerrit-PatchSet: 6
Gerrit-Owner: Henrique Ferreiro <hfer...@igalia.com>
Gerrit-Reviewer: Henrique Ferreiro <hfer...@igalia.com>
Gerrit-Reviewer: Will Cassella <cas...@google.com>
Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
Gerrit-Attention: Will Cassella <cas...@google.com>
Gerrit-Comment-Date: Tue, 06 Jul 2021 22:44:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Will Cassella (Gerrit)

unread,
Jul 7, 2021, 11:14:29 PM7/7/21
to Henrique Ferreiro, blink-re...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, erickun...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, mfoltz...@chromium.org, poscia...@chromium.org, Chromium LUCI CQ, chromium...@chromium.org, srirama chandra sekhar

Attention is currently required from: Henrique Ferreiro.

Patch set 7:Code-Review +1

View Change

1 comment:

To view, visit change 2972696. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Idddc236e2ce754a8bf3a1b6b5ceeefda7d2bfb37
Gerrit-Change-Number: 2972696
Gerrit-PatchSet: 7
Gerrit-Owner: Henrique Ferreiro <hfer...@igalia.com>
Gerrit-Reviewer: Henrique Ferreiro <hfer...@igalia.com>
Gerrit-Reviewer: Will Cassella <cas...@google.com>
Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
Gerrit-Attention: Henrique Ferreiro <hfer...@igalia.com>
Gerrit-Comment-Date: Thu, 08 Jul 2021 03:14:19 +0000

Henrique Ferreiro (Gerrit)

unread,
Jul 8, 2021, 5:20:42 PM7/8/21
to blink-re...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, erickun...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, mfoltz...@chromium.org, poscia...@chromium.org, Will Cassella, Chromium LUCI CQ, chromium...@chromium.org, srirama chandra sekhar

Attention is currently required from: Henrique Ferreiro.

Patch set 7:Commit-Queue +2

View Change

    To view, visit change 2972696. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Idddc236e2ce754a8bf3a1b6b5ceeefda7d2bfb37
    Gerrit-Change-Number: 2972696
    Gerrit-PatchSet: 7
    Gerrit-Owner: Henrique Ferreiro <hfer...@igalia.com>
    Gerrit-Reviewer: Henrique Ferreiro <hfer...@igalia.com>
    Gerrit-Reviewer: Will Cassella <cas...@google.com>
    Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
    Gerrit-Attention: Henrique Ferreiro <hfer...@igalia.com>
    Gerrit-Comment-Date: Thu, 08 Jul 2021 21:20:29 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    Gerrit-MessageType: comment

    Chromium LUCI CQ (Gerrit)

    unread,
    Jul 8, 2021, 8:03:58 PM7/8/21
    to Henrique Ferreiro, blink-re...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, erickun...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, mfoltz...@chromium.org, poscia...@chromium.org, Will Cassella, chromium...@chromium.org, srirama chandra sekhar

    Chromium LUCI CQ submitted this change.

    View Change

    Approvals: Will Cassella: Looks good to me Henrique Ferreiro: Commit
    Migrate t/b/{public,renderer}/platform/media to blink ns [3/6]

    This CL is a follow-up to https://crrev.com/c/2847359 and
    https://crrev.com/c/2925475.

    The code moved from media/blink/ to Blink should use the blink
    namespace. This CL just adds needed media:: prefixes to code in
    third_party/blink/public/platform/media/.

    Bug: 1198341
    Change-Id: Idddc236e2ce754a8bf3a1b6b5ceeefda7d2bfb37
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2972696
    Reviewed-by: Will Cassella <cas...@google.com>
    Commit-Queue: Henrique Ferreiro <hfer...@igalia.com>
    Cr-Commit-Position: refs/heads/master@{#899771}

    ---
    M third_party/blink/public/platform/media/buffered_data_source_host_impl.h
    M third_party/blink/public/platform/media/key_system_config_selector.h
    M third_party/blink/public/platform/media/learning_experiment_helper.h
    M third_party/blink/public/platform/media/multi_buffer_data_source.h
    M third_party/blink/public/platform/media/smoothness_helper.h
    M third_party/blink/public/platform/media/video_frame_compositor.h
    M third_party/blink/public/platform/media/web_encrypted_media_client_impl.h
    M third_party/blink/public/platform/media/web_media_player_impl.h
    M third_party/blink/public/platform/media/web_media_player_params.h
    9 files changed, 138 insertions(+), 129 deletions(-)


    To view, visit change 2972696. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Idddc236e2ce754a8bf3a1b6b5ceeefda7d2bfb37
    Gerrit-Change-Number: 2972696
    Gerrit-PatchSet: 8
    Gerrit-Owner: Henrique Ferreiro <hfer...@igalia.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Henrique Ferreiro <hfer...@igalia.com>
    Gerrit-Reviewer: Will Cassella <cas...@google.com>
    Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
    Gerrit-MessageType: merged
    Reply all
    Reply to author
    Forward
    0 new messages