Revert "[CDP] introduce Inspector.workerScriptLoaded" [chromium/src : main]

0 views
Skip to first unread message

luci-bisection@appspot.gserviceaccount.com (Gerrit)

unread,
11:06 AM (10 hours ago) 11:06 AM
to Rubber Stamper, AyeAye, Dmitry Gozman, Chromium LUCI CQ, Andrey Kosyakov, devtools...@chromium.org, chromium...@chromium.org, ort...@google.com, blink-re...@chromium.org, kinuko...@chromium.org, devtools-re...@chromium.org, blink-...@chromium.org, shimazu...@chromium.org, horo+...@chromium.org, blink-work...@chromium.org
Attention needed from Andrey Kosyakov and Dmitry Gozman

Message from luci-bi...@appspot.gserviceaccount.com

LUCI Bisection could not automatically submit this revert because LUCI Bisection has not yet support auto-commit of revert CL for test failure.

Open in Gerrit

Related details

Attention is currently required from:
  • Andrey Kosyakov
  • Dmitry Gozman
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie6c5035c66b3ff0199dabc87c0cd5aa5074eea70
Gerrit-Change-Number: 7045937
Gerrit-PatchSet: 1
Gerrit-Reviewer: Andrey Kosyakov <ca...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Dmitry Gozman <dgo...@chromium.org>
Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Gerrit-Attention: Dmitry Gozman <dgo...@chromium.org>
Gerrit-Attention: Andrey Kosyakov <ca...@chromium.org>
Gerrit-Comment-Date: Wed, 15 Oct 2025 15:06:33 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Rubber Stamper (Gerrit)

unread,
11:07 AM (10 hours ago) 11:07 AM
to luci-bi...@appspot.gserviceaccount.com, AyeAye, Dmitry Gozman, Chromium LUCI CQ, Andrey Kosyakov, devtools...@chromium.org, chromium...@chromium.org, ort...@google.com, blink-re...@chromium.org, kinuko...@chromium.org, devtools-re...@chromium.org, blink-...@chromium.org, shimazu...@chromium.org, horo+...@chromium.org, blink-work...@chromium.org
Attention needed from Andrey Kosyakov and Dmitry Gozman

Rubber Stamper voted Bot-Commit+1

Bot-Commit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Andrey Kosyakov
  • Dmitry Gozman
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie6c5035c66b3ff0199dabc87c0cd5aa5074eea70
    Gerrit-Change-Number: 7045937
    Gerrit-PatchSet: 1
    Gerrit-Reviewer: Andrey Kosyakov <ca...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Dmitry Gozman <dgo...@chromium.org>
    Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
    Gerrit-Attention: Dmitry Gozman <dgo...@chromium.org>
    Gerrit-Attention: Andrey Kosyakov <ca...@chromium.org>
    Gerrit-Comment-Date: Wed, 15 Oct 2025 15:07:09 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Giovanni Ortuno Urquidi (Gerrit)

    unread,
    11:13 AM (10 hours ago) 11:13 AM
    to luci-bi...@appspot.gserviceaccount.com, Giovanni Ortuno Urquidi, Rubber Stamper, AyeAye, Dmitry Gozman, Chromium LUCI CQ, Andrey Kosyakov, devtools...@chromium.org, chromium...@chromium.org, ort...@google.com, blink-re...@chromium.org, kinuko...@chromium.org, devtools-re...@chromium.org, blink-...@chromium.org, shimazu...@chromium.org, horo+...@chromium.org, blink-work...@chromium.org
    Attention needed from Andrey Kosyakov and Dmitry Gozman

    Giovanni Ortuno Urquidi voted and added 1 comment

    Votes added by Giovanni Ortuno Urquidi

    Code-Review+1
    Commit-Queue+2
    Owners-Override+1

    1 comment

    Patchset-level comments
    File-level comment, Patchset 1 (Latest):
    Giovanni Ortuno Urquidi . resolved

    The analysis looks correct to me.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Andrey Kosyakov
    • Dmitry Gozman
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie6c5035c66b3ff0199dabc87c0cd5aa5074eea70
    Gerrit-Change-Number: 7045937
    Gerrit-PatchSet: 1
    Gerrit-Reviewer: Andrey Kosyakov <ca...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Dmitry Gozman <dgo...@chromium.org>
    Gerrit-Reviewer: Giovanni Ortuno Urquidi <ort...@chromium.org>
    Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
    Gerrit-Attention: Dmitry Gozman <dgo...@chromium.org>
    Gerrit-Attention: Andrey Kosyakov <ca...@chromium.org>
    Gerrit-Comment-Date: Wed, 15 Oct 2025 15:13:39 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    11:14 AM (10 hours ago) 11:14 AM
    to luci-bi...@appspot.gserviceaccount.com, Giovanni Ortuno Urquidi, Rubber Stamper, AyeAye, Dmitry Gozman, Andrey Kosyakov, devtools...@chromium.org, chromium...@chromium.org, ort...@google.com, blink-re...@chromium.org, kinuko...@chromium.org, devtools-re...@chromium.org, blink-...@chromium.org, shimazu...@chromium.org, horo+...@chromium.org, blink-work...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Revert "[CDP] introduce Inspector.workerScriptLoaded"

    This reverts commit 022b53e3fb2c5fd52e4be026fad5097de1a52b17.

    Reason for revert:
    LUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/6242229220802560

    Sample build with failed test: https://ci.chromium.org/b/8700937344516775633
    Affected test(s):
    [ninja://:blink_web_tests/inspector-protocol/target/target-send-message.js](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2F:blink_web_tests%2Finspector-protocol%2Ftarget%2Ftarget-send-message.js?q=VHash%3Adae5f96b53c0ec12)

    If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Ftest-analysis%2Fb%2F6242229220802560&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F7016867&type=BUG

    Original change's description:
    > [CDP] introduce Inspector.workerScriptLoaded
    >
    > This event tells when the main worker script, and all imported
    > scripts, have been evaluated. Most of the time, accessing worker
    > before this moment is useless, as you get an empty context.
    >
    > Now clients can setup the worker before the main script is evaluated,
    > then call Runtime.runIfWaitingForDebugger, and then wait until the
    > main script is evaluated before evaluating anything in the fully
    > setup worker.
    >
    > Bug: 407795731
    > Change-Id: Ie800a17dae42810e077c7c0bf49f0821d728a674
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7016867
    > Commit-Queue: Dmitry Gozman <dgo...@chromium.org>
    > Reviewed-by: Andrey Kosyakov <ca...@chromium.org>
    > Cr-Commit-Position: refs/heads/main@{#1530173}
    >
    Bug: 407795731
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Change-Id: Ie6c5035c66b3ff0199dabc87c0cd5aa5074eea70
    Owners-Override: Giovanni Ortuno Urquidi <ort...@chromium.org>
    Reviewed-by: Giovanni Ortuno Urquidi <ort...@chromium.org>
    Commit-Queue: Giovanni Ortuno Urquidi <ort...@chromium.org>
    Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/main@{#1530214}
    Files:
    • M third_party/blink/public/devtools_protocol/domains/Inspector.pdl
    • M third_party/blink/renderer/core/inspector/BUILD.gn
    • M third_party/blink/renderer/core/inspector/build.gni
    • D third_party/blink/renderer/core/inspector/inspector_inspector_agent.cc
    • D third_party/blink/renderer/core/inspector/inspector_inspector_agent.h
    • M third_party/blink/renderer/core/inspector/inspector_protocol_config.json
    • M third_party/blink/renderer/core/inspector/worker_inspector_controller.cc
    • M third_party/blink/renderer/core/inspector/worker_inspector_controller.h
    • M third_party/blink/renderer/core/workers/worker_global_scope.cc
    • D third_party/blink/web_tests/http/tests/inspector-protocol/inspector/worker-script-loaded-expected.txt
    • D third_party/blink/web_tests/http/tests/inspector-protocol/inspector/worker-script-loaded.js
    • D third_party/blink/web_tests/http/tests/inspector-protocol/resources/workerClassic.js
    • D third_party/blink/web_tests/http/tests/inspector-protocol/resources/workerClassicImport.js
    • D third_party/blink/web_tests/http/tests/inspector-protocol/resources/workerModule.js
    • D third_party/blink/web_tests/http/tests/inspector-protocol/resources/workerModuleImport.js
    Change size: M
    Delta: 15 files changed, 6 insertions(+), 145 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Giovanni Ortuno Urquidi, Bot-Commit+1 by Rubber Stamper
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie6c5035c66b3ff0199dabc87c0cd5aa5074eea70
    Gerrit-Change-Number: 7045937
    Gerrit-PatchSet: 2
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages