webrtc-svc: demonstrate L1T3 and L1T3 for VP8 [chromium/src : main]

0 views
Skip to first unread message

Philipp Hancke (Gerrit)

unread,
Oct 28, 2021, 4:52:23 AM10/28/21
to Harald Alvestrand, blink-revie...@chromium.org, blink-...@chromium.org

Attention is currently required from: Harald Alvestrand.

Philipp Hancke would like Harald Alvestrand to review this change.

View Change

webrtc-svc: demonstrate L1T3 and L1T3 for VP8

BUG=chromium:986069

Change-Id: I459ab743edca3cc14d359a18b253594005acacf1
---
A third_party/blink/web_tests/external/wpt/webrtc-svc/layers.html
1 file changed, 69 insertions(+), 0 deletions(-)


To view, visit change 3249971. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I459ab743edca3cc14d359a18b253594005acacf1
Gerrit-Change-Number: 3249971
Gerrit-PatchSet: 1
Gerrit-Owner: Philipp Hancke <philipp...@googlemail.com>
Gerrit-Reviewer: Harald Alvestrand <h...@chromium.org>
Gerrit-Attention: Harald Alvestrand <h...@chromium.org>
Gerrit-MessageType: newchange

Philipp Hancke (Gerrit)

unread,
Oct 28, 2021, 4:52:33 AM10/28/21
to blink-revie...@chromium.org, blink-...@chromium.org, Harald Alvestrand, chromium...@chromium.org

Attention is currently required from: Harald Alvestrand.

View Change

1 comment:

  • Patchset:

    • Patch Set #1:

      needs some more work such as setCodecPreferences to ensure VP8.

      I am a bit surprised this did L1Tx for a non-simulcast VP8 stream but doing simulcast (like the insertable streams test this is based on) is not that difficult

To view, visit change 3249971. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I459ab743edca3cc14d359a18b253594005acacf1
Gerrit-Change-Number: 3249971
Gerrit-PatchSet: 1
Gerrit-Owner: Philipp Hancke <philipp...@googlemail.com>
Gerrit-Reviewer: Harald Alvestrand <h...@chromium.org>
Gerrit-Attention: Harald Alvestrand <h...@chromium.org>
Gerrit-Comment-Date: Thu, 28 Oct 2021 08:52:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Blink WPT Bot (Gerrit)

unread,
Oct 28, 2021, 4:54:01 AM10/28/21
to Philipp Hancke, blink-revie...@chromium.org, blink-...@chromium.org, Harald Alvestrand, chromium...@chromium.org

Attention is currently required from: Harald Alvestrand.

Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/31414.

When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.

WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process

View Change

    To view, visit change 3249971. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I459ab743edca3cc14d359a18b253594005acacf1
    Gerrit-Change-Number: 3249971
    Gerrit-PatchSet: 1
    Gerrit-Owner: Philipp Hancke <philipp...@googlemail.com>
    Gerrit-Reviewer: Harald Alvestrand <h...@chromium.org>
    Gerrit-CC: Blink WPT Bot <blink-w3c-te...@chromium.org>
    Gerrit-Attention: Harald Alvestrand <h...@chromium.org>
    Gerrit-Comment-Date: Thu, 28 Oct 2021 08:53:49 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: No
    Gerrit-MessageType: comment

    Harald Alvestrand (Gerrit)

    unread,
    Oct 28, 2021, 6:07:34 AM10/28/21
    to Philipp Hancke, blink-revie...@chromium.org, blink-...@chromium.org, Blink WPT Bot, chromium...@chromium.org

    Attention is currently required from: Philipp Hancke.

    View Change

    2 comments:

    • Patchset:

      • Patch Set #1:

        But can we have a WPT test that depends on a nonstandard feature....?

    • File third_party/blink/web_tests/external/wpt/webrtc-svc/layers.html:

      • Patch Set #1, Line 13: const pc1 = new RTCPeerConnection({encodedInsertableStreams:true});

        I think here you need to feature-detect whether we have the Chrome-specifc insertable stream, the Safari-specific insertable stream (current spec) or no insertable stream at all.

    To view, visit change 3249971. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I459ab743edca3cc14d359a18b253594005acacf1
    Gerrit-Change-Number: 3249971
    Gerrit-PatchSet: 1
    Gerrit-Owner: Philipp Hancke <philipp...@googlemail.com>
    Gerrit-Reviewer: Harald Alvestrand <h...@chromium.org>
    Gerrit-CC: Blink WPT Bot <blink-w3c-te...@chromium.org>
    Gerrit-Attention: Philipp Hancke <philipp...@googlemail.com>
    Gerrit-Comment-Date: Thu, 28 Oct 2021 10:07:19 +0000
    Reply all
    Reply to author
    Forward
    0 new messages