Add UMA metric for post-respondWith Service Worker race fetch errors [chromium/src : main]

0 views
Skip to first unread message

Yoshisato Yanagisawa (Gerrit)

unread,
Jul 23, 2026, 5:57:57 AM (4 days ago) Jul 23
to Shunya Shishido, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Hiroki Nakagawa, asvitkine...@chromium.org, blink-...@chromium.org, horo+...@chromium.org, kinuko+ser...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org
Attention needed from Shunya Shishido

Yoshisato Yanagisawa voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Shunya Shishido
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I1d9ed1791cf332b64e45131d484ba9e70dd97bf2
Gerrit-Change-Number: 8137340
Gerrit-PatchSet: 12
Gerrit-Owner: Yoshisato Yanagisawa <yyana...@chromium.org>
Gerrit-Reviewer: Shunya Shishido <sisid...@chromium.org>
Gerrit-Reviewer: Yoshisato Yanagisawa <yyana...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-Attention: Shunya Shishido <sisid...@chromium.org>
Gerrit-Comment-Date: Thu, 23 Jul 2026 09:57:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Shunya Shishido (Gerrit)

unread,
Jul 23, 2026, 11:10:39 AM (4 days ago) Jul 23
to Yoshisato Yanagisawa, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Hiroki Nakagawa, asvitkine...@chromium.org, blink-...@chromium.org, horo+...@chromium.org, kinuko+ser...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org
Attention needed from Yoshisato Yanagisawa

Shunya Shishido added 1 comment

File third_party/blink/renderer/modules/service_worker/service_worker_thread.h
Line 49, Patchset 12 (Parent):class MODULES_EXPORT ServiceWorkerThread final : public WorkerThread {
Shunya Shishido . unresolved

Prefer keeping final on ServiceWorkerThread to enforce class invariants at compile time and allow devirtualization. If we abstract ServiceWorkerGlobalScope::Create(WorkerThread*, ...) to accept WorkerThread*, we won't need to subclass ServiceWorkerThread for testing?

Open in Gerrit

Related details

Attention is currently required from:
  • Yoshisato Yanagisawa
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I1d9ed1791cf332b64e45131d484ba9e70dd97bf2
    Gerrit-Change-Number: 8137340
    Gerrit-PatchSet: 12
    Gerrit-Owner: Yoshisato Yanagisawa <yyana...@chromium.org>
    Gerrit-Reviewer: Shunya Shishido <sisid...@chromium.org>
    Gerrit-Reviewer: Yoshisato Yanagisawa <yyana...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
    Gerrit-Attention: Yoshisato Yanagisawa <yyana...@chromium.org>
    Gerrit-Comment-Date: Thu, 23 Jul 2026 15:10:06 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Yoshisato Yanagisawa (Gerrit)

    unread,
    Jul 24, 2026, 6:21:27 AM (3 days ago) Jul 24
    to Shunya Shishido, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Hiroki Nakagawa, asvitkine...@chromium.org, blink-...@chromium.org, horo+...@chromium.org, kinuko+ser...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org
    Attention needed from Shunya Shishido

    Yoshisato Yanagisawa added 1 comment

    File third_party/blink/renderer/modules/service_worker/service_worker_thread.h
    Line 49, Patchset 12 (Parent):class MODULES_EXPORT ServiceWorkerThread final : public WorkerThread {
    Shunya Shishido . resolved

    Prefer keeping final on ServiceWorkerThread to enforce class invariants at compile time and allow devirtualization. If we abstract ServiceWorkerGlobalScope::Create(WorkerThread*, ...) to accept WorkerThread*, we won't need to subclass ServiceWorkerThread for testing?

    Yoshisato Yanagisawa

    sure.
    The test has been updated to keep it `final`.
    SWGS::Create interface did not change, though.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Shunya Shishido
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I1d9ed1791cf332b64e45131d484ba9e70dd97bf2
      Gerrit-Change-Number: 8137340
      Gerrit-PatchSet: 16
      Gerrit-Owner: Yoshisato Yanagisawa <yyana...@chromium.org>
      Gerrit-Reviewer: Shunya Shishido <sisid...@chromium.org>
      Gerrit-Reviewer: Yoshisato Yanagisawa <yyana...@chromium.org>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
      Gerrit-Attention: Shunya Shishido <sisid...@chromium.org>
      Gerrit-Comment-Date: Fri, 24 Jul 2026 10:20:56 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Shunya Shishido <sisid...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Shunya Shishido (Gerrit)

      unread,
      Jul 26, 2026, 9:44:50 PM (7 hours ago) Jul 26
      to Yoshisato Yanagisawa, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Hiroki Nakagawa, asvitkine...@chromium.org, blink-...@chromium.org, horo+...@chromium.org, kinuko+ser...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org
      Attention needed from Yoshisato Yanagisawa

      Shunya Shishido voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Yoshisato Yanagisawa
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I1d9ed1791cf332b64e45131d484ba9e70dd97bf2
        Gerrit-Change-Number: 8137340
        Gerrit-PatchSet: 16
        Gerrit-Owner: Yoshisato Yanagisawa <yyana...@chromium.org>
        Gerrit-Reviewer: Shunya Shishido <sisid...@chromium.org>
        Gerrit-Reviewer: Yoshisato Yanagisawa <yyana...@chromium.org>
        Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
        Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
        Gerrit-Attention: Yoshisato Yanagisawa <yyana...@chromium.org>
        Gerrit-Comment-Date: Mon, 27 Jul 2026 01:44:15 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy

        Yoshisato Yanagisawa (Gerrit)

        unread,
        Jul 26, 2026, 9:50:07 PM (6 hours ago) Jul 26
        to Shunya Shishido, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Hiroki Nakagawa, asvitkine...@chromium.org, blink-...@chromium.org, horo+...@chromium.org, kinuko+ser...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org

        Yoshisato Yanagisawa voted Commit-Queue+2

        Commit-Queue+2
        Open in Gerrit

        Related details

        Attention set is empty
        Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I1d9ed1791cf332b64e45131d484ba9e70dd97bf2
        Gerrit-Change-Number: 8137340
        Gerrit-PatchSet: 16
        Gerrit-Owner: Yoshisato Yanagisawa <yyana...@chromium.org>
        Gerrit-Reviewer: Shunya Shishido <sisid...@chromium.org>
        Gerrit-Reviewer: Yoshisato Yanagisawa <yyana...@chromium.org>
        Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
        Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
        Gerrit-Comment-Date: Mon, 27 Jul 2026 01:49:37 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy

        Yoshisato Yanagisawa (Gerrit)

        unread,
        12:45 AM (4 hours ago) 12:45 AM
        to Shunya Shishido, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Hiroki Nakagawa, asvitkine...@chromium.org, blink-...@chromium.org, horo+...@chromium.org, kinuko+ser...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org
        Gerrit-Comment-Date: Mon, 27 Jul 2026 04:44:58 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy
        Reply all
        Reply to author
        Forward
        0 new messages