Preserve %2E encoding in URL paths [chromium/src : main]
Helmut Januschka (Gerrit)
Helmut Januschka added 1 comment![]( "Open in Gerrit")
hello @dch...@chromium.org thanks in advance for taking your time to review. please let me know if you want me to address anything.
Related details
- Daniel Cheng
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel Cheng (Gerrit)
Daniel Cheng added 1 comment![]( "Open in Gerrit")
Is this something that needs a feature flag? What are the risks with this change? How do other browsers behave?
Adding hayato@, who has done similar such cleanups in the past.
Related details
- Hayato Ito
- Helmut Januschka
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Helmut Januschka (Gerrit)
Helmut Januschka added 1 comment![]( "Open in Gerrit")
Is this something that needs a feature flag? What are the risks with this change? How do other browsers behave?
Adding hayato@, who has done similar such cleanups in the past.
Firefox and Safari are already compliant with the WHATWG URL Standard - they preserve %2E in URL paths rather than decoding it.
demo: https://jsdom.github.io/whatwg-url/#url=aHR0cDovL3d3dy9mb28lMkVodG1s&base=YWJvdXQ6Ymxhbms=
i dont expect this to require a feature flag.
Related details
- Daniel Cheng
- Hayato Ito
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel Cheng (Gerrit)
Daniel Cheng added 1 comment![]( "Open in Gerrit")
Helmut JanuschkaIs this something that needs a feature flag? What are the risks with this change? How do other browsers behave?
Adding hayato@, who has done similar such cleanups in the past.
Firefox and Safari are already compliant with the WHATWG URL Standard - they preserve %2E in URL paths rather than decoding it.
demo: https://jsdom.github.io/whatwg-url/#url=aHR0cDovL3d3dy9mb28lMkVodG1s&base=YWJvdXQ6Ymxhbms=
i dont expect this to require a feature flag.
Right, but are you sure nothing depends on the Chrome-specific behavior?
Related details
- Hayato Ito
- Helmut Januschka
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Helmut Januschka (Gerrit)
Helmut Januschka added 1 comment![]( "Open in Gerrit")
Helmut JanuschkaIs this something that needs a feature flag? What are the risks with this change? How do other browsers behave?
Adding hayato@, who has done similar such cleanups in the past.
Daniel ChengFirefox and Safari are already compliant with the WHATWG URL Standard - they preserve %2E in URL paths rather than decoding it.
demo: https://jsdom.github.io/whatwg-url/#url=aHR0cDovL3d3dy9mb28lMkVodG1s&base=YWJvdXQ6Ymxhbms=
i dont expect this to require a feature flag.
Right, but are you sure nothing depends on the Chrome-specific behavior?
Tested Firefox and Safari - both preserve %2E encoding.
Demo: https://jsdom.github.io/whatwg-url/#url=aHR0cDovL3d3dy9mb28lMkVodG1s&base=YWJvdXQ6Ymxhbms=
the change aligns behaviour with other engines, not sure if there is a huge blast radius.
not sure if adding a feature-flag + UMA would be the right approach in terms of.
let me know how you want me to continue, i'd add flag+uma if you want to.
Related details
- Daniel Cheng
- Hayato Ito
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |