Revert "[focusgroup] Rename no-memory modifier to nomemory" [chromium/src : main]

1 view
Skip to first unread message

Mike Wasserman (Gerrit)

unread,
Feb 27, 2026, 7:55:13 PM (yesterday) Feb 27
to Rubber Stamper, AyeAye, Mason Freed, Chromium LUCI CQ, Jacques Newman, Blink W3C Test Autoroller, chromium...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org
Attention needed from Jacques Newman and Mason Freed

Mike Wasserman voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Jacques Newman
  • Mason Freed
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ifddb437c60d11b7b77415ff95554e98829bf7f75
Gerrit-Change-Number: 7618328
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Wasserman <m...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Jacques Newman <jane...@microsoft.com>
Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
Gerrit-Reviewer: Mike Wasserman <m...@google.com>
Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
Gerrit-Attention: Mason Freed <mas...@chromium.org>
Gerrit-Attention: Jacques Newman <jane...@microsoft.com>
Gerrit-Comment-Date: Sat, 28 Feb 2026 00:55:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Mike Wasserman (Gerrit)

unread,
Feb 27, 2026, 7:55:27 PM (yesterday) Feb 27
to Rubber Stamper, AyeAye, Mason Freed, Chromium LUCI CQ, Jacques Newman, Blink W3C Test Autoroller, chromium...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org
Attention needed from Jacques Newman and Mason Freed

Mike Wasserman voted

Commit-Queue+2
Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • Jacques Newman
  • Mason Freed
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ifddb437c60d11b7b77415ff95554e98829bf7f75
Gerrit-Change-Number: 7618328
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Wasserman <m...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Jacques Newman <jane...@microsoft.com>
Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
Gerrit-Reviewer: Mike Wasserman <m...@google.com>
Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
Gerrit-Attention: Mason Freed <mas...@chromium.org>
Gerrit-Attention: Jacques Newman <jane...@microsoft.com>
Gerrit-Comment-Date: Sat, 28 Feb 2026 00:55:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Rubber Stamper (Gerrit)

unread,
Feb 27, 2026, 7:56:11 PM (yesterday) Feb 27
to Mike Wasserman, AyeAye, Mason Freed, Chromium LUCI CQ, Jacques Newman, Blink W3C Test Autoroller, chromium...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org
Attention needed from Jacques Newman, Mason Freed and Mike Wasserman

Rubber Stamper voted

Bot-Commit+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Jacques Newman
  • Mason Freed
  • Mike Wasserman
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ifddb437c60d11b7b77415ff95554e98829bf7f75
    Gerrit-Change-Number: 7618328
    Gerrit-PatchSet: 1
    Gerrit-Owner: Mike Wasserman <m...@google.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Jacques Newman <jane...@microsoft.com>
    Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
    Gerrit-Reviewer: Mike Wasserman <m...@google.com>
    Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
    Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
    Gerrit-Attention: Mike Wasserman <m...@google.com>
    Gerrit-Attention: Mason Freed <mas...@chromium.org>
    Gerrit-Attention: Jacques Newman <jane...@microsoft.com>
    Gerrit-Comment-Date: Sat, 28 Feb 2026 00:56:05 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Feb 27, 2026, 7:56:32 PM (yesterday) Feb 27
    to Mike Wasserman, Rubber Stamper, AyeAye, Mason Freed, Jacques Newman, Blink W3C Test Autoroller, chromium...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Revert "[focusgroup] Rename no-memory modifier to nomemory"

    This reverts commit 16d87f87998ac5937af20f8c5c3881d7c52dfb44.

    Reason for revert: FocusgroupFlagsTest failing on https://luci-milo.appspot.com/ui/p/chromium/builders/ci/mac15-arm64-rel-tests/21980/

    Original change's description:
    > [focusgroup] Rename no-memory modifier to nomemory
    >
    > It was recently brought up during a OpenUI call that these dashes break
    > the convention for values that can be set to an attribute. This change
    > removes the '-' character from the modifier.
    >
    > Bug: 40210717
    > Change-Id: I6413a4a62968522d1d5e2a5373a28513c7d3c998
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7614716
    > Reviewed-by: Mason Freed <mas...@chromium.org>
    > Commit-Queue: Jacques Newman <jane...@microsoft.com>
    > Cr-Commit-Position: refs/heads/main@{#1591880}
    Bug: 40210717
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Change-Id: Ifddb437c60d11b7b77415ff95554e98829bf7f75
    Commit-Queue: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
    Owners-Override: Mike Wasserman <m...@google.com>
    Auto-Submit: Mike Wasserman <m...@google.com>
    Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/main@{#1591910}
    Files:
    • M third_party/blink/renderer/core/dom/element_test.cc
    • M third_party/blink/renderer/core/dom/focusgroup_flags.cc
    • M third_party/blink/renderer/core/dom/focusgroup_flags_test.cc
    • M third_party/blink/web_tests/external/wpt/html/interaction/focus/focusgroup/tentative/forward-navigation/nested-focusgroup-is-item-of-parent.html
    • M third_party/blink/web_tests/external/wpt/html/interaction/focus/focusgroup/tentative/sequential-navigation/arrow-key-handler-tab-escape.html
    • M third_party/blink/web_tests/external/wpt/html/interaction/focus/focusgroup/tentative/sequential-navigation/basic-tab-behavior.html
    • M third_party/blink/web_tests/external/wpt/html/interaction/focus/focusgroup/tentative/sequential-navigation/dynamic-changes.html
    • M third_party/blink/web_tests/external/wpt/html/interaction/focus/focusgroup/tentative/sequential-navigation/focusgroup-segments.html
    • M third_party/blink/web_tests/external/wpt/html/interaction/focus/focusgroup/tentative/sequential-navigation/guaranteed-tab-stop-priority.html
    • M third_party/blink/web_tests/external/wpt/html/interaction/focus/focusgroup/tentative/sequential-navigation/memory-behavior.html
    • M third_party/blink/web_tests/external/wpt/html/interaction/focus/focusgroup/tentative/sequential-navigation/nested-focusgroups.html
    Change size: M
    Delta: 11 files changed, 17 insertions(+), 37 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: Bot-Commit+1 by Rubber Stamper
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ifddb437c60d11b7b77415ff95554e98829bf7f75
    Gerrit-Change-Number: 7618328
    Gerrit-PatchSet: 2
    open
    diffy
    satisfied_requirement

    Blink W3C Test Autoroller (Gerrit)

    unread,
    Feb 27, 2026, 11:28:12 PM (21 hours ago) Feb 27
    to Mike Wasserman, Chromium LUCI CQ, Rubber Stamper, AyeAye, Mason Freed, Jacques Newman, chromium...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org

    Message from Blink W3C Test Autoroller

    The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/58135

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ifddb437c60d11b7b77415ff95554e98829bf7f75
    Gerrit-Change-Number: 7618328
    Gerrit-PatchSet: 2
    Gerrit-Owner: Mike Wasserman <m...@google.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Jacques Newman <jane...@microsoft.com>
    Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
    Gerrit-Reviewer: Mike Wasserman <m...@google.com>
    Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
    Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
    Gerrit-Comment-Date: Sat, 28 Feb 2026 04:28:01 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: No
    satisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages