Update devtools warning for ProcessPerSiteUpToMainFrameThreshold feature [chromium/src : main]

Kenichi Ishibashi (Gerrit)

unread,

Jul 5, 2023, 8:34:03 PM7/5/23

to Danil Somsikov, blink-...@chromium.org, devtools-re...@chromium.org

Attention is currently required from: Danil Somsikov.

Kenichi Ishibashi would like Danil Somsikov to review this change.

Update devtools warning for ProcessPerSiteUpToMainFrameThreshold feature

It's more ergonomic to suggest using chrome://flags.

Bug: 1434900
Change-Id: Ic8e0d0627fde0122ffdbb9628e9e48b9d233e805
---
M third_party/blink/renderer/core/inspector/main_thread_debugger.cc
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/third_party/blink/renderer/core/inspector/main_thread_debugger.cc b/third_party/blink/renderer/core/inspector/main_thread_debugger.cc
index afe62a4..3aaa09f 100644
--- a/third_party/blink/renderer/core/inspector/main_thread_debugger.cc
+++ b/third_party/blink/renderer/core/inspector/main_thread_debugger.cc
@@ -359,9 +359,9 @@
     String message = String(
         "DevTools debugger is disabled because it is attached to a process "
         "that hosts multiple top-level frames, where DevTools debugger doesn't "
-        "work properly. Please relaunch the browser with "
-        "--disable-features=ProcessPerSiteUpToMainFrameThreshold to enable "
-        "debugger.");
+        "work properly. To enable debugger, visit "
+        "chrome://flags/#enable-process-per-site-up-to-main-frame-threshold "
+        "and disable the feature.");
     frame->Console().AddMessage(MakeGarbageCollected<ConsoleMessage>(
         mojom::ConsoleMessageSource::kJavaScript,
         mojom::ConsoleMessageLevel::kError, message));

To view, visit change 4667647. To unsubscribe, or for help writing mail filters, visit settings.

Kenichi Ishibashi (Gerrit)

unread,

Jul 5, 2023, 8:34:06 PM7/5/23

to blink-...@chromium.org, devtools-re...@chromium.org, Danil Somsikov, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Danil Somsikov.

View Change

1 comment:

Patchset:
- Patch Set #1:
  dsv@: PTAL, I got a request to update the warning message.

To view, visit change 4667647. To unsubscribe, or for help writing mail filters, visit settings.

Danil Somsikov (Gerrit)

unread,

Jul 6, 2023, 1:39:18 AM7/6/23

to Kenichi Ishibashi, blink-...@chromium.org, devtools-re...@chromium.org, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Kenichi Ishibashi.

Patch set 1:Code-Review +1

View Change

To view, visit change 4667647. To unsubscribe, or for help writing mail filters, visit settings.

Kenichi Ishibashi (Gerrit)

unread,

Jul 6, 2023, 2:36:03 AM7/6/23

to blink-...@chromium.org, devtools-re...@chromium.org, Danil Somsikov, Chromium LUCI CQ, chromium...@chromium.org

Patch set 1:Commit-Queue +2

View Change

1 comment:

Patchset:
- Patch Set #1:
  Thank you!

To view, visit change 4667647. To unsubscribe, or for help writing mail filters, visit settings.

Chromium LUCI CQ (Gerrit)

unread,

Jul 6, 2023, 2:51:18 AM7/6/23

to Kenichi Ishibashi, blink-...@chromium.org, devtools-re...@chromium.org, Danil Somsikov, chromium...@chromium.org

Chromium LUCI CQ submitted this change.

View Change

Approvals:
  Kenichi Ishibashi: Commit
  Danil Somsikov: Looks good to me

Update devtools warning for ProcessPerSiteUpToMainFrameThreshold feature

It's more ergonomic to suggest using chrome://flags.

Bug: 1434900
Change-Id: Ic8e0d0627fde0122ffdbb9628e9e48b9d233e805

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4667647
Reviewed-by: Danil Somsikov <d...@chromium.org>
Commit-Queue: Kenichi Ishibashi <ba...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1166336}


---
M third_party/blink/renderer/core/inspector/main_thread_debugger.cc
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/third_party/blink/renderer/core/inspector/main_thread_debugger.cc b/third_party/blink/renderer/core/inspector/main_thread_debugger.cc
index afe62a4..3aaa09f 100644
--- a/third_party/blink/renderer/core/inspector/main_thread_debugger.cc
+++ b/third_party/blink/renderer/core/inspector/main_thread_debugger.cc
@@ -359,9 +359,9 @@
     String message = String(
         "DevTools debugger is disabled because it is attached to a process "
         "that hosts multiple top-level frames, where DevTools debugger doesn't "
-        "work properly. Please relaunch the browser with "
-        "--disable-features=ProcessPerSiteUpToMainFrameThreshold to enable "
-        "debugger.");
+        "work properly. To enable debugger, visit "
+        "chrome://flags/#enable-process-per-site-up-to-main-frame-threshold "
+        "and disable the feature.");
     frame->Console().AddMessage(MakeGarbageCollected<ConsoleMessage>(
         mojom::ConsoleMessageSource::kJavaScript,
         mojom::ConsoleMessageLevel::kError, message));

To view, visit change 4667647. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward