Deflake OffscreenCanvas-Bitmaprenderer-toBlob-worker.html [chromium/src : main]

Justin Novosad (Gerrit)

unread,

Mar 20, 2023, 4:09:11 PM3/20/23

to Yi Xu, blink-...@chromium.org

Attention is currently required from: Yi Xu.

Justin Novosad would like Yi Xu to review this change.

Deflake OffscreenCanvas-Bitmaprenderer-toBlob-worker.html

Test was using requestAnimationFrame instead of listening for 'load'
event to determine whether image element was ready for capture.

Bug:1185051
Change-Id: I361c950ab81500af3d1e33ab1e9956d9ba275e46
---
M third_party/blink/web_tests/TestExpectations
M third_party/blink/web_tests/fast/canvas/OffscreenCanvas-Bitmaprenderer-toBlob-worker.html
2 files changed, 5 insertions(+), 7 deletions(-)

diff --git a/third_party/blink/web_tests/TestExpectations b/third_party/blink/web_tests/TestExpectations
index f5d6f8f..ee9461f1 100644
--- a/third_party/blink/web_tests/TestExpectations
+++ b/third_party/blink/web_tests/TestExpectations
@@ -4792,8 +4792,6 @@
 # Sheriff 2021-03-08
 crbug.com/1092462 [ Linux ] http/tests/media/media-source/mediasource-duration.html [ Failure Pass ]
 
-crbug.com/1185051 fast/canvas/OffscreenCanvas-Bitmaprenderer-toBlob-worker.html [ Failure Pass ]
-
 # Expect failure for unimplemented canvas color object input
 crbug.com/1187575 external/wpt/html/canvas/element/fill-and-stroke-styles/2d.fillStyle.colorObject.html [ Failure ]
 crbug.com/1187575 external/wpt/html/canvas/element/fill-and-stroke-styles/2d.fillStyle.colorObject.transparency.html [ Failure ]
diff --git a/third_party/blink/web_tests/fast/canvas/OffscreenCanvas-Bitmaprenderer-toBlob-worker.html b/third_party/blink/web_tests/fast/canvas/OffscreenCanvas-Bitmaprenderer-toBlob-worker.html
index 8dacee0..b6b0a54 100644
--- a/third_party/blink/web_tests/fast/canvas/OffscreenCanvas-Bitmaprenderer-toBlob-worker.html
+++ b/third_party/blink/web_tests/fast/canvas/OffscreenCanvas-Bitmaprenderer-toBlob-worker.html
@@ -30,7 +30,7 @@
   htmlCanvasCtx.fillStyle = "green";
   htmlCanvasCtx.fillRect(15, 30, 45, 30);
 
-  // Fill canvasToBlobWorker and canvasTrasnferControlWorker
+  // Fill canvasToBlobWorker and canvasTransferControlWorker
   var blob = new Blob([document.getElementById("worker").textContent]);
   var worker = new Worker(URL.createObjectURL(blob));
 
@@ -38,11 +38,11 @@
 
   worker.addEventListener('message', ev => {
     pngImageWorker.src = URL.createObjectURL(ev.data);
-    if (window.testRunner) {
-      requestAnimationFrame(() => {
+    pngImageWorker.onload = () => {
+      if (window.testRunner) {
         testRunner.notifyDone();
-      });
-    }
+      }
+    };
   });
 
   createImageBitmap(htmlCanvas).then(function(bmap){

To view, visit change 4348645. To unsubscribe, or for help writing mail filters, visit settings.

Justin Novosad (Gerrit)

unread,

Mar 20, 2023, 4:09:15 PM3/20/23

to blink-...@chromium.org, Yi Xu, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Yi Xu.

View Change

To view, visit change 4348645. To unsubscribe, or for help writing mail filters, visit settings.

Yi Xu (Gerrit)

unread,

Mar 29, 2023, 3:14:37 PM3/29/23

to Justin Novosad, blink-...@chromium.org, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Justin Novosad.

Patch set 2:Code-Review +1

View Change

To view, visit change 4348645. To unsubscribe, or for help writing mail filters, visit settings.

Yi Xu (Gerrit)

unread,

May 4, 2023, 2:04:27 PM5/4/23

to Justin Novosad, blink-...@chromium.org, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Justin Novosad.

Patch set 2:Commit-Queue +2

View Change

To view, visit change 4348645. To unsubscribe, or for help writing mail filters, visit settings.

Chromium LUCI CQ (Gerrit)

unread,

May 4, 2023, 2:58:57 PM5/4/23

to Justin Novosad, blink-...@chromium.org, Yi Xu, chromium...@chromium.org

Chromium LUCI CQ submitted this change.

View Change

Approvals:
  Yi Xu: Looks good to me; Commit

Deflake OffscreenCanvas-Bitmaprenderer-toBlob-worker.html

Test was using requestAnimationFrame instead of listening for 'load'
event to determine whether image element was ready for capture.

Bug: 1185051
Change-Id: I361c950ab81500af3d1e33ab1e9956d9ba275e46

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4348645
Reviewed-by: Yi Xu <yi...@chromium.org>
Commit-Queue: Yi Xu <yi...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1139692}


---
M third_party/blink/web_tests/TestExpectations
M third_party/blink/web_tests/fast/canvas/OffscreenCanvas-Bitmaprenderer-toBlob-worker.html
2 files changed, 5 insertions(+), 7 deletions(-)

diff --git a/third_party/blink/web_tests/TestExpectations b/third_party/blink/web_tests/TestExpectations
index 30b0492..63f2b0d4 100644
--- a/third_party/blink/web_tests/TestExpectations
+++ b/third_party/blink/web_tests/TestExpectations
@@ -4781,8 +4781,6 @@

To view, visit change 4348645. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward