Fix overlay flag [chromium/src : main]

[Joey Arhar (Gerrit)]

Attention needed from Robert Flack and Rune Lillesveen

Joey Arhar added 1 comment

Commit Message

File-level comment, Patchset 1 (Latest):

Joey Arhar . unresolved

Hey yall, I realized that there are a bunch of tests unexpectedly failing after I made this patch to remove the overlay property: https://chromium-review.googlesource.com/c/chromium/src/+/7133219

You can see what the failures look like: https://chromium-layout-test-archives.storage.googleapis.com/results.html?json=chromium/try/linux-rel/2493697/headless_shell_wpt_tests%20%28with%20patch%29/full_results_jsonp.js

It looks like some tests which are supposed to have scroll markers don't have them anymore, and some tests which weren't supposed to have a scrollbar now have a scrollbar. Did I miss something in my patch to put overlay behind a flag?

Open in Gerrit

Related details

Attention is currently required from:

• Robert Flack
• Rune Lillesveen

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I38765c705b40d57ca929eff13cd19189d78e8594

Gerrit-Change-Number: 7302694

Gerrit-PatchSet: 1

Gerrit-Owner: Joey Arhar <jar...@chromium.org>

Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>

Gerrit-Reviewer: Robert Flack <fla...@chromium.org>

Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Rune Lillesveen <fut...@chromium.org>

Gerrit-Attention: Robert Flack <fla...@chromium.org>

Gerrit-Comment-Date: Tue, 23 Dec 2025 00:50:32 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No