David Awogbemila (Gerrit)

unread,

12:02 PM (11 hours ago) 12:02 PM

to Robert Flack, Chromium LUCI CQ, Menard, Alexis, David Bokan, Chromium Metrics Reviews, chromium...@chromium.org, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, zol...@webkit.org

Attention needed from Robert Flack

David Awogbemila added 1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

David Awogbemila . resolved

Hey Rob, please take a look at this scroll-start removal, thanks.

Open in Gerrit

Related details

Attention is currently required from:

Robert Flack

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Robert Flack (Gerrit)

unread,

4:47 PM (6 hours ago) 4:47 PM

to David Awogbemila, Chromium LUCI CQ, Menard, Alexis, David Bokan, Chromium Metrics Reviews, chromium...@chromium.org, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, zol...@webkit.org

Attention needed from David Awogbemila

Robert Flack voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

David Awogbemila

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

David Awogbemila (Gerrit)

unread,

4:56 PM (6 hours ago) 4:56 PM

to Robert Flack, Chromium LUCI CQ, Menard, Alexis, David Bokan, Chromium Metrics Reviews, chromium...@chromium.org, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, zol...@webkit.org

David Awogbemila voted

Code-Review	+1
Commit-Queue	+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

5:00 PM (6 hours ago) 5:00 PM

to David Awogbemila, Robert Flack, Menard, Alexis, David Bokan, Chromium Metrics Reviews, chromium...@chromium.org, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, zol...@webkit.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

Remove scroll-start

The CSS working group opted[1] not to adopt scroll-start and we don't
have plans to continue the feature.

[1] https://github.com/w3c/csswg-drafts/issues/6985#issuecomment-2166073296

Bug: 40909052

Change-Id: I6f971b7350735773bf88240ace8b4273bef065ce

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7155568

Reviewed-by: David Awogbemila <awogb...@chromium.org>

Commit-Queue: David Awogbemila <awogb...@chromium.org>

Reviewed-by: Robert Flack <fla...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1545249}

Files:

M third_party/blink/public/mojom/use_counter/metrics/css_property_id.mojom
M third_party/blink/renderer/build/scripts/core/style/make_computed_style_base.py
M third_party/blink/renderer/core/css/css_identifier_value_mappings.h
M third_party/blink/renderer/core/css/css_properties.json5
M third_party/blink/renderer/core/css/css_property_equality.cc
M third_party/blink/renderer/core/css/properties/computed_style_utils.cc
M third_party/blink/renderer/core/css/properties/computed_style_utils.h
M third_party/blink/renderer/core/css/properties/css_direction_aware_resolver.cc
M third_party/blink/renderer/core/css/properties/css_direction_aware_resolver.h
M third_party/blink/renderer/core/css/properties/css_parsing_utils.cc
M third_party/blink/renderer/core/css/properties/css_parsing_utils.h
M third_party/blink/renderer/core/css/properties/longhands/longhands_custom.cc
M third_party/blink/renderer/core/css/properties/shorthands/shorthands_custom.cc
M third_party/blink/renderer/core/css/resolver/style_builder_converter.cc
M third_party/blink/renderer/core/css/resolver/style_builder_converter.h
M third_party/blink/renderer/core/css/resolver/style_resolver.cc
M third_party/blink/renderer/core/css/style_property_serializer.cc
M third_party/blink/renderer/core/css/style_property_serializer.h
M third_party/blink/renderer/core/layout/forms/layout_fieldset.cc
M third_party/blink/renderer/core/paint/paint_layer_scrollable_area.cc
M third_party/blink/renderer/core/scroll/scrollable_area.cc
M third_party/blink/renderer/core/scroll/scrollable_area.h
M third_party/blink/renderer/core/scroll/scrollable_area_test.cc
M third_party/blink/renderer/core/style/build.gni
D third_party/blink/renderer/core/style/scroll_start_data.h
M third_party/blink/renderer/platform/runtime_enabled_features.json5
D third_party/blink/web_tests/external/wpt/css/css-scroll-snap/scroll-start/parsing/scroll-start-computed.html
D third_party/blink/web_tests/external/wpt/css/css-scroll-snap/scroll-start/parsing/scroll-start-invalid.html
D third_party/blink/web_tests/external/wpt/css/css-scroll-snap/scroll-start/parsing/scroll-start-shorthand.html
D third_party/blink/web_tests/external/wpt/css/css-scroll-snap/scroll-start/parsing/scroll-start-valid.html
D third_party/blink/web_tests/external/wpt/css/css-scroll-snap/scroll-start/scroll-start-display-toggled.tentative.html
D third_party/blink/web_tests/external/wpt/css/css-scroll-snap/scroll-start/scroll-start-fieldset.tentative.html
D third_party/blink/web_tests/external/wpt/css/css-scroll-snap/scroll-start/scroll-start-overflow-toggled.tentative.html
D third_party/blink/web_tests/external/wpt/css/css-scroll-snap/scroll-start/scroll-start-root.tentative.html
D third_party/blink/web_tests/external/wpt/css/css-scroll-snap/scroll-start/scroll-start-vertical-lr.tentative.html
D third_party/blink/web_tests/external/wpt/css/css-scroll-snap/scroll-start/scroll-start-with-anchor-navigation-inner-frame.html
D third_party/blink/web_tests/external/wpt/css/css-scroll-snap/scroll-start/scroll-start-with-anchor-navigation.tentative.html
D third_party/blink/web_tests/external/wpt/css/css-scroll-snap/scroll-start/scroll-start-with-fragment-navigation-inner-frame.html
D third_party/blink/web_tests/external/wpt/css/css-scroll-snap/scroll-start/scroll-start-with-fragment-navigation.tentative.html
D third_party/blink/web_tests/external/wpt/css/css-scroll-snap/scroll-start/scroll-start-with-programmatic-scroll.tentative.html
D third_party/blink/web_tests/external/wpt/css/css-scroll-snap/scroll-start/scroll-start-with-scroll-snap.tentative.html
D third_party/blink/web_tests/external/wpt/css/css-scroll-snap/scroll-start/scroll-start-with-text-fragment-navigation-target.html
D third_party/blink/web_tests/external/wpt/css/css-scroll-snap/scroll-start/scroll-start-with-text-fragment-navigation.tentative.html
D third_party/blink/web_tests/external/wpt/css/css-scroll-snap/scroll-start/scroll-start-with-user-scroll.tentative.html
D third_party/blink/web_tests/external/wpt/css/css-scroll-snap/scroll-start/scroll-start.tentative.html
D third_party/blink/web_tests/external/wpt/css/css-scroll-snap/scroll-start/stash.py
M third_party/blink/web_tests/fast/css/getComputedStyle/computed-style-listing-expected.txt
M third_party/blink/web_tests/fast/css/getComputedStyle/computed-style-without-renderer-listing-expected.txt
M third_party/blink/web_tests/svg/css/getComputedStyle-listing-expected.txt
M third_party/blink/web_tests/webexposed/css-properties-as-js-properties-expected.txt
M third_party/blink/web_tests/webexposed/css-property-listing-expected.txt
M tools/metrics/histograms/metadata/blink/enums.xml

Change size: XL

Delta: 52 files changed, 13 insertions(+), 2115 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Robert Flack, +1 by David Awogbemila

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Blink W3C Test Autoroller (Gerrit)

unread,

5:29 PM (6 hours ago) 5:29 PM

to David Awogbemila, Chromium LUCI CQ, Robert Flack, Menard, Alexis, David Bokan, Chromium Metrics Reviews, chromium...@chromium.org, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, zol...@webkit.org

Message from Blink W3C Test Autoroller

The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/56042

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Reply all

Reply to author

Forward

Remove scroll-start [chromium/src : main]

David Awogbemila (Gerrit)

David Awogbemila added 1 comment

Related details

Robert Flack (Gerrit)

Robert Flack voted Code-Review+1

Related details

David Awogbemila (Gerrit)

David Awogbemila voted

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information

Blink W3C Test Autoroller (Gerrit)

Message from Blink W3C Test Autoroller

Related details