Add Blink.SVGImage UKM [chromium/src : main]
0 views
Skip to first unread message
Minoru Chikamune (Gerrit)
Jun 28, 2024, 2:22:46 AM (5 days ago) Jun 28
to Minoru Chikamune, Takashi Toyoshima, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org
Attention needed from Takashi Toyoshima
Minoru Chikamune voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Takashi Toyoshima
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Takashi Toyoshima (Gerrit)
Jun 28, 2024, 4:27:08 AM (5 days ago) Jun 28
to Minoru Chikamune, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org
Attention needed from Minoru Chikamune
Takashi Toyoshima voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Minoru Chikamune
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sun Yueru (Gerrit)
Jul 2, 2024, 10:20:45 PM (8 hours ago) Jul 2
to Minoru Chikamune, Takashi Toyoshima, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org
Attention needed from Minoru Chikamune
Sun Yueru voted and added 1 comment![]( "Open in Gerrit")
Votes added by Sun Yueru
| Code-Review | +1 |
1 comment
File tools/metrics/ukm/ukm.xml
Line 5468, Patchset 7 (Latest):
while loading the outermost main frame document.Sun Yueru . unresolved
nit: mention that custom sampling is applied in Document::FinishedParsing, otherwise any total count number would be misleading at analysis time.
Related details
Attention is currently required from:
- Minoru Chikamune
Submit Requirements:
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Minoru Chikamune (Gerrit)
Jul 2, 2024, 10:32:21 PM (8 hours ago) Jul 2
to Minoru Chikamune, Sun Yueru, Takashi Toyoshima, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org
Minoru Chikamune added 1 comment![]( "Open in Gerrit")
File tools/metrics/ukm/ukm.xml
nit: mention that custom sampling is applied in Document::FinishedParsing, otherwise any total count number would be misleading at analysis time.
Minoru Chikamune
Thank you. I updated the <summary>.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Minoru Chikamune (Gerrit)
3:03 AM (3 hours ago) 3:03 AM
to Minoru Chikamune, Sun Yueru, Takashi Toyoshima, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org
Minoru Chikamune voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
3:06 AM (3 hours ago) 3:06 AM
to Minoru Chikamune, Sun Yueru, Takashi Toyoshima, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
7 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: tools/metrics/ukm/ukm.xml
Insertions: 2, Deletions: 1.
@@ -5465,7 +5465,8 @@
<owner>chrome-...@google.com</owner>
<summary>
Metrics to measure the SVGImage::DataChanged() performance per document
- while loading the outermost main frame document.
+ while loading the outermost main frame document. This is recorded at the
+ frequency of 0.001.
</summary>
<metric name="Count">
<summary>
```
Change information
Commit message:
Add Blink.SVGImage UKM
This CL adds Blink.SVGImage UKM which records the following existing
histograms in UKM.
- Blink.Layout.SVGImage.Count.InOutermostMainFrame
- Blink.Layout.SVGImage.TotalTime.InOutermostMainFrame
[New UKM collection review]
https://docs.google.com/document/d/11G4IzG4ha22PnjGp1-gqWYSW53jxISFnV022YzVrzm8/
Bug: 336382906
Change-Id: Ibd9af3920347cb4d24ad0b835b3d4be432a771af
Reviewed-by: Takashi Toyoshima <toyo...@chromium.org>
Reviewed-by: Sun Yueru <yr...@chromium.org>
Commit-Queue: Minoru Chikamune <chik...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1322614}
Files:
- M third_party/blink/renderer/core/dom/document.cc
- M tools/metrics/ukm/ukm.xml
Change size: S
Delta: 2 files changed, 42 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Takashi Toyoshima, +1 by Sun Yueru
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages