Drop LABEL element from form-associated elements. (issue 2000423006 by tkent@chromium.org)

0 views
Skip to first unread message

tk...@chromium.org

unread,
May 26, 2016, 3:37:31 AM5/26/16
to kei...@chromium.org, blink-...@chromium.org, blink-rev...@chromium.org, chromium...@chromium.org, dglazko...@chromium.org, eric.c...@apple.com, feature-me...@chromium.org, f...@opera.com, gl...@chromium.org, kinuko...@chromium.org, mlamouri+w...@chromium.org, silv...@chromium.org, vcar...@chromium.org
Reviewers: keishi
CL: https://codereview.chromium.org/2000423006/

Message:
keishi, would you review this please?


Description:
Drop LABEL element from form-associated elements.

- Remove 'form' content attribute support from LABEL element
- 'form' IDL attribute returns the value of label.control.form.

Intent to implement and ship:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/QWyCpJjgfY8/TOxG9n-OAQAJ

BUG=607868


Base URL: https://chromium.googlesource.com/chromium/src.git@master

Affected files (+60, -244 lines):
D third_party/WebKit/LayoutTests/fast/dom/HTMLLabelElement/form/test1.html
D third_party/WebKit/LayoutTests/fast/dom/HTMLLabelElement/form/test1-expected.txt
D third_party/WebKit/LayoutTests/fast/dom/HTMLLabelElement/label-formAssociatedElement.html
D third_party/WebKit/LayoutTests/fast/dom/HTMLLabelElement/label-formAssociatedElement-expected.txt
M third_party/WebKit/LayoutTests/fast/forms/form-associated-element.html
M third_party/WebKit/LayoutTests/fast/forms/form-associated-element-expected.txt
M third_party/WebKit/LayoutTests/fast/forms/form-attribute.html
M third_party/WebKit/LayoutTests/fast/forms/form-attribute-expected.txt
M third_party/WebKit/LayoutTests/fast/forms/form-attribute-nonexistence-form-id.html
M third_party/WebKit/LayoutTests/fast/forms/form-attribute-nonexistence-form-id-expected.txt
M third_party/WebKit/LayoutTests/imported/wpt/html/semantics/forms/form-control-infrastructure/form-expected.txt
M third_party/WebKit/LayoutTests/imported/wpt/html/semantics/forms/the-label-element/label-attributes-expected.txt
M third_party/WebKit/Source/core/frame/UseCounter.h
M third_party/WebKit/Source/core/html/FormAssociatedElement.h
M third_party/WebKit/Source/core/html/FormAssociatedElement.cpp
M third_party/WebKit/Source/core/html/HTMLLabelElement.h
M third_party/WebKit/Source/core/html/HTMLLabelElement.cpp
M third_party/WebKit/Source/core/html/HTMLLabelElement.idl
M third_party/WebKit/Source/core/html/HTMLObjectElement.h
M third_party/WebKit/Source/core/html/HTMLTagNames.in
M third_party/WebKit/Source/core/html/LabelsNodeList.cpp
M third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp
M third_party/WebKit/Source/web/WebLabelElement.cpp


kei...@chromium.org

unread,
May 26, 2016, 3:43:04 AM5/26/16
to tk...@chromium.org, blink-...@chromium.org, blink-rev...@chromium.org, chromium...@chromium.org, dglazko...@chromium.org, eric.c...@apple.com, feature-me...@chromium.org, f...@opera.com, gl...@chromium.org, kinuko...@chromium.org, mlamouri+w...@chromium.org, silv...@chromium.org, vcar...@chromium.org

commit-bot@chromium.org via codereview.chromium.org

unread,
May 26, 2016, 4:25:34 AM5/26/16
to tk...@chromium.org, kei...@chromium.org, commi...@chromium.org, blink-...@chromium.org, blink-rev...@chromium.org, chromium...@chromium.org, dglazko...@chromium.org, eric.c...@apple.com, feature-me...@chromium.org, f...@opera.com, gl...@chromium.org, kinuko...@chromium.org, mlamouri+w...@chromium.org, silv...@chromium.org, vcar...@chromium.org

commit-bot@chromium.org via codereview.chromium.org

unread,
May 26, 2016, 4:30:37 AM5/26/16
to tk...@chromium.org, kei...@chromium.org, commi...@chromium.org, blink-...@chromium.org, blink-rev...@chromium.org, chromium...@chromium.org, dglazko...@chromium.org, eric.c...@apple.com, feature-me...@chromium.org, f...@opera.com, gl...@chromium.org, kinuko...@chromium.org, mlamouri+w...@chromium.org, silv...@chromium.org, vcar...@chromium.org
Committed patchset #1 (id:20001)

https://codereview.chromium.org/2000423006/

commit-bot@chromium.org via codereview.chromium.org

unread,
May 26, 2016, 4:32:12 AM5/26/16
to tk...@chromium.org, kei...@chromium.org, commi...@chromium.org, blink-...@chromium.org, blink-rev...@chromium.org, chromium...@chromium.org, dglazko...@chromium.org, eric.c...@apple.com, feature-me...@chromium.org, f...@opera.com, gl...@chromium.org, kinuko...@chromium.org, mlamouri+w...@chromium.org, silv...@chromium.org, vcar...@chromium.org
Patchset 1 (id:??) landed as
https://crrev.com/5e6e8b88aaedac1add6ae9fcea5f9d997f4b31be
Cr-Commit-Position: refs/heads/master@{#396149}

https://codereview.chromium.org/2000423006/
Reply all
Reply to author
Forward
0 new messages