Enable multicast in direct sockets [chromium/src : main]
0 views
Skip to first unread message
Vlad Krot (Gerrit)
Oct 29, 2025, 7:50:15 AM10/29/25
to Jeremy Roman, Chromium IPC Reviews, Andrew Rayskiy, Chromium LUCI CQ, chromium...@chromium.org, Simon Hangl, blink-...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, network-ser...@chromium.org, rmcelra...@chromium.org
Attention needed from Andrew Rayskiy, Chromium IPC Reviews and Jeremy Roman
Vlad Krot voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Andrew Rayskiy
- Chromium IPC Reviews
- Jeremy Roman
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
gwsq (Gerrit)
Oct 29, 2025, 7:53:41 AM10/29/25
to Vlad Krot, Chromium IPC Reviews, Mike West, Jeremy Roman, Andrew Rayskiy, Chromium LUCI CQ, chromium...@chromium.org, Simon Hangl, blink-...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, network-ser...@chromium.org, rmcelra...@chromium.org
Attention needed from Andrew Rayskiy, Jeremy Roman and Mike West
Message from gwsq![]( "Open in Gerrit")
From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: mk...@chromium.org
📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).
IPC reviewer(s): mk...@chromium.org
Reviewer source(s):
mk...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)
Related details
Attention is currently required from:
- Andrew Rayskiy
- Jeremy Roman
- Mike West
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andrew Rayskiy (Gerrit)
Oct 29, 2025, 8:02:50 AM10/29/25
to Vlad Krot, Chromium IPC Reviews, Mike West, Jeremy Roman, Chromium LUCI CQ, chromium...@chromium.org, Simon Hangl, blink-...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, network-ser...@chromium.org, rmcelra...@chromium.org
Attention needed from Jeremy Roman, Mike West and Vlad Krot
Andrew Rayskiy voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Jeremy Roman
- Mike West
- Vlad Krot
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jeremy Roman (Gerrit)
Oct 29, 2025, 9:53:53 AM10/29/25
to Vlad Krot, Andrew Rayskiy, Chromium IPC Reviews, Mike West, Jeremy Roman, Chromium LUCI CQ, chromium...@chromium.org, Simon Hangl, blink-...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, network-ser...@chromium.org, rmcelra...@chromium.org
Attention needed from Mike West and Vlad Krot
Jeremy Roman added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/platform/runtime_enabled_features.json5
Line 3367, Patchset 3 (Latest):
public: true,Jeremy Roman . unresolved
Why set it to `public`? `status: "stable"` is sufficient to launch it, and `public` just causes us to generate a function on `WebRuntimeFeatures`, which isn't used anywhere here.
Related details
Attention is currently required from:
- Mike West
- Vlad Krot
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mike West (Gerrit)
Oct 30, 2025, 3:36:38 AM10/30/25
to Vlad Krot, Andrew Rayskiy, Chromium IPC Reviews, Jeremy Roman, Chromium LUCI CQ, chromium...@chromium.org, Simon Hangl, blink-...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, network-ser...@chromium.org, rmcelra...@chromium.org
Attention needed from Vlad Krot
Mike West voted and added 1 comment![]( "Open in Gerrit")
Attention is currently required from:
- Vlad Krot
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vlad Krot (Gerrit)
Oct 30, 2025, 6:13:37 AM10/30/25
to Mike West, Andrew Rayskiy, Chromium IPC Reviews, Jeremy Roman, Chromium LUCI CQ, chromium...@chromium.org, Simon Hangl, blink-...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, network-ser...@chromium.org, rmcelra...@chromium.org
Attention needed from Jeremy Roman
Vlad Krot added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/platform/runtime_enabled_features.json5
Why set it to `public`? `status: "stable"` is sufficient to launch it, and `public` just causes us to generate a function on `WebRuntimeFeatures`, which isn't used anywhere here.
Attention is currently required from:
- Jeremy Roman
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andrew Rayskiy (Gerrit)
Oct 30, 2025, 9:25:15 AM10/30/25
to Vlad Krot, Mike West, Chromium IPC Reviews, Jeremy Roman, Chromium LUCI CQ, chromium...@chromium.org, Simon Hangl, blink-...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, network-ser...@chromium.org, rmcelra...@chromium.org
Attention needed from Jeremy Roman, Mike West and Vlad Krot
Andrew Rayskiy voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Jeremy Roman
- Mike West
- Vlad Krot
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vlad Krot (Gerrit)
Oct 30, 2025, 10:31:53 AM10/30/25
to Andrew Rayskiy, Mike West, Chromium IPC Reviews, Jeremy Roman, Chromium LUCI CQ, chromium...@chromium.org, Simon Hangl, blink-...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, network-ser...@chromium.org, rmcelra...@chromium.org
Attention needed from Jeremy Roman and Mike West
Vlad Krot voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Jeremy Roman
- Mike West
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Oct 30, 2025, 10:53:29 AM10/30/25
to Vlad Krot, Andrew Rayskiy, Mike West, Chromium IPC Reviews, Jeremy Roman, chromium...@chromium.org, Simon Hangl, blink-...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, network-ser...@chromium.org, rmcelra...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
6 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
Enable multicast in direct sockets
The launch was approved by all approvers -
https://launch.corp.google.com/launch/4421279
Chrome Entry was approved by owners -
https://chromestatus.com/feature/5073740211814400
Change-Id: I02511fca3b5955acccaa6d0586039abafe6e97af
Fixed: 398934282
Reviewed-by: Andrew Rayskiy <green...@google.com>
Commit-Queue: Vlad Krot <vk...@google.com>
Cr-Commit-Position: refs/heads/main@{#1537925}
Files:
- M chrome/browser/flag_descriptions.h
- M services/network/public/mojom/permissions_policy/permissions_policy_feature.mojom
- M third_party/blink/renderer/modules/direct_sockets/README.md
- M third_party/blink/renderer/platform/runtime_enabled_features.json5
- M third_party/blink/web_tests/wpt_internal/isolated-permissions-policy-stable/permissions_policy.https.html
Change size: S
Delta: 5 files changed, 8 insertions(+), 6 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Andrew Rayskiy
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages