[svg] Swap SVGAElement to the new HyperlinkElementUtils mixin. [chromium/src : main]

[tannal (Gerrit)]

Attention needed from Fredrik Söderquist, Frédéric Wang Nélar, Kent Tamura and Vinay Singh

tannal added 2 comments

Commit Message

Line 9, Patchset 6:This would adds origin, protocol etc attributes to svg a element

Frédéric Wang Nélar . resolved

Can you please add a link to the corresponding intent to ship/prototype?

tannal

The spec changes havn't been merged yet.
I will send a intent to prototype once it's merged

See https://github.com/w3c/svgwg/pull/1052

Frédéric Wang Nélar

OK can you please use this link in the commit message & code ?

tannal

Done

File third_party/blink/renderer/core/svg/svg_a_element.idl

Line 39, Patchset 8: // RuntimeEnabled extended attribute. (Ditto 'hreflang' and 'type'.)

Frédéric Wang Nélar . resolved

this should probably be a FIXME or TODO with a https://crbug.com reference

tannal

Done

Open in Gerrit

Related details

Attention is currently required from:

• Fredrik Söderquist
• Frédéric Wang Nélar
• Kent Tamura
• Vinay Singh

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I870e83d557a16e0d203260b21e44dbd88d55230a

Gerrit-Change-Number: 8015702

Gerrit-PatchSet: 10

Gerrit-Owner: tannal <mt...@igalia.com>

Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>

Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>

Gerrit-Reviewer: Vinay Singh <vinay...@microsoft.com>

Gerrit-CC: Dirk Schulze <dsch...@chromium.org>

Gerrit-CC: Frédéric Wang Nélar <fw...@igalia.com>

Gerrit-CC: Stephen Chenney <sche...@chromium.org>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-Attention: Vinay Singh <vinay...@microsoft.com>

Gerrit-Attention: Frédéric Wang Nélar <fw...@igalia.com>

Gerrit-Attention: Fredrik Söderquist <f...@opera.com>

Gerrit-Attention: Kent Tamura <tk...@chromium.org>

Gerrit-Comment-Date: Mon, 27 Jul 2026 04:27:10 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Frédéric Wang Nélar <fw...@igalia.com>

Comment-In-Reply-To: tannal <mt...@igalia.com>

[Kent Tamura (Gerrit)]

Attention needed from Fredrik Söderquist, Frédéric Wang Nélar, Vinay Singh and tannal

Kent Tamura added 3 comments

Commit Message

Line 9, Patchset 6:This would adds origin, protocol etc attributes to svg a element

Frédéric Wang Nélar . unresolved

Can you please add a link to the corresponding intent to ship/prototype?

tannal

The spec changes havn't been merged yet.
I will send a intent to prototype once it's merged

See https://github.com/w3c/svgwg/pull/1052

Frédéric Wang Nélar

OK can you please use this link in the commit message & code ?

tannal

Done

Kent Tamura

I will send a intent to prototype once it's merged

Please send an I2P before merging this.

File third_party/blink/web_tests/external/wpt/svg/linking/scripted/a-hyperlinkutils-getter-setter.html

Line 9, Patchset 10 (Latest):<script>

Kent Tamura . unresolved

nit: Both single quotes and double quotes are used in the script block. Please standardize on either of them.

File third_party/blink/web_tests/external/wpt/svg/linking/scripted/a-hyperlinkutils-getter.html

Line 18, Patchset 10 (Latest):<script>

Kent Tamura . unresolved

nit: Both single quotes and double quotes are used in the script block. Please standardize on either of them.

Open in Gerrit

Related details

Attention is currently required from:

• Fredrik Söderquist
• Frédéric Wang Nélar

• Vinay Singh
• tannal

Gerrit-Attention: tannal <mt...@igalia.com>

Gerrit-Comment-Date: Mon, 27 Jul 2026 04:46:19 +0000