Use WrapCrossThreadPersistent for callbacks in RTCPeerConnection [chromium/src : main]

0 views
Skip to first unread message

Tony Herre (Gerrit)

unread,
5:18 AM (4 hours ago) 5:18 AM
to Palak Agarwal, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org, video-networking...@google.com
Attention needed from Palak Agarwal

Tony Herre voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Palak Agarwal
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I2379ed85cc1dba90810e891b16387e4667b766ca
Gerrit-Change-Number: 7747791
Gerrit-PatchSet: 3
Gerrit-Owner: Tony Herre <top...@chromium.org>
Gerrit-Reviewer: Palak Agarwal <agp...@chromium.org>
Gerrit-Reviewer: Tony Herre <top...@chromium.org>
Gerrit-Attention: Palak Agarwal <agp...@chromium.org>
Gerrit-Comment-Date: Mon, 13 Apr 2026 09:18:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Palak Agarwal (Gerrit)

unread,
6:23 AM (3 hours ago) 6:23 AM
to Tony Herre, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org, video-networking...@google.com
Attention needed from Tony Herre

Palak Agarwal voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Tony Herre
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I2379ed85cc1dba90810e891b16387e4667b766ca
    Gerrit-Change-Number: 7747791
    Gerrit-PatchSet: 3
    Gerrit-Owner: Tony Herre <top...@chromium.org>
    Gerrit-Reviewer: Palak Agarwal <agp...@chromium.org>
    Gerrit-Reviewer: Tony Herre <top...@chromium.org>
    Gerrit-Attention: Tony Herre <top...@chromium.org>
    Gerrit-Comment-Date: Mon, 13 Apr 2026 10:22:55 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    6:50 AM (3 hours ago) 6:50 AM
    to Tony Herre, Palak Agarwal, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org, video-networking...@google.com

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Use WrapCrossThreadPersistent for callbacks in RTCPeerConnection

    Switch to WrapCrossThreadPersistent for generateCertificate and getStats
    callbacks to ensure thread safety.
    Bug: 501424047
    Change-Id: I2379ed85cc1dba90810e891b16387e4667b766ca
    Reviewed-by: Palak Agarwal <agp...@chromium.org>
    Commit-Queue: Palak Agarwal <agp...@chromium.org>
    Auto-Submit: Tony Herre <top...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1613612}
    Files:
    • M third_party/blink/renderer/modules/peerconnection/rtc_certificate_generator.h
    • M third_party/blink/renderer/modules/peerconnection/rtc_peer_connection.cc
    • M third_party/blink/renderer/modules/peerconnection/rtc_peer_connection_handler.cc
    • M third_party/blink/renderer/modules/peerconnection/rtc_rtp_receiver.cc
    • M third_party/blink/renderer/modules/peerconnection/rtc_rtp_sender.cc
    • M third_party/blink/renderer/modules/peerconnection/rtc_rtp_sender_impl.cc
    • M third_party/blink/renderer/modules/peerconnection/test_webrtc_stats_report_obtainer.cc
    • M third_party/blink/renderer/platform/peerconnection/rtc_stats.h
    Change size: S
    Delta: 8 files changed, 24 insertions(+), 25 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Palak Agarwal
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I2379ed85cc1dba90810e891b16387e4667b766ca
    Gerrit-Change-Number: 7747791
    Gerrit-PatchSet: 4
    Gerrit-Owner: Tony Herre <top...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Palak Agarwal <agp...@chromium.org>
    Gerrit-Reviewer: Tony Herre <top...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages