Change PreserveDropEffect runtime config to test [chromium/src : refs/branch-heads/7444]

0 views

Skip to first unread message

Eain Chen (Gerrit)

unread,

5:52 PM (5 hours ago) 5:52 PM

to Olga Gerchikov, Gaston Rodriguez, Mustaq Ahmed, AyeAye, kinuko...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org

Attention needed from Gaston Rodriguez, Mustaq Ahmed and Olga Gerchikov

Eain Chen added 1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Eain Chen . resolved

Cherry-pick to M143, please review.

Open in Gerrit

Related details

Attention is currently required from:

Gaston Rodriguez
Mustaq Ahmed
Olga Gerchikov

Submit Requirements:

Code-Owners
Code-Review
Lint
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Olga Gerchikov (Gerrit)

unread,

6:04 PM (5 hours ago) 6:04 PM

to Eain Chen, Avi Drissman, AyeAye, Gaston Rodriguez, Mustaq Ahmed, kinuko...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org

Attention needed from Avi Drissman, Eain Chen, Gaston Rodriguez and Mustaq Ahmed

Olga Gerchikov added 1 comment

File chrome/browser/ui/views/drag_and_drop_interactive_uitest.cc

Line 792, Patchset 2 (Latest):

<<<<<<< HEAD   (c23b317caf715fe5f3d4d9d089c7caac8cba1d35 Roll Chrome Mac Arm PGO Profile)
           {features::kSideBySideDropTargetNudgeToFullMaxWidth.name, "0"}}}},
        {});
||||||| BASE   (f945caf1f5b9098a81fa151d1adf481d58aebe99 Disable ToolbarTabletTest)
           {features::kSideBySideDropTargetNudgeToFullMaxWidth.name, "0"}}}},
        {blink::features::kSupportOpeningDraggedLinksInSameTab});
=======
           {features::kSideBySideDropTargetNudgeToFullMaxWidth.name, "0"}}},
         {blink::features::kPreserveDropEffect, {}}},
        {blink::features::kSupportOpeningDraggedLinksInSameTab});
>>>>>>> CHANGE (285a1376506c0f179f5275943f9f32720f6eb60e Change PreserveDropEffect runtime config to test)

Olga Gerchikov . unresolved

Please fix the merge conflict.

Open in Gerrit

Related details

Attention is currently required from:

Avi Drissman
Eain Chen
Gaston Rodriguez
Mustaq Ahmed

Submit Requirements:

Code-Owners
Code-Review
Lint

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages