[text-emphasis] Split TextScaleType into two flags [chromium/src : main]
0 views
Skip to first unread message
Minseong Kim (Gerrit)
Sep 23, 2025, 6:09:11 PM (12 hours ago) Sep 23
to Kent Tamura, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Dirk Schulze, Fredrik Söderquist, Stephen Chenney, blink-revi...@chromium.org, blink-...@chromium.org, fmalit...@chromium.org, kouhe...@chromium.org, pdr+svgw...@chromium.org, zol...@webkit.org
Attention needed from Kent Tamura
Minseong Kim added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Kent Tamura
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kent Tamura (Gerrit)
Sep 23, 2025, 6:21:55 PM (12 hours ago) Sep 23
to Minseong Kim, Kent Tamura, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Dirk Schulze, Fredrik Söderquist, Stephen Chenney, blink-revi...@chromium.org, blink-...@chromium.org, fmalit...@chromium.org, kouhe...@chromium.org, pdr+svgw...@chromium.org, zol...@webkit.org
Attention needed from Minseong Kim
Kent Tamura voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Minseong Kim
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Minseong Kim (Gerrit)
Sep 23, 2025, 7:52:09 PM (10 hours ago) Sep 23
to Koji Ishii, Kent Tamura, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Dirk Schulze, Fredrik Söderquist, Stephen Chenney, blink-revi...@chromium.org, blink-...@chromium.org, fmalit...@chromium.org, kouhe...@chromium.org, pdr+svgw...@chromium.org, zol...@webkit.org
Attention needed from Koji Ishii
Minseong Kim added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Attention is currently required from:
- Koji Ishii
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Koji Ishii (Gerrit)
2:34 AM (3 hours ago) 2:34 AM
to Minseong Kim, Kent Tamura, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Dirk Schulze, Fredrik Söderquist, Stephen Chenney, blink-revi...@chromium.org, blink-...@chromium.org, fmalit...@chromium.org, kouhe...@chromium.org, pdr+svgw...@chromium.org, zol...@webkit.org
Attention needed from Minseong Kim
Koji Ishii voted and added 1 comment![]( "Open in Gerrit")
Votes added by Koji Ishii
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Minseong Kim
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Minseong Kim (Gerrit)
2:40 AM (3 hours ago) 2:40 AM
to Koji Ishii, Kent Tamura, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Dirk Schulze, Fredrik Söderquist, Stephen Chenney, blink-revi...@chromium.org, blink-...@chromium.org, fmalit...@chromium.org, kouhe...@chromium.org, pdr+svgw...@chromium.org, zol...@webkit.org
Minseong Kim voted and added 1 comment![]( "Open in Gerrit")
Votes added by Minseong Kim
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Minseong Kim . resolved
Thank you all for the reviews!
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Minseong Kim (Gerrit)
4:08 AM (2 hours ago) 4:08 AM
to Koji Ishii, Kent Tamura, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Dirk Schulze, Fredrik Söderquist, Stephen Chenney, blink-revi...@chromium.org, blink-...@chromium.org, fmalit...@chromium.org, kouhe...@chromium.org, pdr+svgw...@chromium.org, zol...@webkit.org
Minseong Kim voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Chromium LUCI CQ (Gerrit)
4:35 AM (1 hour ago) 4:35 AM
to Minseong Kim, Koji Ishii, Kent Tamura, AyeAye, chromium...@chromium.org, Dirk Schulze, Fredrik Söderquist, Stephen Chenney, blink-revi...@chromium.org, blink-...@chromium.org, fmalit...@chromium.org, kouhe...@chromium.org, pdr+svgw...@chromium.org, zol...@webkit.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[text-emphasis] Split TextScaleType into two flags
The fit-text feature and ruby+emphasis should work together within a
single FragmentItem. Therefore, we should split TextScaleType to support
placing emphasis marks outside ruby.
This CL has no behavior changes.
Bug: 442481227
Change-Id: I3cde30836d3b61a2c2ef2bf7c71f64a7635cadd3
Reviewed-by: Koji Ishii <ko...@chromium.org>
Commit-Queue: Minseong Kim <jja0...@gmail.com>
Reviewed-by: Kent Tamura <tk...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1519831}
Files:
- M third_party/blink/renderer/core/layout/inline/fragment_item.cc
- M third_party/blink/renderer/core/layout/inline/fragment_item.h
- M third_party/blink/renderer/core/layout/svg/svg_text_layout_algorithm.cc
Change size: S
Delta: 3 files changed, 14 insertions(+), 21 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Kent Tamura, +1 by Koji Ishii
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages