Templatize visitor arguments for TraceTrait mark and trace methods. (issue 807003004 by kouhei@chromium.org)

0 views
Skip to first unread message

kou...@chromium.org

unread,
Dec 16, 2014, 10:20:43 PM12/16/14
to oilpan-...@chromium.org, blink-...@chromium.org, ag...@chromium.org, oilpan-...@chromium.org, har...@chromium.org, blink-re...@chromium.org, aandre...@chromium.org, kouhe...@chromium.org, mikhail.p...@intel.com
Reviewers: oilpan-reviews,

Message:
PTAL. This is split from https://codereview.chromium.org/803443002/

Description:
Templatize visitor arguments for TraceTrait mark and trace methods.

This CL replaces Visitor* in TraceTrait<T>::{mark,trace} methods arguments
to template parameter VisitorDispatcher.

This is to prepare for InlinedGlobalMarkingVisitor implementaion, so that
those methods can also be used to dispatch
TraceTrait<T>::mark(InlinedGlobalMarkingVisitor) in addition to the current
TraceTrait<T>::mark(Visitor*) usage.

BUG=420515

Please review this at https://codereview.chromium.org/807003004/

Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Affected files (+79, -41 lines):
M Source/platform/heap/Heap.h
M Source/platform/heap/Visitor.h
M Source/wtf/Deque.h
M Source/wtf/HashTable.h
M Source/wtf/Vector.h


har...@chromium.org

unread,
Dec 16, 2014, 10:43:15 PM12/16/14
to kou...@chromium.org, oilpan-...@chromium.org, blink-...@chromium.org, ag...@chromium.org, oilpan-...@chromium.org, blink-re...@chromium.org, aandre...@chromium.org, kouhe...@chromium.org, mikhail.p...@intel.com
LGTM


https://codereview.chromium.org/807003004/

kou...@chromium.org

unread,
Dec 16, 2014, 11:38:36 PM12/16/14
to oilpan-...@chromium.org, erik....@gmail.com, blink-...@chromium.org, ag...@chromium.org, oilpan-...@chromium.org, blink-re...@chromium.org, aandre...@chromium.org, kouhe...@chromium.org, mikhail.p...@intel.com
erik.corry: Would you take a look?


https://codereview.chromium.org/807003004/
Reply all
Reply to author
Forward
0 new messages