Fix crash when `text-transform` change the text length [chromium/src : main]
1 view
Skip to first unread message
Koji Ishii (Gerrit)
May 22, 2026, 1:01:00 AM (14 days ago) May 22
to Kent Tamura, Chromium LUCI CQ, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, jmedle...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org, blink-re...@chromium.org, blink-revie...@chromium.org, kinuko...@chromium.org
Attention needed from Kent Tamura
Koji Ishii voted and added 1 comment![]( "Open in Gerrit")
Votes added by Koji Ishii
| Auto-Submit | +1 |
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Kent Tamura
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kent Tamura (Gerrit)
May 22, 2026, 1:05:39 AM (14 days ago) May 22
to Koji Ishii, Kent Tamura, Chromium LUCI CQ, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, jmedle...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org, blink-re...@chromium.org, blink-revie...@chromium.org, kinuko...@chromium.org
Attention needed from Koji Ishii
Kent Tamura voted![]( "Open in Gerrit")
Attention is currently required from:
- Koji Ishii
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
May 22, 2026, 1:16:22 AM (14 days ago) May 22
to Koji Ishii, Kent Tamura, Chromium LUCI CQ, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, jmedle...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org, blink-re...@chromium.org, blink-revie...@chromium.org, kinuko...@chromium.org
Attention needed from Koji Ishii
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/60099.
When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.
WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process
Related details
Attention is currently required from:
- Koji Ishii
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
May 22, 2026, 1:51:42 AM (14 days ago) May 22
to Koji Ishii, Blink W3C Test Autoroller, Kent Tamura, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, jmedle...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org, blink-re...@chromium.org, blink-revie...@chromium.org, kinuko...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Fix crash when `text-transform` change the text length
When the `text-transform` property change the text length,
`InlineNode` simply adjusted the text length for `first-line`.
This could cause crashes in `LineBreaker::HandleControlItem`
because `InlineItem` and text could be out of sync.
As Blink now supports `TextOffsetMap` in `ApplyTextTransform`,
this patch supports adjusting `InlineItem` and
`InlineItemSegments` using the `TextOffsetMap`.
Fixed: 449295641
Change-Id: I8317e202a1007c6c604187134e31e4ebbcd6d136
Commit-Queue: Koji Ishii <ko...@chromium.org>
Commit-Queue: Kent Tamura <tk...@chromium.org>
Auto-Submit: Koji Ishii <ko...@chromium.org>
Reviewed-by: Kent Tamura <tk...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1634730}
Files:
- M third_party/blink/renderer/core/layout/inline/inline_item_segment.cc
- M third_party/blink/renderer/core/layout/inline/inline_item_segment.h
- M third_party/blink/renderer/core/layout/inline/inline_node.cc
- M third_party/blink/renderer/platform/runtime_enabled_features.json5
- M third_party/blink/renderer/platform/wtf/text/text_offset_map.cc
- M third_party/blink/renderer/platform/wtf/text/text_offset_map.h
- M third_party/blink/renderer/platform/wtf/text/text_offset_map_test.cc
- A third_party/blink/web_tests/external/wpt/css/css-text/text-transform/crashtests/first-line-text-transform-crash.html
Change size: M
Delta: 8 files changed, 91 insertions(+), 9 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Kent Tamura
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
May 22, 2026, 3:17:28 AM (13 days ago) May 22
to Chromium LUCI CQ, Koji Ishii, Kent Tamura, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, jmedle...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org, blink-re...@chromium.org, blink-revie...@chromium.org, kinuko...@chromium.org
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/60099
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages