WTF: Enable -Wshorten-64-to-32 and -Wtautological-unsigned-zero-compare [chromium/src : main]
1 view
Skip to first unread message
Kent Tamura (Gerrit)
May 26, 2026, 3:48:35 AM (9 days ago) May 26
to Kent Tamura, Fredrik Söderquist, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, mac-r...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Fredrik Söderquist
Kent Tamura voted and added 1 comment![]( "Open in Gerrit")
Votes added by Kent Tamura
| Auto-Submit | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Fredrik Söderquist
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Fredrik Söderquist (Gerrit)
May 26, 2026, 4:18:49 AM (9 days ago) May 26
to Kent Tamura, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, mac-r...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Kent Tamura
Fredrik Söderquist voted![]( "Open in Gerrit")
Attention is currently required from:
- Kent Tamura
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
May 26, 2026, 4:40:23 AM (9 days ago) May 26
to Kent Tamura, Fredrik Söderquist, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, mac-r...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
WTF: Enable -Wshorten-64-to-32 and -Wtautological-unsigned-zero-compare
* StringUtf8Adaptor::size()
It should be `size_t` because it can be larger than the maximum value
of `wtf_size_t`.
Bug: 514751964
Change-Id: Ie424850df9346273f3c46831a7ba2ca2a3ff418d
Reviewed-by: Fredrik Söderquist <f...@opera.com>
Commit-Queue: Fredrik Söderquist <f...@opera.com>
Auto-Submit: Kent Tamura <tk...@chromium.org>
Commit-Queue: Kent Tamura <tk...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1635983}
Files:
- M third_party/blink/renderer/BUILD.gn
- M third_party/blink/renderer/platform/wtf/BUILD.gn
- M third_party/blink/renderer/platform/wtf/shared_buffer_test.cc
- M third_party/blink/renderer/platform/wtf/text/base64.cc
- M third_party/blink/renderer/platform/wtf/text/code_point_iterator.h
- M third_party/blink/renderer/platform/wtf/text/line_ending.cc
- M third_party/blink/renderer/platform/wtf/text/string_apple.mm
- M third_party/blink/renderer/platform/wtf/text/string_impl.cc
- M third_party/blink/renderer/platform/wtf/text/string_utf8_adaptor.h
- M third_party/blink/renderer/platform/wtf/text/text_position.cc
- M third_party/blink/renderer/platform/wtf/vector.h
Change size: M
Delta: 11 files changed, 38 insertions(+), 15 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Fredrik Söderquist
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages