Revert "Enable heap_vector_active_iterator_checks as an experiment" [chromium/src : main]
1 view
Skip to first unread message
Michael Wilson (Gerrit)
Jun 1, 2026, 3:51:59 PM (3 days ago) Jun 1
to luci-bi...@appspot.gserviceaccount.com, Rick Byers, android-bu...@system.gserviceaccount.com, rubber-...@appspot.gserviceaccount.com, Chromium LUCI CQ, Keishi Hattori, Kent Tamura, chromium...@chromium.org, kinuko...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, mjwi...@google.com, n...@google.com
Attention needed from Keishi Hattori, Kent Tamura and Rick Byers
Michael Wilson added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Michael Wilson . resolved
Rick, could you please give owner approval? I am a gardener today but we don't have owner override for some reason.
Related details
Attention is currently required from:
- Keishi Hattori
- Kent Tamura
- Rick Byers
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andrew Grieve (Gerrit)
Jun 1, 2026, 4:00:53 PM (3 days ago) Jun 1
to luci-bi...@appspot.gserviceaccount.com, Andrew Grieve, Rick Byers, android-bu...@system.gserviceaccount.com, rubber-...@appspot.gserviceaccount.com, Chromium LUCI CQ, Keishi Hattori, Kent Tamura, chromium...@chromium.org, kinuko...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, mjwi...@google.com, n...@google.com
Attention needed from Keishi Hattori, Kent Tamura and Rick Byers
Andrew Grieve voted![]( "Open in Gerrit")
| Code-Review | +1 |
| Owners-Override | +1 |
Related details
Attention is currently required from:
- Keishi Hattori
- Kent Tamura
- Rick Byers
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nicolás Peña (Gerrit)
Jun 1, 2026, 4:01:15 PM (3 days ago) Jun 1
to luci-bi...@appspot.gserviceaccount.com, Andrew Grieve, Rick Byers, android-bu...@system.gserviceaccount.com, rubber-...@appspot.gserviceaccount.com, Chromium LUCI CQ, Keishi Hattori, Kent Tamura, chromium...@chromium.org, kinuko...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, mjwi...@google.com, n...@google.com
Attention needed from Keishi Hattori, Kent Tamura and Rick Byers
Nicolás Peña voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Keishi Hattori
- Kent Tamura
- Rick Byers
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jun 1, 2026, 4:01:37 PM (3 days ago) Jun 1
to luci-bi...@appspot.gserviceaccount.com, Nicolás Peña, Andrew Grieve, Rick Byers, android-bu...@system.gserviceaccount.com, rubber-...@appspot.gserviceaccount.com, Keishi Hattori, Kent Tamura, chromium...@chromium.org, kinuko...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, mjwi...@google.com, n...@google.com
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Revert "Enable heap_vector_active_iterator_checks as an experiment"
This reverts commit 59cceba961ea5fff337889fbb6730b7c2a9246a1.
Reason for revert:
LUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/5740833119666176
Sample build with failed test: https://ci.chromium.org/b/8680176184253645601
Affected test(s):
[://\:blink_web_tests!webtest::editing/execCommand#remove-format-multiple-elements.html](https://ci.chromium.org/ui/test/chromium/:%2F%2F%5C:blink_web_tests%21webtest::editing%2FexecCommand%23remove-format-multiple-elements.html?q=VHash%3A84aabcc7a0a0b25d)
[://\:blink_web_tests!webtest::fast/block/float#float-not-removed-from-pre-block.html](https://ci.chromium.org/ui/test/chromium/:%2F%2F%5C:blink_web_tests%21webtest::fast%2Fblock%2Ffloat%23float-not-removed-from-pre-block.html?q=VHash%3A84aabcc7a0a0b25d)
[://\:blink_web_tests!webtest::fast/clip#overflow-border-radius-composited-parent.html](https://ci.chromium.org/ui/test/chromium/:%2F%2F%5C:blink_web_tests%21webtest::fast%2Fclip%23overflow-border-radius-composited-parent.html?q=VHash%3A84aabcc7a0a0b25d)
[://\:blink_web_tests!webtest::fast/clip#overflow-border-radius-composited.html](https://ci.chromium.org/ui/test/chromium/:%2F%2F%5C:blink_web_tests%21webtest::fast%2Fclip%23overflow-border-radius-composited.html?q=VHash%3A84aabcc7a0a0b25d)
[://\:blink_web_tests!webtest::fast/css#content-property-quote-types.html](https://ci.chromium.org/ui/test/chromium/:%2F%2F%5C:blink_web_tests%21webtest::fast%2Fcss%23content-property-quote-types.html?q=VHash%3A84aabcc7a0a0b25d)
and 14 more ...
If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Ftest-analysis%2Fb%2F5740833119666176&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F7875848&type=BUG
Original change's description:
> Enable heap_vector_active_iterator_checks as an experiment
>
> Enable enable_heap_vector_active_iterator_checks by default as an
> experiment to get performance numbers and detect realloc while iterating issues in the wild.
>
> This will be reverted within a day.
>
> Design doc: https://docs.google.com/document/d/1xKOsdXdgnsORfUyA3CBAtUK3tIka50KBFF1lei8P9jA/edit?tab=t.0#heading=h.c0uts5ftkk58
>
> Bug: 501112189
> Change-Id: Ifd0e9ed8235665549cc8041e43297364830e68d6
> Binary-Size: Enables experimental security feature.
> Fuchsia-Binary-Size: Enables experimental security feature.
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7875848
> Reviewed-by: Kent Tamura <tk...@chromium.org>
> Commit-Queue: Keishi Hattori <kei...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1639493}
>
Bug: 501112189
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: Icdcb4a99abd7dd07cb800e2c158acf76a75f3efe
Commit-Queue: Nicolás Peña <n...@chromium.org>
Owners-Override: Andrew Grieve <agr...@chromium.org>
Reviewed-by: Andrew Grieve <agr...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1639605}
Files:
- M third_party/blink/renderer/platform/wtf/BUILD.gn
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Andrew Grieve, Bot-Commit+1 by rubber-...@appspot.gserviceaccount.com
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages