Enable heap_vector_active_iterator_checks as an experiment [chromium/src : main]

1 view
Skip to first unread message

Keishi Hattori (Gerrit)

unread,
May 31, 2026, 5:51:28 PM (4 days ago) May 31
to Kent Tamura, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Kent Tamura

Keishi Hattori added 1 comment

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Keishi Hattori . resolved

PTAL

Open in Gerrit

Related details

Attention is currently required from:
  • Kent Tamura
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ifd0e9ed8235665549cc8041e43297364830e68d6
Gerrit-Change-Number: 7875848
Gerrit-PatchSet: 4
Gerrit-Owner: Keishi Hattori <kei...@chromium.org>
Gerrit-Reviewer: Keishi Hattori <kei...@chromium.org>
Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
Gerrit-Attention: Kent Tamura <tk...@chromium.org>
Gerrit-Comment-Date: Sun, 31 May 2026 21:51:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Kent Tamura (Gerrit)

unread,
May 31, 2026, 7:02:06 PM (4 days ago) May 31
to Keishi Hattori, Kent Tamura, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Keishi Hattori

Kent Tamura voted and added 1 comment

Votes added by Kent Tamura

Code-Review+1

1 comment

Commit Message
Line 12, Patchset 4 (Latest):This will be reverted within a day.
Kent Tamura . resolved

Ack

Open in Gerrit

Related details

Attention is currently required from:
  • Keishi Hattori
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ifd0e9ed8235665549cc8041e43297364830e68d6
    Gerrit-Change-Number: 7875848
    Gerrit-PatchSet: 4
    Gerrit-Owner: Keishi Hattori <kei...@chromium.org>
    Gerrit-Reviewer: Keishi Hattori <kei...@chromium.org>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    Gerrit-Attention: Keishi Hattori <kei...@chromium.org>
    Gerrit-Comment-Date: Sun, 31 May 2026 23:01:32 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Keishi Hattori (Gerrit)

    unread,
    May 31, 2026, 7:14:18 PM (4 days ago) May 31
    to Kent Tamura, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org

    Keishi Hattori voted

    Code-Review+1
    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ifd0e9ed8235665549cc8041e43297364830e68d6
    Gerrit-Change-Number: 7875848
    Gerrit-PatchSet: 4
    Gerrit-Owner: Keishi Hattori <kei...@chromium.org>
    Gerrit-Reviewer: Keishi Hattori <kei...@chromium.org>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    Gerrit-Comment-Date: Sun, 31 May 2026 23:13:45 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Keishi Hattori (Gerrit)

    unread,
    Jun 1, 2026, 3:36:59 AM (3 days ago) Jun 1
    to Kent Tamura, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org

    Keishi Hattori voted

    Code-Review+0
    Commit-Queue+1
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ifd0e9ed8235665549cc8041e43297364830e68d6
    Gerrit-Change-Number: 7875848
    Gerrit-PatchSet: 5
    Gerrit-Owner: Keishi Hattori <kei...@chromium.org>
    Gerrit-Reviewer: Keishi Hattori <kei...@chromium.org>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    Gerrit-Comment-Date: Mon, 01 Jun 2026 07:36:30 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Keishi Hattori (Gerrit)

    unread,
    Jun 1, 2026, 12:59:47 PM (3 days ago) Jun 1
    to Kent Tamura, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org

    Keishi Hattori voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ifd0e9ed8235665549cc8041e43297364830e68d6
    Gerrit-Change-Number: 7875848
    Gerrit-PatchSet: 5
    Gerrit-Owner: Keishi Hattori <kei...@chromium.org>
    Gerrit-Reviewer: Keishi Hattori <kei...@chromium.org>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    Gerrit-Comment-Date: Mon, 01 Jun 2026 16:59:12 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Keishi Hattori (Gerrit)

    unread,
    Jun 1, 2026, 1:00:34 PM (3 days ago) Jun 1
    to Kent Tamura, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org

    Keishi Hattori voted Commit-Queue+0

    Commit-Queue+0
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ifd0e9ed8235665549cc8041e43297364830e68d6
    Gerrit-Change-Number: 7875848
    Gerrit-PatchSet: 6
    Gerrit-Owner: Keishi Hattori <kei...@chromium.org>
    Gerrit-Reviewer: Keishi Hattori <kei...@chromium.org>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    Gerrit-Comment-Date: Mon, 01 Jun 2026 17:00:03 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Keishi Hattori (Gerrit)

    unread,
    Jun 1, 2026, 1:00:53 PM (3 days ago) Jun 1
    to Kent Tamura, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org

    Keishi Hattori voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ifd0e9ed8235665549cc8041e43297364830e68d6
    Gerrit-Change-Number: 7875848
    Gerrit-PatchSet: 6
    Gerrit-Owner: Keishi Hattori <kei...@chromium.org>
    Gerrit-Reviewer: Keishi Hattori <kei...@chromium.org>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    Gerrit-Comment-Date: Mon, 01 Jun 2026 17:00:21 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jun 1, 2026, 1:24:53 PM (3 days ago) Jun 1
    to Keishi Hattori, Kent Tamura, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org

    Chromium LUCI CQ submitted the change

    Unreviewed changes

    4 is the latest approved patch-set.
    No files were changed between the latest approved patch-set and the submitted one.

    Change information

    Commit message:
    Enable heap_vector_active_iterator_checks as an experiment

    Enable enable_heap_vector_active_iterator_checks by default as an
    experiment to get performance numbers and detect realloc while iterating issues in the wild.


    This will be reverted within a day.

    Bug: 501112189
    Change-Id: Ifd0e9ed8235665549cc8041e43297364830e68d6
    Binary-Size: Enables experimental security feature.
    Fuchsia-Binary-Size: Enables experimental security feature.
    Reviewed-by: Kent Tamura <tk...@chromium.org>
    Commit-Queue: Keishi Hattori <kei...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1639493}
    Files:
    • M third_party/blink/renderer/platform/wtf/BUILD.gn
    Change size: XS
    Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Kent Tamura
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ifd0e9ed8235665549cc8041e43297364830e68d6
    Gerrit-Change-Number: 7875848
    Gerrit-PatchSet: 7
    Gerrit-Owner: Keishi Hattori <kei...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Keishi Hattori <kei...@chromium.org>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    open
    diffy
    satisfied_requirement

    luci-bisection@appspot.gserviceaccount.com (Gerrit)

    unread,
    Jun 1, 2026, 2:47:36 PM (3 days ago) Jun 1
    to Chromium LUCI CQ, Keishi Hattori, Kent Tamura, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: revert
    satisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages