WTF: Spanify BloomFilter [chromium/src : main]
0 views
Skip to first unread message
Kent Tamura (Gerrit)
Jan 7, 2026, 2:33:42 AM (2 days ago) Jan 7
to Kent Tamura, Fredrik Söderquist, chrom...@appspot.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Fredrik Söderquist
Kent Tamura voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Fredrik Söderquist
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Fredrik Söderquist (Gerrit)
Jan 7, 2026, 4:54:09 AM (2 days ago) Jan 7
to Kent Tamura, chrom...@appspot.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Kent Tamura
Fredrik Söderquist added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/platform/wtf/bloom_filter.h
Line 105, Patchset 3 (Latest):
std::ranges::fill(base::as_writable_byte_span(bit_array_), 0);Fredrik Söderquist . unresolved
Wouldn't this work equally well on just the `bit_array_` itself? (i.e `fill()`ing `BitArrayUnit`s; the APK diff suggests that this ends up emitting constrained iterators - which seems like it would be possible to avoid here; `std::array::fill` might also be an option)
Related details
Attention is currently required from:
- Kent Tamura
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
Jan 7, 2026, 7:30:53 PM (2 days ago) Jan 7
to Kent Tamura, Fredrik Söderquist, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Kent Tamura
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job mac-m1_mini_2020-perf-pgo/speedometer3 complete.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/157cdcc3b10000
Related details
Attention is currently required from:
- Kent Tamura
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kent Tamura (Gerrit)
Jan 7, 2026, 7:36:29 PM (2 days ago) Jan 7
to Kent Tamura, Fredrik Söderquist, chrom...@appspot.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Fredrik Söderquist
Kent Tamura voted and added 1 comment![]( "Open in Gerrit")
Votes added by Kent Tamura
| Auto-Submit | +1 |
1 comment
File third_party/blink/renderer/platform/wtf/bloom_filter.h
Line 105, Patchset 3:
std::ranges::fill(base::as_writable_byte_span(bit_array_), 0);Fredrik Söderquist . resolved
Wouldn't this work equally well on just the `bit_array_` itself? (i.e `fill()`ing `BitArrayUnit`s; the APK diff suggests that this ends up emitting constrained iterators - which seems like it would be possible to avoid here; `std::array::fill` might also be an option)
Kent Tamura
`std::ranges::fill(bit_array_, 0)` worked well, and it didn't increase the binary size. Thanks!
Related details
Attention is currently required from:
- Fredrik Söderquist
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Fredrik Söderquist (Gerrit)
Jan 8, 2026, 4:48:25 AM (yesterday) Jan 8
to Kent Tamura, chrom...@appspot.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Kent Tamura
Fredrik Söderquist voted and added 1 comment![]( "Open in Gerrit")
Votes added by Fredrik Söderquist
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
File third_party/blink/renderer/platform/wtf/bloom_filter.h
Line 105, Patchset 3:
std::ranges::fill(base::as_writable_byte_span(bit_array_), 0);Fredrik Söderquist . resolved
Kent TamuraWouldn't this work equally well on just the `bit_array_` itself? (i.e `fill()`ing `BitArrayUnit`s; the APK diff suggests that this ends up emitting constrained iterators - which seems like it would be possible to avoid here; `std::array::fill` might also be an option)
`std::ranges::fill(bit_array_, 0)` worked well, and it didn't increase the binary size. Thanks!
Attention is currently required from:
- Kent Tamura
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jan 8, 2026, 4:51:04 AM (yesterday) Jan 8
to Kent Tamura, Fredrik Söderquist, chrom...@appspot.gserviceaccount.com, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
WTF: Spanify BloomFilter
Use std::array instead of a raw array.
Speedometer3 performance with this CL looks neutral.
https://pinpoint-dot-chromeperf.appspot.com/job/157cdcc3b10000
Bug: 451652367
Change-Id: I7d7757e6d4b4f267f73a97bd754552965f79ceeb
Reviewed-by: Fredrik Söderquist <f...@opera.com>
Auto-Submit: Kent Tamura <tk...@chromium.org>
Commit-Queue: Fredrik Söderquist <f...@opera.com>
Cr-Commit-Position: refs/heads/main@{#1566158}
Files:
- M third_party/blink/renderer/platform/wtf/bloom_filter.h
Change size: S
Delta: 1 file changed, 9 insertions(+), 14 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Fredrik Söderquist
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages