GCC: Add check for __has_feature support in blink::IsOnStack() [chromium/src : main]

1 view
Skip to first unread message

Ivan Pavlotsky (Gerrit)

unread,
May 29, 2026, 2:04:22 AM (7 days ago) May 29
to Anton Bikineev, Michael Lippautz, Ivan Murashov, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Anton Bikineev and Michael Lippautz

Ivan Pavlotsky voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Anton Bikineev
  • Michael Lippautz
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie206f3af42cbd2d1417bbd4b6568fd77077355be
Gerrit-Change-Number: 7882784
Gerrit-PatchSet: 1
Gerrit-Owner: Ivan Pavlotsky <ivan.pa...@lge.com>
Gerrit-Reviewer: Anton Bikineev <biki...@chromium.org>
Gerrit-Reviewer: Ivan Pavlotsky <ivan.pa...@lge.com>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
Gerrit-CC: Ivan Murashov <ivan.m...@lge.com>
Gerrit-Attention: Michael Lippautz <mlip...@chromium.org>
Gerrit-Attention: Anton Bikineev <biki...@chromium.org>
Gerrit-Comment-Date: Fri, 29 May 2026 06:03:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Anton Bikineev (Gerrit)

unread,
May 29, 2026, 7:30:45 AM (6 days ago) May 29
to Ivan Pavlotsky, Chromium LUCI CQ, Michael Lippautz, Ivan Murashov, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Ivan Pavlotsky and Michael Lippautz

Anton Bikineev voted and added 1 comment

Votes added by Anton Bikineev

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Anton Bikineev . resolved

lgtm, thanks

Open in Gerrit

Related details

Attention is currently required from:
  • Ivan Pavlotsky
  • Michael Lippautz
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie206f3af42cbd2d1417bbd4b6568fd77077355be
Gerrit-Change-Number: 7882784
Gerrit-PatchSet: 1
Gerrit-Owner: Ivan Pavlotsky <ivan.pa...@lge.com>
Gerrit-Reviewer: Anton Bikineev <biki...@chromium.org>
Gerrit-Reviewer: Ivan Pavlotsky <ivan.pa...@lge.com>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
Gerrit-CC: Ivan Murashov <ivan.m...@lge.com>
Gerrit-Attention: Michael Lippautz <mlip...@chromium.org>
Gerrit-Attention: Ivan Pavlotsky <ivan.pa...@lge.com>
Gerrit-Comment-Date: Fri, 29 May 2026 11:30:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages