WTF: Fix 64-bit truncation issues in text codec code [chromium/src : main]

1 view
Skip to first unread message

Kent Tamura (Gerrit)

unread,
May 21, 2026, 3:56:21 AMMay 21
to Kent Tamura, Fredrik Söderquist, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, jshin...@chromium.org, kinuko...@chromium.org
Attention needed from Fredrik Söderquist

Kent Tamura voted and added 1 comment

Votes added by Kent Tamura

Auto-Submit+1
Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Kent Tamura . resolved

fs@, would you review this please?

Open in Gerrit

Related details

Attention is currently required from:
  • Fredrik Söderquist
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I432226a963b59f04bd83df8e54a2ed533b91658f
Gerrit-Change-Number: 7866101
Gerrit-PatchSet: 2
Gerrit-Owner: Kent Tamura <tk...@chromium.org>
Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
Gerrit-Attention: Fredrik Söderquist <f...@opera.com>
Gerrit-Comment-Date: Thu, 21 May 2026 07:55:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Fredrik Söderquist (Gerrit)

unread,
May 21, 2026, 4:19:48 AMMay 21
to Kent Tamura, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, jshin...@chromium.org, kinuko...@chromium.org
Attention needed from Kent Tamura

Fredrik Söderquist voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Kent Tamura
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I432226a963b59f04bd83df8e54a2ed533b91658f
    Gerrit-Change-Number: 7866101
    Gerrit-PatchSet: 2
    Gerrit-Owner: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    Gerrit-Attention: Kent Tamura <tk...@chromium.org>
    Gerrit-Comment-Date: Thu, 21 May 2026 08:19:36 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    May 21, 2026, 4:23:19 AMMay 21
    to Kent Tamura, Fredrik Söderquist, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, jshin...@chromium.org, kinuko...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    WTF: Fix 64-bit truncation issues in text codec code

    This is a preparation to enable -Wshorten-64-to-32 flag.

    * encoding_tables.cc:
      static_cast<> is enough because the result must be 1 or 2.
    Bug: 514751964
    Change-Id: I432226a963b59f04bd83df8e54a2ed533b91658f
    Auto-Submit: Kent Tamura <tk...@chromium.org>
    Commit-Queue: Fredrik Söderquist <f...@opera.com>
    Reviewed-by: Fredrik Söderquist <f...@opera.com>
    Cr-Commit-Position: refs/heads/main@{#1634111}
    Files:
    • M third_party/blink/renderer/platform/wtf/text/encoding_tables.cc
    • M third_party/blink/renderer/platform/wtf/text/text_codec_cjk.cc
    • M third_party/blink/renderer/platform/wtf/text/text_codec_user_defined.cc
    • M third_party/blink/renderer/platform/wtf/text/text_codec_utf16.cc
    Change size: S
    Delta: 4 files changed, 11 insertions(+), 5 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Fredrik Söderquist
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I432226a963b59f04bd83df8e54a2ed533b91658f
    Gerrit-Change-Number: 7866101
    Gerrit-PatchSet: 3
    Gerrit-Owner: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages