[wip] shrink Element [chromium/src : main]

0 views
Skip to first unread message

Steinar H Gunderson (Gerrit)

unread,
Jan 6, 2026, 9:15:30 AM (3 days ago) Jan 6
to Raphael Kubo da Costa, chromium...@chromium.org, Menard, Alexis, Kentaro Hara, blink-re...@chromium.org, apavlo...@chromium.org, kinuko...@chromium.org, blink-revie...@chromium.org, gavinp...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, loading-rev...@chromium.org, blink-re...@chromium.org

Steinar H Gunderson has uploaded the change for review

Commit message

[wip] shrink Element
Change-Id: Iaae6805f89da08f30ef963171a790cd01d235dfe

Change diff

diff --git a/third_party/blink/renderer/core/dom/element.h b/third_party/blink/renderer/core/dom/element.h
index 3c4cec0..a91a7d0 100644
--- a/third_party/blink/renderer/core/dom/element.h
+++ b/third_party/blink/renderer/core/dom/element.h
@@ -2587,7 +2587,7 @@
QualifiedName tag_name_;
// This `ComputedStyle` field is a hot accessed member. Keep uncompressed for
// performance reasons.
- subtle::UncompressedMember<const ComputedStyle> computed_style_;
+ Member<const ComputedStyle> computed_style_;
Member<ElementData> element_data_;

// A tiny Bloom filter for which attribute names and class names exist
@@ -2601,7 +2601,7 @@

// Do not add new members to Element without a good reason; prefer to
// add to ElementRareData unless it is performance-critical. Element
- // is 88 bytes on typical 64-bit platforms, and growing it can cause
+ // is 80 bytes on typical 64-bit platforms, and growing it can cause
// both memory and performance regressions if you are not careful.
};

Change information

Files:
  • M third_party/blink/renderer/core/dom/element.h
Change size: XS
Delta: 1 file changed, 2 insertions(+), 2 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iaae6805f89da08f30ef963171a790cd01d235dfe
Gerrit-Change-Number: 7403285
Gerrit-PatchSet: 1
Gerrit-Owner: Steinar H Gunderson <se...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,
Jan 6, 2026, 10:17:54 AM (3 days ago) Jan 6
to Steinar H Gunderson, Menard, Alexis, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, apavlo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org
Attention needed from Steinar H Gunderson

Message from chrom...@appspot.gserviceaccount.com

📍 Job mac-m1_mini_2020-perf/speedometer3 complete.

See results at: https://pinpoint-dot-chromeperf.appspot.com/job/16b84d5eb10000

Open in Gerrit

Related details

Attention is currently required from:
  • Steinar H Gunderson
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iaae6805f89da08f30ef963171a790cd01d235dfe
Gerrit-Change-Number: 7403285
Gerrit-PatchSet: 2
Gerrit-Owner: Steinar H Gunderson <se...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Steinar H Gunderson <se...@chromium.org>
Gerrit-Comment-Date: Tue, 06 Jan 2026 15:17:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,
Jan 6, 2026, 2:24:18 PM (3 days ago) Jan 6
to Steinar H Gunderson, Menard, Alexis, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, apavlo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org
Attention needed from Steinar H Gunderson

Message from chrom...@appspot.gserviceaccount.com

📍 Job mac-m1_mini_2020-perf/system_health.memory_desktop complete.

See results at: https://pinpoint-dot-chromeperf.appspot.com/job/16e55446b10000

Open in Gerrit

Related details

Attention is currently required from:
  • Steinar H Gunderson
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iaae6805f89da08f30ef963171a790cd01d235dfe
Gerrit-Change-Number: 7403285
Gerrit-PatchSet: 2
Gerrit-Owner: Steinar H Gunderson <se...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Steinar H Gunderson <se...@chromium.org>
Gerrit-Comment-Date: Tue, 06 Jan 2026 19:24:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,
Jan 6, 2026, 2:53:50 PM (3 days ago) Jan 6
to Steinar H Gunderson, Menard, Alexis, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, apavlo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org
Attention needed from Steinar H Gunderson

Message from chrom...@appspot.gserviceaccount.com

📍 Job mac-m1_mini_2020-perf/system_health.memory_desktop complete.

See results at: https://pinpoint-dot-chromeperf.appspot.com/job/107fe953b10000

Open in Gerrit

Related details

Attention is currently required from:
  • Steinar H Gunderson
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iaae6805f89da08f30ef963171a790cd01d235dfe
Gerrit-Change-Number: 7403285
Gerrit-PatchSet: 2
Gerrit-Owner: Steinar H Gunderson <se...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Steinar H Gunderson <se...@chromium.org>
Gerrit-Comment-Date: Tue, 06 Jan 2026 19:53:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,
Jan 6, 2026, 3:03:44 PM (3 days ago) Jan 6
to Steinar H Gunderson, Menard, Alexis, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, apavlo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org
Attention needed from Steinar H Gunderson

Message from chrom...@appspot.gserviceaccount.com

📍 Job mac-m1_mini_2020-perf/system_health.memory_desktop complete.

See results at: https://pinpoint-dot-chromeperf.appspot.com/job/16058786b10000

Open in Gerrit

Related details

Attention is currently required from:
  • Steinar H Gunderson
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iaae6805f89da08f30ef963171a790cd01d235dfe
Gerrit-Change-Number: 7403285
Gerrit-PatchSet: 2
Gerrit-Owner: Steinar H Gunderson <se...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Steinar H Gunderson <se...@chromium.org>
Gerrit-Comment-Date: Tue, 06 Jan 2026 20:03:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,
Jan 6, 2026, 3:13:59 PM (3 days ago) Jan 6
to Steinar H Gunderson, Menard, Alexis, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, apavlo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org
Attention needed from Steinar H Gunderson

Message from chrom...@appspot.gserviceaccount.com

📍 Job mac-m1_mini_2020-perf/system_health.memory_desktop complete.

See results at: https://pinpoint-dot-chromeperf.appspot.com/job/114c27a1b10000

Open in Gerrit

Related details

Attention is currently required from:
  • Steinar H Gunderson
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iaae6805f89da08f30ef963171a790cd01d235dfe
Gerrit-Change-Number: 7403285
Gerrit-PatchSet: 2
Gerrit-Owner: Steinar H Gunderson <se...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Steinar H Gunderson <se...@chromium.org>
Gerrit-Comment-Date: Tue, 06 Jan 2026 20:13:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages