Switch RawData to use Vector<uint8_t> [chromium/src : main]
1 view
Skip to first unread message
Fredrik Söderquist (Gerrit)
May 27, 2026, 9:12:50 AM (8 days ago) May 27
to Kent Tamura, Chromium IPC Reviews, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, ipc-securi...@chromium.org, enne...@chromium.org, blink-re...@chromium.org, edgesto...@microsoft.com, kinuko...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, dmurph+wa...@chromium.org
Attention needed from Chromium IPC Reviews and Kent Tamura
Fredrik Söderquist voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Chromium IPC Reviews
- Kent Tamura
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
gwsq (Gerrit)
May 27, 2026, 9:16:27 AM (8 days ago) May 27
to Fredrik Söderquist, Chromium IPC Reviews, Ken Buchanan, Kent Tamura, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, ipc-securi...@chromium.org, enne...@chromium.org, blink-re...@chromium.org, edgesto...@microsoft.com, kinuko...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, dmurph+wa...@chromium.org
Attention needed from Ken Buchanan and Kent Tamura
Message from gwsq![]( "Open in Gerrit")
From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: ke...@chromium.org
📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).
IPC reviewer(s): ke...@chromium.org
Reviewer source(s):
ke...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)
Related details
Attention is currently required from:
- Ken Buchanan
- Kent Tamura
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ken Buchanan (Gerrit)
May 27, 2026, 10:07:46 AM (8 days ago) May 27
to Fredrik Söderquist, Chromium IPC Reviews, Kent Tamura, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, ipc-securi...@chromium.org, enne...@chromium.org, blink-re...@chromium.org, edgesto...@microsoft.com, kinuko...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, dmurph+wa...@chromium.org
Attention needed from Fredrik Söderquist and Kent Tamura
Ken Buchanan voted and added 1 comment![]( "Open in Gerrit")
Votes added by Ken Buchanan
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Fredrik Söderquist
- Kent Tamura
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kent Tamura (Gerrit)
May 27, 2026, 7:17:05 PM (8 days ago) May 27
to Fredrik Söderquist, Kent Tamura, Ken Buchanan, Chromium IPC Reviews, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, ipc-securi...@chromium.org, enne...@chromium.org, blink-re...@chromium.org, edgesto...@microsoft.com, kinuko...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, dmurph+wa...@chromium.org
Attention needed from Fredrik Söderquist
Kent Tamura voted![]( "Open in Gerrit")
| Code-Review | +1 |
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Fredrik Söderquist
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
May 27, 2026, 7:36:33 PM (8 days ago) May 27
to Fredrik Söderquist, Kent Tamura, Ken Buchanan, Chromium IPC Reviews, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, android-bu...@system.gserviceaccount.com, ipc-securi...@chromium.org, enne...@chromium.org, blink-re...@chromium.org, edgesto...@microsoft.com, kinuko...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, dmurph+wa...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Switch RawData to use Vector<uint8_t>
This is mostly just renaming the type Vector<char> -> Vector<uint8_t> in
various places. The transitional RawDataBytes type is removed.
Bug: 516260747
Change-Id: I5a5b1d36efd33770fdb17fc8eaeb9263429085d7
Reviewed-by: Ken Buchanan <ke...@chromium.org>
Auto-Submit: Fredrik Söderquist <f...@opera.com>
Reviewed-by: Kent Tamura <tk...@chromium.org>
Commit-Queue: Kent Tamura <tk...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1637328}
Files:
- M third_party/blink/public/platform/web_thread_safe_data.h
- M third_party/blink/renderer/bindings/modules/v8/v8_binding_for_modules_test.cc
- M third_party/blink/renderer/core/exported/web_frame_serializer.cc
- M third_party/blink/renderer/core/exported/web_frame_serializer_test_helper.cc
- M third_party/blink/renderer/modules/font_access/font_metadata.cc
- M third_party/blink/renderer/modules/indexeddb/idb_request_loader.h
- M third_party/blink/renderer/modules/indexeddb/idb_request_test.cc
- M third_party/blink/renderer/modules/indexeddb/idb_test_helper.cc
- M third_party/blink/renderer/modules/indexeddb/idb_transaction_test.cc
- M third_party/blink/renderer/modules/indexeddb/idb_value.cc
- M third_party/blink/renderer/modules/indexeddb/idb_value.h
- M third_party/blink/renderer/modules/indexeddb/idb_value_wrapping.cc
- M third_party/blink/renderer/modules/indexeddb/idb_value_wrapping.h
- M third_party/blink/renderer/modules/indexeddb/idb_value_wrapping_test.cc
- M third_party/blink/renderer/modules/indexeddb/indexed_db_blink_mojom_traits_test.cc
- M third_party/blink/renderer/platform/blob/blob_bytes_provider.cc
- M third_party/blink/renderer/platform/blob/blob_bytes_provider.h
- M third_party/blink/renderer/platform/blob/blob_bytes_provider_test.cc
- M third_party/blink/renderer/platform/blob/blob_data.cc
- M third_party/blink/renderer/platform/blob/blob_data.h
- M third_party/blink/renderer/platform/exported/web_thread_safe_data.cc
- M third_party/blink/renderer/platform/wtf/text/line_ending.cc
- M third_party/blink/renderer/platform/wtf/text/line_ending.h
- M third_party/blink/renderer/platform/wtf/text/line_ending_test.cc
Change size: L
Delta: 24 files changed, 123 insertions(+), 147 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Ken Buchanan, +1 by Kent Tamura
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages