WTF: Introduce string_internal.h [chromium/src : main]

0 views
Skip to first unread message

Kent Tamura (Gerrit)

unread,
Jan 7, 2026, 7:38:00 PM (2 days ago) Jan 7
to Kent Tamura, Fredrik Söderquist, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Fredrik Söderquist

Kent Tamura voted and added 1 comment

Votes added by Kent Tamura

Auto-Submit+1
Commit-Queue+1

1 comment

Commit Message
Line 7, Patchset 4:WTF: Introduce string_common.h
Fredrik Söderquist . resolved

If it's intended as a point to share implementation for the different `String*` classes, then maybe it should be `string_internal.h` (or so) to more clearly signal that intent? WDYT?

Kent Tamura

It sounds reasonable. Done.

Open in Gerrit

Related details

Attention is currently required from:
  • Fredrik Söderquist
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I95d32f365787f14b1a80ebd9a8880e06c4008956
Gerrit-Change-Number: 7373688
Gerrit-PatchSet: 6
Gerrit-Owner: Kent Tamura <tk...@chromium.org>
Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
Gerrit-Attention: Fredrik Söderquist <f...@opera.com>
Gerrit-Comment-Date: Thu, 08 Jan 2026 00:37:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Fredrik Söderquist <f...@opera.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

Fredrik Söderquist (Gerrit)

unread,
Jan 8, 2026, 4:53:16 AM (yesterday) Jan 8
to Kent Tamura, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Kent Tamura

Fredrik Söderquist voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Kent Tamura
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I95d32f365787f14b1a80ebd9a8880e06c4008956
    Gerrit-Change-Number: 7373688
    Gerrit-PatchSet: 6
    Gerrit-Owner: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    Gerrit-Attention: Kent Tamura <tk...@chromium.org>
    Gerrit-Comment-Date: Thu, 08 Jan 2026 09:52:46 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jan 8, 2026, 4:55:54 AM (yesterday) Jan 8
    to Kent Tamura, Fredrik Söderquist, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    WTF: Introduce string_internal.h

    This CL updates StrippedMatchedCharactersRange() in string_impl.cc for
    base::span, and move it to string_internal.h.
    This is a preparation to add StringView::StripWhiteSpace().

    This CL has no behavior changes.
    Bug: 473854537
    Change-Id: I95d32f365787f14b1a80ebd9a8880e06c4008956
    Reviewed-by: Fredrik Söderquist <f...@opera.com>
    Commit-Queue: Fredrik Söderquist <f...@opera.com>
    Auto-Submit: Kent Tamura <tk...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1566160}
    Files:
    • M third_party/blink/renderer/platform/wtf/BUILD.gn
    • M third_party/blink/renderer/platform/wtf/text/string_impl.cc
    • A third_party/blink/renderer/platform/wtf/text/string_internal.h
    Change size: M
    Delta: 3 files changed, 88 insertions(+), 48 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Fredrik Söderquist
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I95d32f365787f14b1a80ebd9a8880e06c4008956
    Gerrit-Change-Number: 7373688
    Gerrit-PatchSet: 7
    Gerrit-Owner: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages