blink: Resolve 64-bit truncation issues in renderer/platform/ [chromium/src : main]

[Kent Tamura (Gerrit)]

Attention needed from Chromium IPC Reviews

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:

• Chromium IPC Reviews

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I0c3563fc9e66b8c64d84b52bdc6873ae1f375ea4

Gerrit-Change-Number: 7894986

Gerrit-PatchSet: 1

Gerrit-Owner: Kent Tamura <tk...@chromium.org>

Gerrit-Reviewer: Chromium IPC Reviews <chrome-ip...@google.com>

Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Dirk Schulze <dsch...@chromium.org>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Menard, Alexis <alexis...@intel.com>

Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Stephen Chenney <sche...@chromium.org>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Chromium IPC Reviews <chrome-ip...@google.com>

Gerrit-Comment-Date: Thu, 04 Jun 2026 00:55:12 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: No

[gwsq (Gerrit)]

Attention needed from Hidehiko Abe

Message from gwsq

From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: hide...@chromium.org

📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).

IPC reviewer(s): hide...@chromium.org

Reviewer source(s):
hide...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)

Open in Gerrit

Related details

Attention is currently required from:

• Hidehiko Abe

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I0c3563fc9e66b8c64d84b52bdc6873ae1f375ea4

Gerrit-Change-Number: 7894986

Gerrit-PatchSet: 1

Gerrit-Owner: Kent Tamura <tk...@chromium.org>

Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>

Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>

Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Dirk Schulze <dsch...@chromium.org>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Menard, Alexis <alexis...@intel.com>

Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Stephen Chenney <sche...@chromium.org>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: gwsq

Gerrit-Attention: Hidehiko Abe <hide...@chromium.org>

Gerrit-Comment-Date: Thu, 04 Jun 2026 01:00:30 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: No

[Kent Tamura (Gerrit)]

Attention needed from Hidehiko Abe

Kent Tamura added 1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Kent Tamura . resolved

chrome-ipc-reviews@, please take a look at third_party/blink/renderer/platform/storage/blink_storage_key_mojom_traits_test.cc .

Gerrit-Comment-Date: Thu, 04 Jun 2026 01:03:24 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Kent Tamura (Gerrit)]

Attention needed from Fredrik Söderquist and Hidehiko Abe

Kent Tamura added 1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Kent Tamura . resolved

fs@, would you review the whole CL please?

Open in Gerrit

Related details

Attention is currently required from:

• Fredrik Söderquist
• Hidehiko Abe

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I0c3563fc9e66b8c64d84b52bdc6873ae1f375ea4

Gerrit-Change-Number: 7894986

Gerrit-PatchSet: 1

Gerrit-Owner: Kent Tamura <tk...@chromium.org>

Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>

Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>

Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>

Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Dirk Schulze <dsch...@chromium.org>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Menard, Alexis <alexis...@intel.com>

Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Stephen Chenney <sche...@chromium.org>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: gwsq

Gerrit-Attention: Fredrik Söderquist <f...@opera.com>

Gerrit-Attention: Hidehiko Abe <hide...@chromium.org>

Gerrit-Comment-Date: Thu, 04 Jun 2026 06:50:30 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Hidehiko Abe (Gerrit)]

Attention needed from Fredrik Söderquist and Kent Tamura

Hidehiko Abe voted and added 2 comments

Votes added by Hidehiko Abe

Code-Review

+1

2 comments

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Hidehiko Abe . resolved

third_party/blink/renderer/platform/storage/blink_storage_key_mojom_traits_test.cc LGTM

File third_party/blink/renderer/platform/bindings/to_blink_string.cc

Line 55, Patchset 1 (Latest): v8_string->WriteV2(isolate, 0, base::checked_cast<uint32_t>(buffer.size()),

Hidehiko Abe . unresolved

clarification: so a crash on overflown (i.e. large bugger) is expected?

Open in Gerrit

Related details

Attention is currently required from:

• Fredrik Söderquist
• Kent Tamura

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I0c3563fc9e66b8c64d84b52bdc6873ae1f375ea4

Gerrit-Change-Number: 7894986

Gerrit-PatchSet: 1

Gerrit-Owner: Kent Tamura <tk...@chromium.org>

Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>

Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>

Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>

Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Dirk Schulze <dsch...@chromium.org>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Menard, Alexis <alexis...@intel.com>

Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Stephen Chenney <sche...@chromium.org>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: gwsq

Gerrit-Attention: Fredrik Söderquist <f...@opera.com>

Gerrit-Attention: Kent Tamura <tk...@chromium.org>

Gerrit-Comment-Date: Thu, 04 Jun 2026 06:58:12 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Kent Tamura (Gerrit)]

Attention needed from Fredrik Söderquist

Kent Tamura voted and added 1 comment

Votes added by Kent Tamura

Auto-Submit

+1

1 comment

File third_party/blink/renderer/platform/bindings/to_blink_string.cc

Line 55, Patchset 1 (Latest): v8_string->WriteV2(isolate, 0, base::checked_cast<uint32_t>(buffer.size()),

Hidehiko Abe . resolved

clarification: so a crash on overflown (i.e. large bugger) is expected?

Kent Tamura

Yes, it's the expected behavior. It's much beter than passing lower 32-bit of `buffer.size()`.

Open in Gerrit

Related details

Attention is currently required from:

• Fredrik Söderquist

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Gerrit-Comment-Date: Thu, 04 Jun 2026 07:04:36 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

Comment-In-Reply-To: Hidehiko Abe <hide...@chromium.org>

[Fredrik Söderquist (Gerrit)]

Attention needed from Kent Tamura

Fredrik Söderquist voted

Code-Review	+1
Commit-Queue	+2

Open in Gerrit

Related details

Attention is currently required from:

• Kent Tamura

Gerrit-Attention: Kent Tamura <tk...@chromium.org>

Gerrit-Comment-Date: Thu, 04 Jun 2026 08:52:14 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Chromium LUCI CQ (Gerrit)]

Chromium LUCI CQ submitted the change

Change information

Commit message:

blink: Resolve 64-bit truncation issues in renderer/platform/

This is a preparation to enable -Wshorten-64-to-32 compiler flag.

Bug: 514751964

Change-Id: I0c3563fc9e66b8c64d84b52bdc6873ae1f375ea4

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7894986

Commit-Queue: Fredrik Söderquist <f...@opera.com>

Auto-Submit: Kent Tamura <tk...@chromium.org>

Reviewed-by: Hidehiko Abe <hide...@chromium.org>

Reviewed-by: Fredrik Söderquist <f...@opera.com>

Cr-Commit-Position: refs/heads/main@{#1641531}

Files:

• M third_party/blink/renderer/platform/animation/timing_function_test.cc
• M third_party/blink/renderer/platform/bindings/parkable_string_test.cc
• M third_party/blink/renderer/platform/bindings/to_blink_string.cc
• M third_party/blink/renderer/platform/blob/blob_bytes_provider_test.cc
• M third_party/blink/renderer/platform/geometry/float_polygon_test.cc
• M third_party/blink/renderer/platform/media/resource_multi_buffer_data_provider.cc
• M third_party/blink/renderer/platform/media/watch_time_component_unittest.cc
• M third_party/blink/renderer/platform/mediastream/media_stream_audio_test.cc
• M third_party/blink/renderer/platform/mhtml/mhtml_parser_test.cc
• M third_party/blink/renderer/platform/mojo/browser_interface_broker_proxy_impl.cc
• M third_party/blink/renderer/platform/storage/blink_storage_key_mojom_traits_test.cc
• M third_party/blink/renderer/platform/testing/testing_platform_support.cc
• M third_party/blink/renderer/platform/webrtc/convert_to_webrtc_video_frame_buffer.cc
• M third_party/blink/renderer/platform/webrtc/webrtc_video_frame_adapter.cc
• M third_party/blink/renderer/platform/widget/input/input_event_prediction_unittest.cc
• M third_party/blink/renderer/platform/wtf/vector.h

Change size: M

Delta: 16 files changed, 81 insertions(+), 54 deletions(-)

Branch: refs/heads/main

Submit Requirements:

• Code-Review: +1 by Fredrik Söderquist, +1 by Hidehiko Abe

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I0c3563fc9e66b8c64d84b52bdc6873ae1f375ea4

Gerrit-Change-Number: 7894986

Gerrit-PatchSet: 2

Gerrit-Owner: Kent Tamura <tk...@chromium.org>

Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>

Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>

Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>

Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>