Migrate from base::ByteSwap to std::byteswap [chromium/src : main]

0 views
Skip to first unread message

David Benjamin (Gerrit)

unread,
Jan 5, 2026, 5:25:06 PM (4 days ago) Jan 5
to Raphael Kubo da Costa, Stephen Chenney, chromium...@chromium.org, Kentaro Hara, Dirk Schulze, kinuko...@chromium.org, jbrom...@chromium.org, blink-re...@chromium.org, fmalit...@chromium.org, blink-revie...@chromium.org, feature-me...@chromium.org, wfh+...@chromium.org, drott+bl...@chromium.org, blink-...@chromium.org, fserb...@chromium.org, danakj...@chromium.org, jbroma...@chromium.org, blink-reviews-p...@chromium.org

David Benjamin has uploaded the change for review

Commit message

Migrate from base::ByteSwap to std::byteswap
Change-Id: I0795d7c19d6272a8aca5593c1d2366d5c2e4be75

Change diff


Change information

Files:
  • M PRESUBMIT.py
  • M base/numerics/basic_ops_impl.h
  • M base/numerics/byte_conversions.h
  • M base/sys_byteorder.h
  • M content/child/font_warmup_win.cc
  • M media/formats/webm/webm_cluster_parser.cc
  • M media/renderers/paint_canvas_video_renderer_unittest.cc
  • M styleguide/c++/c++-features.md
  • M third_party/blink/renderer/bindings/core/v8/serialization/trailer_reader.cc
  • M third_party/blink/renderer/platform/fonts/opentype/open_type_types.h
  • M third_party/blink/renderer/platform/fonts/simple_font_data.cc
  • M third_party/blink/renderer/platform/wtf/text/text_codec_utf16.cc
  • M third_party/blink/tools/blinkpy/presubmit/audit_non_blink_usage.py
Change size: M
Delta: 13 files changed, 66 insertions(+), 144 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I0795d7c19d6272a8aca5593c1d2366d5c2e4be75
Gerrit-Change-Number: 7397193
Gerrit-PatchSet: 1
Gerrit-Owner: David Benjamin <davi...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

David Benjamin (Gerrit)

unread,
Jan 5, 2026, 5:25:20 PM (4 days ago) Jan 5
to chromium...@chromium.org, Dirk Schulze, Kentaro Hara, Raphael Kubo da Costa, Stephen Chenney, blink-revie...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, danakj...@chromium.org, drott+bl...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, jbrom...@chromium.org, jbroma...@chromium.org, kinuko...@chromium.org, wfh+...@chromium.org

David Benjamin voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I0795d7c19d6272a8aca5593c1d2366d5c2e4be75
Gerrit-Change-Number: 7397193
Gerrit-PatchSet: 1
Gerrit-Owner: David Benjamin <davi...@chromium.org>
Gerrit-Reviewer: David Benjamin <davi...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-Comment-Date: Mon, 05 Jan 2026 22:25:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Nico Weber (Gerrit)

unread,
Jan 6, 2026, 10:38:30 AM (3 days ago) Jan 6
to David Benjamin, Nico Weber, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Kentaro Hara, Raphael Kubo da Costa, Stephen Chenney, blink-revie...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, danakj...@chromium.org, drott+bl...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, jbrom...@chromium.org, jbroma...@chromium.org, kinuko...@chromium.org, wfh+...@chromium.org
Attention needed from David Benjamin

Nico Weber voted and added 1 comment

Votes added by Nico Weber

Code-Review+1
Owners-Override+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Nico Weber . resolved

Thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • David Benjamin
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I0795d7c19d6272a8aca5593c1d2366d5c2e4be75
Gerrit-Change-Number: 7397193
Gerrit-PatchSet: 1
Gerrit-Owner: David Benjamin <davi...@chromium.org>
Gerrit-Reviewer: David Benjamin <davi...@chromium.org>
Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-Attention: David Benjamin <davi...@chromium.org>
Gerrit-Comment-Date: Tue, 06 Jan 2026 15:38:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Nico Weber (Gerrit)

unread,
Jan 6, 2026, 10:39:59 AM (3 days ago) Jan 6
to David Benjamin, Nico Weber, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Kentaro Hara, Raphael Kubo da Costa, Stephen Chenney, blink-revie...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, danakj...@chromium.org, drott+bl...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, jbrom...@chromium.org, jbroma...@chromium.org, kinuko...@chromium.org, wfh+...@chromium.org
Attention needed from David Benjamin

Nico Weber added 1 comment

File styleguide/c++/c++-features.md
Line 1757, Patchset 1 (Latest):**Notes:**
Nico Weber . unresolved

Can you add a link to the discussion thread, either here (see this file for many examples), or at least in the CL description?

Open in Gerrit

Related details

Attention is currently required from:
  • David Benjamin
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I0795d7c19d6272a8aca5593c1d2366d5c2e4be75
    Gerrit-Change-Number: 7397193
    Gerrit-PatchSet: 1
    Gerrit-Owner: David Benjamin <davi...@chromium.org>
    Gerrit-Reviewer: David Benjamin <davi...@chromium.org>
    Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
    Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-CC: Stephen Chenney <sche...@chromium.org>
    Gerrit-Attention: David Benjamin <davi...@chromium.org>
    Gerrit-Comment-Date: Tue, 06 Jan 2026 15:39:52 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    David Benjamin (Gerrit)

    unread,
    Jan 6, 2026, 11:20:55 AM (3 days ago) Jan 6
    to Nico Weber, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Kentaro Hara, Raphael Kubo da Costa, Stephen Chenney, blink-revie...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, danakj...@chromium.org, drott+bl...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, jbrom...@chromium.org, jbroma...@chromium.org, kinuko...@chromium.org, wfh+...@chromium.org

    David Benjamin voted and added 1 comment

    Votes added by David Benjamin

    Commit-Queue+2

    1 comment

    File styleguide/c++/c++-features.md
    Line 1757, Patchset 1:**Notes:**
    Nico Weber . resolved

    Can you add a link to the discussion thread, either here (see this file for many examples), or at least in the CL description?

    David Benjamin

    Done

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I0795d7c19d6272a8aca5593c1d2366d5c2e4be75
      Gerrit-Change-Number: 7397193
      Gerrit-PatchSet: 3
      Gerrit-Owner: David Benjamin <davi...@chromium.org>
      Gerrit-Reviewer: David Benjamin <davi...@chromium.org>
      Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
      Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
      Gerrit-CC: Kentaro Hara <har...@chromium.org>
      Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
      Gerrit-CC: Stephen Chenney <sche...@chromium.org>
      Gerrit-Comment-Date: Tue, 06 Jan 2026 16:20:48 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      Comment-In-Reply-To: Nico Weber <tha...@chromium.org>
      satisfied_requirement
      open
      diffy

      Victor Vianna (Gerrit)

      unread,
      Jan 6, 2026, 12:51:02 PM (3 days ago) Jan 6
      to David Benjamin, Nico Weber, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Kentaro Hara, Raphael Kubo da Costa, Stephen Chenney, blink-revie...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, danakj...@chromium.org, drott+bl...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, jbrom...@chromium.org, jbroma...@chromium.org, kinuko...@chromium.org, wfh+...@chromium.org
      Attention needed from David Benjamin

      Victor Vianna voted Commit-Queue+2

      Commit-Queue+2
      Open in Gerrit

      Related details

      Attention is currently required from:
      • David Benjamin
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I0795d7c19d6272a8aca5593c1d2366d5c2e4be75
      Gerrit-Change-Number: 7397193
      Gerrit-PatchSet: 3
      Gerrit-Owner: David Benjamin <davi...@chromium.org>
      Gerrit-Reviewer: David Benjamin <davi...@chromium.org>
      Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
      Gerrit-Reviewer: Victor Vianna <victor...@google.com>
      Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
      Gerrit-CC: Kentaro Hara <har...@chromium.org>
      Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
      Gerrit-CC: Stephen Chenney <sche...@chromium.org>
      Gerrit-Attention: David Benjamin <davi...@chromium.org>
      Gerrit-Comment-Date: Tue, 06 Jan 2026 17:50:52 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      Jan 6, 2026, 1:28:09 PM (3 days ago) Jan 6
      to David Benjamin, Victor Vianna, Nico Weber, chromium...@chromium.org, Dirk Schulze, Kentaro Hara, Raphael Kubo da Costa, Stephen Chenney, blink-revie...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, danakj...@chromium.org, drott+bl...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, jbrom...@chromium.org, jbroma...@chromium.org, kinuko...@chromium.org, wfh+...@chromium.org

      Chromium LUCI CQ submitted the change with unreviewed changes

      Unreviewed changes

      1 is the latest approved patch-set.
      The change was submitted with unreviewed changes in the following files:

      ```
      The name of the file: styleguide/c++/c++-features.md
      Insertions: 1, Deletions: 1.

      @@ -1756,7 +1756,7 @@
       
       **Notes:**
       *** promo
      -None
      +[Discussion thread](https://groups.google.com/a/chromium.org/g/cxx/c/U2zUF-xOj6A/m/ZiRRZdr7AwAJ)
       ***
       
       ### std::to_underlying <sup>[allowed]</sup>
      ```

      Change information

      Commit message:
      Migrate from base::ByteSwap to std::byteswap

      Change-Id: I0795d7c19d6272a8aca5593c1d2366d5c2e4be75
      Reviewed-by: Nico Weber <tha...@chromium.org>
      Owners-Override: Nico Weber <tha...@chromium.org>
      Commit-Queue: Victor Vianna <victor...@google.com>
      Cr-Commit-Position: refs/heads/main@{#1565099}
      Files:
      • M PRESUBMIT.py
      • M base/numerics/basic_ops_impl.h
      • M base/numerics/byte_conversions.h
      • M base/sys_byteorder.h
      • M content/child/font_warmup_win.cc
      • M media/formats/webm/webm_cluster_parser.cc
      • M media/renderers/paint_canvas_video_renderer_unittest.cc
      • M styleguide/c++/c++-features.md
      • M third_party/blink/renderer/bindings/core/v8/serialization/trailer_reader.cc
      • M third_party/blink/renderer/platform/fonts/opentype/open_type_types.h
      • M third_party/blink/renderer/platform/fonts/simple_font_data.cc
      • M third_party/blink/renderer/platform/wtf/text/text_codec_utf16.cc
      • M third_party/blink/tools/blinkpy/presubmit/audit_non_blink_usage.py
      Change size: M
      Delta: 13 files changed, 66 insertions(+), 144 deletions(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Nico Weber
       Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      


       Gerrit-MessageType: merged 
      

       Gerrit-Project: chromium/src 
      

       Gerrit-Branch: main 
      

       Gerrit-Change-Id: I0795d7c19d6272a8aca5593c1d2366d5c2e4be75 
      

       Gerrit-Change-Number: 7397193 
      

       Gerrit-PatchSet: 4 
      

       Gerrit-Owner: David Benjamin <davi...@chromium.org> 
      

       Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com> 
      

       Gerrit-Reviewer: David Benjamin <davi...@chromium.org> 
      

       Gerrit-Reviewer: Nico Weber <tha...@chromium.org> 
      

       Gerrit-Reviewer: Victor Vianna <victor...@google.com> 
      

      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages