WTF: Introduce string_common.h [chromium/src : main]

0 views

Skip to first unread message

Kent Tamura (Gerrit)

unread,

Jan 7, 2026, 2:34:20 AM (2 days ago) Jan 7

to Kent Tamura, Fredrik Söderquist, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org

Attention needed from Fredrik Söderquist

Kent Tamura voted and added 1 comment

Votes added by Kent Tamura

Auto-Submit	+1
Commit-Queue	+1

1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Kent Tamura . resolved

fs@, would you review this please?

Open in Gerrit

Related details

Attention is currently required from:

Fredrik Söderquist

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Fredrik Söderquist (Gerrit)

unread,

Jan 7, 2026, 4:59:01 AM (2 days ago) Jan 7

to Kent Tamura, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org

Attention needed from Kent Tamura

Fredrik Söderquist voted and added 2 comments

Votes added by Fredrik Söderquist

Code-Review

2 comments

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Fredrik Söderquist . resolved

LGTM w/ a comment on the naming. Feel free to disregard if you prefer the `_common.h` suffix.

Commit Message

Line 7, Patchset 4 (Latest):WTF: Introduce string_common.h

Fredrik Söderquist . unresolved

If it's intended as a point to share implementation for the different `String*` classes, then maybe it should be `string_internal.h` (or so) to more clearly signal that intent? WDYT?