Rename CrashReportStorage, and its remove() method [chromium/src : main]
0 views
Skip to first unread message
Dominic Farolino (Gerrit)
Jan 9, 2026, 4:31:32 PM (2 days ago) Jan 9
to Daniel Cheng, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, alexmo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chasej...@chromium.org, creis...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, navigation...@chromium.org, net-r...@chromium.org
Attention needed from Daniel Cheng, Nasko Oskov and mmenke
Dominic Farolino voted and added 1 comment![]( "Open in Gerrit")
Votes added by Dominic Farolino
| Commit-Queue | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Dominic Farolino . resolved
mmenke@: reporting_browsertest.cc
nasko@: //content/browser/renderer_host
dcheng@: the rest!
Related details
Attention is currently required from:
- Daniel Cheng
- Nasko Oskov
- mmenke
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
mmenke (Gerrit)
Jan 9, 2026, 4:32:12 PM (2 days ago) Jan 9
to Dominic Farolino, Chromium LUCI CQ, Daniel Cheng, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, alexmo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chasej...@chromium.org, creis...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, navigation...@chromium.org, net-r...@chromium.org
Attention needed from Daniel Cheng, Dominic Farolino and Nasko Oskov
mmenke voted and added 1 comment![]( "Open in Gerrit")
Votes added by mmenke
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Daniel Cheng
- Dominic Farolino
- Nasko Oskov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nasko Oskov (Gerrit)
Jan 9, 2026, 4:44:00 PM (2 days ago) Jan 9
to Dominic Farolino, Chromium LUCI CQ, Daniel Cheng, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, alexmo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chasej...@chromium.org, creis...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, navigation...@chromium.org, net-r...@chromium.org
Attention needed from Daniel Cheng and Dominic Farolino
Nasko Oskov voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Daniel Cheng
- Dominic Farolino
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Jan 9, 2026, 4:49:51 PM (2 days ago) Jan 9
to Dominic Farolino, Chromium LUCI CQ, Daniel Cheng, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, alexmo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chasej...@chromium.org, creis...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, navigation...@chromium.org, net-r...@chromium.org
Attention needed from Daniel Cheng and Dominic Farolino
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/57117.
When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.
WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process
Related details
Attention is currently required from:
- Daniel Cheng
- Dominic Farolino
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel Cheng (Gerrit)
Jan 10, 2026, 8:58:21 PM (14 hours ago) Jan 10
to Dominic Farolino, AyeAye, Blink W3C Test Autoroller, Chromium LUCI CQ, Daniel Cheng, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, ashleynewson+w...@chromium.org, android-web...@chromium.org, alexmo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chasej...@chromium.org, creis...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, navigation...@chromium.org, net-r...@chromium.org
Attention needed from Dominic Farolino, Nasko Oskov and mmenke
Daniel Cheng added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 3 (Latest):
Daniel Cheng . unresolved
The change seems fine but it looks like some WPTs still need to be updated?
Related details
Attention is currently required from:
- Dominic Farolino
- Nasko Oskov
- mmenke
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages