[webaudio-testharness] Migrate audioworklet-addmodule-resolution.html [chromium/src : main]
0 views
Skip to first unread message
Michael Wilson (Gerrit)
Dec 30, 2025, 3:51:40 PM (11 days ago) 12/30/25
to Muhammad Saqlain, Hongchan Choi, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Hongchan Choi and Muhammad Saqlain
Michael Wilson voted and added 3 comments![]( "Open in Gerrit")
Votes added by Michael Wilson
| Code-Review | +1 |
3 comments
Patchset-level comments
File-level comment, Patchset 3 (Latest):
Michael Wilson . resolved
LGTM overall, let's also update the variable names in the test messages.
File third_party/blink/web_tests/external/wpt/webaudio/the-audio-api/the-audioworklet-interface/audioworklet-addmodule-resolution.https.html
Line 31, Patchset 3 (Latest):
'"dummyWorkletNode" is an instance of AudioWorkletNode ' +Michael Wilson . unresolved
```suggestion
'"dummyWorkletNodeRealtime" is an instance of AudioWorkletNode ' +
```
Line 40, Patchset 3 (Latest):
'"dummyWorkletNode" is an instance of AudioWorkletNode ' +Michael Wilson . unresolved
```suggestion
'"dummyWorkletNodeOffline" is an instance of AudioWorkletNode ' +
```
Related details
Attention is currently required from:
- Hongchan Choi
- Muhammad Saqlain
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Muhammad Saqlain (Gerrit)
Dec 30, 2025, 7:42:25 PM (11 days ago) 12/30/25
to Hongchan Choi, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Hongchan Choi and Michael Wilson
Muhammad Saqlain added 2 comments![]( "Open in Gerrit")
File third_party/blink/web_tests/external/wpt/webaudio/the-audio-api/the-audioworklet-interface/audioworklet-addmodule-resolution.https.html
Line 31, Patchset 3:
'"dummyWorkletNode" is an instance of AudioWorkletNode ' +Michael Wilson . resolved
```suggestion
'"dummyWorkletNodeRealtime" is an instance of AudioWorkletNode ' +
```
Muhammad Saqlain
Fix applied.
Line 40, Patchset 3:
'"dummyWorkletNode" is an instance of AudioWorkletNode ' +Michael Wilson . resolved
```suggestion
'"dummyWorkletNodeOffline" is an instance of AudioWorkletNode ' +
```
Attention is currently required from:
- Hongchan Choi
- Michael Wilson
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Wilson (Gerrit)
Jan 2, 2026, 1:07:11 PM (9 days ago) Jan 2
to Muhammad Saqlain, Hongchan Choi, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Hongchan Choi and Muhammad Saqlain
Michael Wilson voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Hongchan Choi
- Muhammad Saqlain
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hongchan Choi (Gerrit)
Jan 5, 2026, 5:54:22 PM (5 days ago) Jan 5
to Muhammad Saqlain, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Muhammad Saqlain
Hongchan Choi voted and added 2 comments![]( "Open in Gerrit")
Votes added by Hongchan Choi
| Code-Review | +1 |
2 comments
Patchset-level comments
File third_party/blink/web_tests/external/wpt/webaudio/the-audio-api/the-audioworklet-interface/audioworklet-addmodule-resolution.https.html
Line 42, Patchset 4 (Latest):
}, 'Test the invocation order of AudioWorklet.addModule() ' +
'and BaseAudioContext');
</script>Hongchan Choi . unresolved
```suggestion
}, 'Test the invocation order of AudioWorklet.addModule() ' +
'and BaseAudioContext');
</script>
```
Related details
Attention is currently required from:
- Muhammad Saqlain
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Muhammad Saqlain (Gerrit)
Jan 8, 2026, 4:31:46 PM (2 days ago) Jan 8
to Hongchan Choi, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Hongchan Choi and Michael Wilson
Muhammad Saqlain added 1 comment![]( "Open in Gerrit")
File third_party/blink/web_tests/external/wpt/webaudio/the-audio-api/the-audioworklet-interface/audioworklet-addmodule-resolution.https.html
Line 42, Patchset 4:
}, 'Test the invocation order of AudioWorklet.addModule() ' +
'and BaseAudioContext');
</script>Hongchan Choi . resolved
```suggestion
}, 'Test the invocation order of AudioWorklet.addModule() ' +
'and BaseAudioContext');
</script>
```
Attention is currently required from:
- Hongchan Choi
- Michael Wilson
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hongchan Choi (Gerrit)
Jan 8, 2026, 5:15:49 PM (2 days ago) Jan 8
to Muhammad Saqlain, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Michael Wilson and Muhammad Saqlain
Hongchan Choi voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Michael Wilson
- Muhammad Saqlain
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Wilson (Gerrit)
Jan 8, 2026, 5:47:02 PM (2 days ago) Jan 8
to Muhammad Saqlain, Hongchan Choi, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Muhammad Saqlain
Michael Wilson voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Muhammad Saqlain
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Jan 8, 2026, 5:54:40 PM (2 days ago) Jan 8
to Muhammad Saqlain, Hongchan Choi, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Muhammad Saqlain
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/57092.
When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.
WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process
Related details
Attention is currently required from:
- Muhammad Saqlain
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Muhammad Saqlain (Gerrit)
Jan 9, 2026, 6:50:45 PM (2 days ago) Jan 9
to Blink W3C Test Autoroller, Hongchan Choi, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Muhammad Saqlain voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jan 9, 2026, 7:17:46 PM (2 days ago) Jan 9
to Muhammad Saqlain, Blink W3C Test Autoroller, Hongchan Choi, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[webaudio-testharness] Migrate audioworklet-addmodule-resolution.html
Convert audioworklet-addmodule-resolution.https.html from the legacy
audit.js runner to pure testharness.js
Bug: 396477778
Change-Id: Icbce978f433946ac3473ef76ceb74de26126a73a
Reviewed-by: Michael Wilson <mjwi...@chromium.org>
Commit-Queue: Muhammad Saqlain <saq...@chromium.org>
Reviewed-by: Hongchan Choi <hong...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1567284}
Files:
- M third_party/blink/web_tests/external/wpt/webaudio/the-audio-api/the-audioworklet-interface/audioworklet-addmodule-resolution.https.html
Change size: M
Delta: 1 file changed, 25 insertions(+), 40 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Hongchan Choi, +1 by Michael Wilson
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Jan 9, 2026, 9:06:04 PM (2 days ago) Jan 9
to Muhammad Saqlain, Chromium LUCI CQ, Hongchan Choi, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/57092
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages