[webaudio-testharness] Migrate audiobuffersource-duration-loop.html [chromium/src : main]
0 views
Skip to first unread message
Michael Wilson (Gerrit)
Dec 29, 2025, 8:40:02 PM (13 days ago) 12/29/25
to Muhammad Saqlain, Hongchan Choi, Chromium LUCI CQ, chromium...@chromium.org, AyeAye, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Hongchan Choi and Muhammad Saqlain
Michael Wilson voted and added 2 comments![]( "Open in Gerrit")
Votes added by Michael Wilson
| Code-Review | +1 |
2 comments
Patchset-level comments
File third_party/blink/web_tests/external/wpt/webaudio/the-audio-api/the-audiobuffersourcenode-interface/audiobuffersource-duration-loop.html
Line 23, Patchset 2 (Latest):
const source = new AudioBufferSourceNode(context);
source.loop = true;
source.loopStart = 1024 / context.sampleRate;
source.loopEnd = 2048 / context.sampleRate;
source.buffer = buffer;Michael Wilson . unresolved
Nit: we can pass the properties into the constructor:
```suggestion
const source = new AudioBufferSourceNode(context, {
buffer,
loop: true,
loopEnd: 2048 / context.sampleRate,
loopStart: 1024 / context.sampleRate,
});
```
Related details
Attention is currently required from:
- Hongchan Choi
- Muhammad Saqlain
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Muhammad Saqlain (Gerrit)
Dec 29, 2025, 9:10:41 PM (13 days ago) 12/29/25
to Hongchan Choi, Chromium LUCI CQ, chromium...@chromium.org, AyeAye, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Hongchan Choi
Muhammad Saqlain added 1 comment![]( "Open in Gerrit")
File third_party/blink/web_tests/external/wpt/webaudio/the-audio-api/the-audiobuffersourcenode-interface/audiobuffersource-duration-loop.html
Line 23, Patchset 2 (Latest):
const source = new AudioBufferSourceNode(context);
source.loop = true;
source.loopStart = 1024 / context.sampleRate;
source.loopEnd = 2048 / context.sampleRate;
source.buffer = buffer;Michael Wilson . resolved
Nit: we can pass the properties into the constructor:
```suggestion
const source = new AudioBufferSourceNode(context, {
buffer,
loop: true,
loopEnd: 2048 / context.sampleRate,
loopStart: 1024 / context.sampleRate,
});
```
Muhammad Saqlain
Fix applied.
Related details
Attention is currently required from:
- Hongchan Choi
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Wilson (Gerrit)
Dec 29, 2025, 10:38:59 PM (13 days ago) 12/29/25
to Muhammad Saqlain, Hongchan Choi, Chromium LUCI CQ, chromium...@chromium.org, AyeAye, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Hongchan Choi and Muhammad Saqlain
Michael Wilson added 2 comments![]( "Open in Gerrit")
File third_party/blink/web_tests/external/wpt/webaudio/the-audio-api/the-audiobuffersourcenode-interface/audiobuffersource-duration-loop.html
Line 9, Patchset 3 (Latest):
<script src="/webaudio/resources/audit-util.js"></script>Michael Wilson . unresolved
We may not need audit-util.js now (sorry I missed this in my initial review), could you please check?
Related details
Attention is currently required from:
- Hongchan Choi
- Muhammad Saqlain
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Muhammad Saqlain (Gerrit)
Dec 30, 2025, 3:29:18 PM (12 days ago) 12/30/25
to Hongchan Choi, Chromium LUCI CQ, chromium...@chromium.org, AyeAye, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Hongchan Choi and Michael Wilson
Muhammad Saqlain added 2 comments![]( "Open in Gerrit")
File third_party/blink/web_tests/external/wpt/webaudio/the-audio-api/the-audiobuffersourcenode-interface/audiobuffersource-duration-loop.html
Line 9, Patchset 3:
<script src="/webaudio/resources/audit-util.js"></script>Michael Wilson . resolved
We may not need audit-util.js now (sorry I missed this in my initial review), could you please check?
Muhammad Saqlain
Done
Please fix the indentation here.
Attention is currently required from:
- Hongchan Choi
- Michael Wilson
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Wilson (Gerrit)
Dec 30, 2025, 3:43:03 PM (12 days ago) 12/30/25
to Muhammad Saqlain, Hongchan Choi, Chromium LUCI CQ, chromium...@chromium.org, AyeAye, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Hongchan Choi and Muhammad Saqlain
Michael Wilson voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Hongchan Choi
- Muhammad Saqlain
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hongchan Choi (Gerrit)
Jan 5, 2026, 5:43:56 PM (6 days ago) Jan 5
to Muhammad Saqlain, Chromium LUCI CQ, chromium...@chromium.org, AyeAye, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Muhammad Saqlain
Hongchan Choi voted and added 2 comments![]( "Open in Gerrit")
Votes added by Hongchan Choi
| Code-Review | +1 |
2 comments
Patchset-level comments
File third_party/blink/web_tests/external/wpt/webaudio/the-audio-api/the-audiobuffersourcenode-interface/audiobuffersource-duration-loop.html
Line 16, Patchset 4 (Latest):
const buffer = context.createBuffer(1, 2048, context.sampleRate);Hongchan Choi . unresolved
Can we use `new AudioBuffer()` instead?
Related details
Attention is currently required from:
- Muhammad Saqlain
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Muhammad Saqlain (Gerrit)
Jan 8, 2026, 4:31:51 PM (3 days ago) Jan 8
to Hongchan Choi, Chromium LUCI CQ, chromium...@chromium.org, AyeAye, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Hongchan Choi and Michael Wilson
Muhammad Saqlain added 1 comment![]( "Open in Gerrit")
File third_party/blink/web_tests/external/wpt/webaudio/the-audio-api/the-audiobuffersourcenode-interface/audiobuffersource-duration-loop.html
Line 16, Patchset 4:
const buffer = context.createBuffer(1, 2048, context.sampleRate);Hongchan Choi . resolved
Can we use `new AudioBuffer()` instead?
Attention is currently required from:
- Hongchan Choi
- Michael Wilson
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Wilson (Gerrit)
Jan 8, 2026, 5:47:55 PM (3 days ago) Jan 8
to Muhammad Saqlain, Hongchan Choi, Chromium LUCI CQ, chromium...@chromium.org, AyeAye, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Muhammad Saqlain
Michael Wilson added 2 comments![]( "Open in Gerrit")
File third_party/blink/web_tests/external/wpt/webaudio/the-audio-api/the-audiobuffersourcenode-interface/audiobuffersource-duration-loop.html
Line 17, Patchset 5 (Latest):
numberOfChannels: 1, Michael Wilson . unresolved
Please fix this WARNING reported by Trailing Whitespace: Please remove the trailing whitespace.
Please remove the trailing whitespace.
Line 18, Patchset 5 (Latest):
length: 2048, Michael Wilson . unresolved
Please fix this WARNING reported by Trailing Whitespace: Please remove the trailing whitespace.
Please remove the trailing whitespace.
Related details
Attention is currently required from:
- Muhammad Saqlain
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Muhammad Saqlain (Gerrit)
Jan 9, 2026, 6:52:57 PM (2 days ago) Jan 9
to Hongchan Choi, Chromium LUCI CQ, chromium...@chromium.org, AyeAye, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Michael Wilson
Muhammad Saqlain added 2 comments![]( "Open in Gerrit")
File third_party/blink/web_tests/external/wpt/webaudio/the-audio-api/the-audiobuffersourcenode-interface/audiobuffersource-duration-loop.html
Please fix this WARNING reported by Trailing Whitespace: Please remove the trailing whitespace.
Please remove the trailing whitespace.
Muhammad Saqlain
thank you for noticing
Please fix this WARNING reported by Trailing Whitespace: Please remove the trailing whitespace.
Please remove the trailing whitespace.
Attention is currently required from:
- Michael Wilson
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Wilson (Gerrit)
Jan 9, 2026, 7:55:43 PM (2 days ago) Jan 9
to Muhammad Saqlain, Hongchan Choi, Chromium LUCI CQ, chromium...@chromium.org, AyeAye, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Hongchan Choi and Muhammad Saqlain
Michael Wilson voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Hongchan Choi
- Muhammad Saqlain
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages