Make arrow focus changes for menuitems loop. [chromium/src : main]

0 views

Skip to first unread message

unread,

Jan 9, 2026, 3:42:05 PM (2 days ago) Jan 9

to David Baron, Mason Freed, AyeAye, chromium...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org

Attention needed from Mason Freed

David Baron added 2 comments

Commit Message

Line 9, Patchset 3 (Latest):This makes right/left arrows on the menubar and up/down arrows on the

David Baron . unresolved

Does this seem like the right behavior?

File third_party/blink/renderer/core/html/menu_item_list.cc

Line 177, Patchset 2: // Directional focus in menu item lists always loops, whether in a menubar

David Baron . unresolved

This seems like one of those cases where there's probably a clever way to make this code 5-10 lines shorter, but I don't currently see it...

Attention is currently required from:

Submit Requirements:

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages