[WPT] Stop comparing font-family in select listbox UA style test [chromium/src : main]

0 views
Skip to first unread message

Hyowon Kim (Gerrit)

unread,
Jan 7, 2026, 1:34:00 AM (4 days ago) Jan 7
to Jonathan Lee, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, mac-r...@chromium.org
Attention needed from Jonathan Lee

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Jonathan Lee
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I23b3982c276f5bd0b20de96c1dec312b0ff1a9f7
Gerrit-Change-Number: 7367699
Gerrit-PatchSet: 3
Gerrit-Owner: Hyowon Kim <hyo...@igalia.com>
Gerrit-Reviewer: Hyowon Kim <hyo...@igalia.com>
Gerrit-Reviewer: Jonathan Lee <jonath...@google.com>
Gerrit-Attention: Jonathan Lee <jonath...@google.com>
Gerrit-Comment-Date: Wed, 07 Jan 2026 06:33:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Jonathan Lee (Gerrit)

unread,
Jan 7, 2026, 12:34:19 PM (4 days ago) Jan 7
to Hyowon Kim, Mason Freed, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, mac-r...@chromium.org
Attention needed from Hyowon Kim and Mason Freed

Jonathan Lee added 1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Jonathan Lee . resolved

Thanks for the patch. I don't know enough about `<select>` to review, so I've swapped in masonf@ (who had some activity [in `the-select-element/`][0]) to take a look or reroute to someone who can.

[0]: https://github.com/web-platform-tests/wpt/commits/master/html/rendering/widgets/the-select-element

Open in Gerrit

Related details

Attention is currently required from:
  • Hyowon Kim
  • Mason Freed
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I23b3982c276f5bd0b20de96c1dec312b0ff1a9f7
Gerrit-Change-Number: 7367699
Gerrit-PatchSet: 3
Gerrit-Owner: Hyowon Kim <hyo...@igalia.com>
Gerrit-Reviewer: Hyowon Kim <hyo...@igalia.com>
Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
Gerrit-CC: Jonathan Lee <jonath...@google.com>
Gerrit-Attention: Mason Freed <mas...@chromium.org>
Gerrit-Attention: Hyowon Kim <hyo...@igalia.com>
Gerrit-Comment-Date: Wed, 07 Jan 2026 17:34:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Mason Freed (Gerrit)

unread,
Jan 7, 2026, 1:05:05 PM (4 days ago) Jan 7
to Hyowon Kim, Jonathan Lee, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, mac-r...@chromium.org
Attention needed from Hyowon Kim and Joey Arhar

Mason Freed voted and added 1 comment

Votes added by Mason Freed

Code-Review+1

1 comment

Patchset-level comments
Mason Freed . resolved

Looks reasonable to me! +jarhar@ just in case I missed anything - please wait for him to do a quick review also before landing this.

Open in Gerrit

Related details

Attention is currently required from:
  • Hyowon Kim
  • Joey Arhar
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I23b3982c276f5bd0b20de96c1dec312b0ff1a9f7
Gerrit-Change-Number: 7367699
Gerrit-PatchSet: 3
Gerrit-Owner: Hyowon Kim <hyo...@igalia.com>
Gerrit-Reviewer: Hyowon Kim <hyo...@igalia.com>
Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
Gerrit-CC: Jonathan Lee <jonath...@google.com>
Gerrit-Attention: Joey Arhar <jar...@chromium.org>
Gerrit-Attention: Hyowon Kim <hyo...@igalia.com>
Gerrit-Comment-Date: Wed, 07 Jan 2026 18:04:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Joey Arhar (Gerrit)

unread,
Jan 8, 2026, 12:19:28 PM (3 days ago) Jan 8
to Hyowon Kim, Mason Freed, Jonathan Lee, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, mac-r...@chromium.org
Attention needed from Hyowon Kim

Joey Arhar added 1 comment

Patchset-level comments
Joey Arhar . unresolved

Simon added this test, and I think we should consult him before changing it: https://github.com/web-platform-tests/wpt/pull/35801

Want to make a PR to WPT on github and add him as a reviewer?

Open in Gerrit

Related details

Attention is currently required from:
  • Hyowon Kim
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I23b3982c276f5bd0b20de96c1dec312b0ff1a9f7
    Gerrit-Change-Number: 7367699
    Gerrit-PatchSet: 3
    Gerrit-Owner: Hyowon Kim <hyo...@igalia.com>
    Gerrit-Reviewer: Hyowon Kim <hyo...@igalia.com>
    Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
    Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
    Gerrit-CC: Jonathan Lee <jonath...@google.com>
    Gerrit-Attention: Hyowon Kim <hyo...@igalia.com>
    Gerrit-Comment-Date: Thu, 08 Jan 2026 17:19:12 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Hyowon Kim (Gerrit)

    unread,
    Jan 8, 2026, 9:21:25 PM (3 days ago) Jan 8
    to Mason Freed, Jonathan Lee, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, mac-r...@chromium.org
    Attention needed from Joey Arhar

    Hyowon Kim added 1 comment

    Patchset-level comments
    Joey Arhar . unresolved

    Simon added this test, and I think we should consult him before changing it: https://github.com/web-platform-tests/wpt/pull/35801

    Want to make a PR to WPT on github and add him as a reviewer?

    Hyowon Kim

    Following the suggestion, I’ve opened an upstream WPT PR and requested review from the test author:
    https://github.com/web-platform-tests/wpt/pull/57098

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Joey Arhar
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I23b3982c276f5bd0b20de96c1dec312b0ff1a9f7
    Gerrit-Change-Number: 7367699
    Gerrit-PatchSet: 3
    Gerrit-Owner: Hyowon Kim <hyo...@igalia.com>
    Gerrit-Reviewer: Hyowon Kim <hyo...@igalia.com>
    Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
    Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
    Gerrit-CC: Jonathan Lee <jonath...@google.com>
    Gerrit-Attention: Joey Arhar <jar...@chromium.org>
    Gerrit-Comment-Date: Fri, 09 Jan 2026 02:20:54 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Joey Arhar <jar...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Joey Arhar (Gerrit)

    unread,
    Jan 9, 2026, 12:49:47 PM (2 days ago) Jan 9
    to Hyowon Kim, Mason Freed, Jonathan Lee, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, mac-r...@chromium.org
    Attention needed from Hyowon Kim

    Joey Arhar added 1 comment

    Patchset-level comments
    Joey Arhar . unresolved

    Simon added this test, and I think we should consult him before changing it: https://github.com/web-platform-tests/wpt/pull/35801

    Want to make a PR to WPT on github and add him as a reviewer?

    Hyowon Kim

    Following the suggestion, I’ve opened an upstream WPT PR and requested review from the test author:
    https://github.com/web-platform-tests/wpt/pull/57098

    Joey Arhar

    thanks! I'm guessing we don't need this patch anymore then

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Hyowon Kim
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I23b3982c276f5bd0b20de96c1dec312b0ff1a9f7
      Gerrit-Change-Number: 7367699
      Gerrit-PatchSet: 3
      Gerrit-Owner: Hyowon Kim <hyo...@igalia.com>
      Gerrit-Reviewer: Hyowon Kim <hyo...@igalia.com>
      Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
      Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
      Gerrit-CC: Jonathan Lee <jonath...@google.com>
      Gerrit-Attention: Hyowon Kim <hyo...@igalia.com>
      Gerrit-Comment-Date: Fri, 09 Jan 2026 17:49:36 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Joey Arhar <jar...@chromium.org>
      Comment-In-Reply-To: Hyowon Kim <hyo...@igalia.com>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages